|
 |
233933 |
From ad40c0783e84e5e54a83aeb20a52f720cc881b0c Mon Sep 17 00:00:00 2001
|
|
|
233933 |
From: Mohammed Rafi KC <rkavunga@redhat.com>
|
|
|
233933 |
Date: Thu, 11 Jul 2019 12:46:22 +0530
|
|
|
233933 |
Subject: [PATCH 239/255] Revert "ec/fini: Fix race with ec_fini and ec_notify"
|
|
|
233933 |
|
|
|
233933 |
This reverts commit 998d9b8b5e271f407e1c654c34f45f0db36abc71.
|
|
|
233933 |
|
|
|
233933 |
BUG: 1471742
|
|
|
233933 |
Change-Id: Ifccb8a22d9ef96c22b32dcb4b82bf4d21cf85484
|
|
|
233933 |
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
|
|
|
233933 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/175948
|
|
|
233933 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
233933 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
233933 |
---
|
|
|
233933 |
libglusterfs/src/glusterfs/xlator.h | 3 ---
|
|
|
233933 |
libglusterfs/src/libglusterfs.sym | 1 -
|
|
|
233933 |
libglusterfs/src/xlator.c | 21 ---------------------
|
|
|
233933 |
xlators/cluster/ec/src/ec-heal.c | 4 ----
|
|
|
233933 |
xlators/cluster/ec/src/ec-heald.c | 6 ------
|
|
|
233933 |
xlators/cluster/ec/src/ec.c | 3 ---
|
|
|
233933 |
6 files changed, 38 deletions(-)
|
|
|
233933 |
|
|
|
233933 |
diff --git a/libglusterfs/src/glusterfs/xlator.h b/libglusterfs/src/glusterfs/xlator.h
|
|
|
233933 |
index 09e463e..8998976 100644
|
|
|
233933 |
--- a/libglusterfs/src/glusterfs/xlator.h
|
|
|
233933 |
+++ b/libglusterfs/src/glusterfs/xlator.h
|
|
|
233933 |
@@ -1092,7 +1092,4 @@ gluster_graph_take_reference(xlator_t *tree);
|
|
|
233933 |
|
|
|
233933 |
gf_boolean_t
|
|
|
233933 |
mgmt_is_multiplexed_daemon(char *name);
|
|
|
233933 |
-
|
|
|
233933 |
-gf_boolean_t
|
|
|
233933 |
-xlator_is_cleanup_starting(xlator_t *this);
|
|
|
233933 |
#endif /* _XLATOR_H */
|
|
|
233933 |
diff --git a/libglusterfs/src/libglusterfs.sym b/libglusterfs/src/libglusterfs.sym
|
|
|
233933 |
index 86215d2..05f93b4 100644
|
|
|
233933 |
--- a/libglusterfs/src/libglusterfs.sym
|
|
|
233933 |
+++ b/libglusterfs/src/libglusterfs.sym
|
|
|
233933 |
@@ -1160,4 +1160,3 @@ glusterfs_process_svc_attach_volfp
|
|
|
233933 |
glusterfs_mux_volfile_reconfigure
|
|
|
233933 |
glusterfs_process_svc_detach
|
|
|
233933 |
mgmt_is_multiplexed_daemon
|
|
|
233933 |
-xlator_is_cleanup_starting
|
|
|
233933 |
diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c
|
|
|
233933 |
index fbfbbe2..022c3ed 100644
|
|
|
233933 |
--- a/libglusterfs/src/xlator.c
|
|
|
233933 |
+++ b/libglusterfs/src/xlator.c
|
|
|
233933 |
@@ -1486,24 +1486,3 @@ mgmt_is_multiplexed_daemon(char *name)
|
|
|
233933 |
}
|
|
|
233933 |
return _gf_false;
|
|
|
233933 |
}
|
|
|
233933 |
-
|
|
|
233933 |
-gf_boolean_t
|
|
|
233933 |
-xlator_is_cleanup_starting(xlator_t *this)
|
|
|
233933 |
-{
|
|
|
233933 |
- gf_boolean_t cleanup = _gf_false;
|
|
|
233933 |
- glusterfs_graph_t *graph = NULL;
|
|
|
233933 |
- xlator_t *xl = NULL;
|
|
|
233933 |
-
|
|
|
233933 |
- if (!this)
|
|
|
233933 |
- goto out;
|
|
|
233933 |
- graph = this->graph;
|
|
|
233933 |
-
|
|
|
233933 |
- if (!graph)
|
|
|
233933 |
- goto out;
|
|
|
233933 |
-
|
|
|
233933 |
- xl = graph->first;
|
|
|
233933 |
- if (xl && xl->cleanup_starting)
|
|
|
233933 |
- cleanup = _gf_true;
|
|
|
233933 |
-out:
|
|
|
233933 |
- return cleanup;
|
|
|
233933 |
-}
|
|
|
233933 |
diff --git a/xlators/cluster/ec/src/ec-heal.c b/xlators/cluster/ec/src/ec-heal.c
|
|
|
233933 |
index 8844c29..2fa1f11 100644
|
|
|
233933 |
--- a/xlators/cluster/ec/src/ec-heal.c
|
|
|
233933 |
+++ b/xlators/cluster/ec/src/ec-heal.c
|
|
|
233933 |
@@ -2855,10 +2855,6 @@ ec_replace_brick_heal_wrap(void *opaque)
|
|
|
233933 |
itable = ec->xl->itable;
|
|
|
233933 |
else
|
|
|
233933 |
goto out;
|
|
|
233933 |
-
|
|
|
233933 |
- if (xlator_is_cleanup_starting(ec->xl))
|
|
|
233933 |
- goto out;
|
|
|
233933 |
-
|
|
|
233933 |
ret = ec_replace_heal(ec, itable->root);
|
|
|
233933 |
out:
|
|
|
233933 |
return ret;
|
|
|
233933 |
diff --git a/xlators/cluster/ec/src/ec-heald.c b/xlators/cluster/ec/src/ec-heald.c
|
|
|
233933 |
index 91512d7..edf5e11 100644
|
|
|
233933 |
--- a/xlators/cluster/ec/src/ec-heald.c
|
|
|
233933 |
+++ b/xlators/cluster/ec/src/ec-heald.c
|
|
|
233933 |
@@ -444,9 +444,6 @@ unlock:
|
|
|
233933 |
int
|
|
|
233933 |
ec_shd_full_healer_spawn(xlator_t *this, int subvol)
|
|
|
233933 |
{
|
|
|
233933 |
- if (xlator_is_cleanup_starting(this))
|
|
|
233933 |
- return -1;
|
|
|
233933 |
-
|
|
|
233933 |
return ec_shd_healer_spawn(this, NTH_FULL_HEALER(this, subvol),
|
|
|
233933 |
ec_shd_full_healer);
|
|
|
233933 |
}
|
|
|
233933 |
@@ -454,9 +451,6 @@ ec_shd_full_healer_spawn(xlator_t *this, int subvol)
|
|
|
233933 |
int
|
|
|
233933 |
ec_shd_index_healer_spawn(xlator_t *this, int subvol)
|
|
|
233933 |
{
|
|
|
233933 |
- if (xlator_is_cleanup_starting(this))
|
|
|
233933 |
- return -1;
|
|
|
233933 |
-
|
|
|
233933 |
return ec_shd_healer_spawn(this, NTH_INDEX_HEALER(this, subvol),
|
|
|
233933 |
ec_shd_index_healer);
|
|
|
233933 |
}
|
|
|
233933 |
diff --git a/xlators/cluster/ec/src/ec.c b/xlators/cluster/ec/src/ec.c
|
|
|
233933 |
index df5912c..264582a 100644
|
|
|
233933 |
--- a/xlators/cluster/ec/src/ec.c
|
|
|
233933 |
+++ b/xlators/cluster/ec/src/ec.c
|
|
|
233933 |
@@ -486,9 +486,6 @@ ec_set_up_state(ec_t *ec, uintptr_t index_mask, uintptr_t new_state)
|
|
|
233933 |
{
|
|
|
233933 |
uintptr_t current_state = 0;
|
|
|
233933 |
|
|
|
233933 |
- if (xlator_is_cleanup_starting(ec->xl))
|
|
|
233933 |
- return _gf_false;
|
|
|
233933 |
-
|
|
|
233933 |
if ((ec->xl_notify & index_mask) == 0) {
|
|
|
233933 |
ec->xl_notify |= index_mask;
|
|
|
233933 |
ec->xl_notify_count++;
|
|
|
233933 |
--
|
|
|
233933 |
1.8.3.1
|
|
|
233933 |
|