|
 |
50dc83 |
From 1c55f3633f748629cd0484f79b6c49101eb2df82 Mon Sep 17 00:00:00 2001
|
|
|
50dc83 |
From: Sunny Kumar <sunkumar@redhat.com>
|
|
|
50dc83 |
Date: Mon, 8 Jul 2019 11:47:28 +0530
|
|
|
50dc83 |
Subject: [PATCH 226/255] geo-rep : fix gluster command path for non-root
|
|
|
50dc83 |
session
|
|
|
50dc83 |
|
|
|
50dc83 |
Problem:
|
|
|
50dc83 |
gluster command not found.
|
|
|
50dc83 |
|
|
|
50dc83 |
Cause:
|
|
|
50dc83 |
In Volinfo class we issue command 'gluster vol info' to get information
|
|
|
50dc83 |
about volume like getting brick_root to perform various operation.
|
|
|
50dc83 |
When geo-rep session is configured for non-root user Volinfo class
|
|
|
50dc83 |
fails to issue gluster command due to unavailability of gluster
|
|
|
50dc83 |
binary path for non-root user.
|
|
|
50dc83 |
|
|
|
50dc83 |
Solution:
|
|
|
50dc83 |
Use config value 'slave-gluster-command-dir'/'gluster-command-dir' to get path
|
|
|
50dc83 |
for gluster command based on caller.
|
|
|
50dc83 |
|
|
|
50dc83 |
>Backport of:
|
|
|
50dc83 |
>Upstream Patch: https://review.gluster.org/#/c/glusterfs/+/22920/.
|
|
|
50dc83 |
>fixes: bz#1722740
|
|
|
50dc83 |
>Change-Id: I4ec46373da01f5d00ecd160c4e8c6239da8b3859
|
|
|
50dc83 |
>Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
|
|
|
50dc83 |
|
|
|
50dc83 |
BUG: 1712591
|
|
|
50dc83 |
Change-Id: Ifea2927253a9521fa459fea6de8a60085c3413f6
|
|
|
50dc83 |
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
|
|
|
50dc83 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/175485
|
|
|
50dc83 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
50dc83 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
50dc83 |
---
|
|
|
50dc83 |
geo-replication/syncdaemon/monitor.py | 4 ++--
|
|
|
50dc83 |
geo-replication/syncdaemon/syncdutils.py | 12 +++++++++---
|
|
|
50dc83 |
2 files changed, 11 insertions(+), 5 deletions(-)
|
|
|
50dc83 |
|
|
|
50dc83 |
diff --git a/geo-replication/syncdaemon/monitor.py b/geo-replication/syncdaemon/monitor.py
|
|
|
50dc83 |
index c45ef24..234f3f1 100644
|
|
|
50dc83 |
--- a/geo-replication/syncdaemon/monitor.py
|
|
|
50dc83 |
+++ b/geo-replication/syncdaemon/monitor.py
|
|
|
50dc83 |
@@ -369,7 +369,7 @@ def distribute(master, slave):
|
|
|
50dc83 |
if rconf.args.use_gconf_volinfo:
|
|
|
50dc83 |
mvol = VolinfoFromGconf(master.volume, master=True)
|
|
|
50dc83 |
else:
|
|
|
50dc83 |
- mvol = Volinfo(master.volume, master.host)
|
|
|
50dc83 |
+ mvol = Volinfo(master.volume, master.host, master=True)
|
|
|
50dc83 |
logging.debug('master bricks: ' + repr(mvol.bricks))
|
|
|
50dc83 |
prelude = []
|
|
|
50dc83 |
slave_host = None
|
|
|
50dc83 |
@@ -385,7 +385,7 @@ def distribute(master, slave):
|
|
|
50dc83 |
if rconf.args.use_gconf_volinfo:
|
|
|
50dc83 |
svol = VolinfoFromGconf(slave.volume, master=False)
|
|
|
50dc83 |
else:
|
|
|
50dc83 |
- svol = Volinfo(slave.volume, "localhost", prelude)
|
|
|
50dc83 |
+ svol = Volinfo(slave.volume, "localhost", prelude, master=False)
|
|
|
50dc83 |
|
|
|
50dc83 |
sbricks = svol.bricks
|
|
|
50dc83 |
suuid = svol.uuid
|
|
|
50dc83 |
diff --git a/geo-replication/syncdaemon/syncdutils.py b/geo-replication/syncdaemon/syncdutils.py
|
|
|
50dc83 |
index 3f41b5f..2ee10ac 100644
|
|
|
50dc83 |
--- a/geo-replication/syncdaemon/syncdutils.py
|
|
|
50dc83 |
+++ b/geo-replication/syncdaemon/syncdutils.py
|
|
|
50dc83 |
@@ -672,7 +672,7 @@ def get_slv_dir_path(slv_host, slv_volume, gfid):
|
|
|
50dc83 |
dir_path = ENOENT
|
|
|
50dc83 |
|
|
|
50dc83 |
if not slv_bricks:
|
|
|
50dc83 |
- slv_info = Volinfo(slv_volume, slv_host)
|
|
|
50dc83 |
+ slv_info = Volinfo(slv_volume, slv_host, master=False)
|
|
|
50dc83 |
slv_bricks = slv_info.bricks
|
|
|
50dc83 |
# Result of readlink would be of format as below.
|
|
|
50dc83 |
# readlink = "../../pgfid[0:2]/pgfid[2:4]/pgfid/basename"
|
|
|
50dc83 |
@@ -854,8 +854,14 @@ class Popen(subprocess.Popen):
|
|
|
50dc83 |
|
|
|
50dc83 |
class Volinfo(object):
|
|
|
50dc83 |
|
|
|
50dc83 |
- def __init__(self, vol, host='localhost', prelude=[]):
|
|
|
50dc83 |
- po = Popen(prelude + ['gluster', '--xml', '--remote-host=' + host,
|
|
|
50dc83 |
+ def __init__(self, vol, host='localhost', prelude=[], master=True):
|
|
|
50dc83 |
+ if master:
|
|
|
50dc83 |
+ gluster_cmd_dir = gconf.get("gluster-command-dir")
|
|
|
50dc83 |
+ else:
|
|
|
50dc83 |
+ gluster_cmd_dir = gconf.get("slave-gluster-command-dir")
|
|
|
50dc83 |
+
|
|
|
50dc83 |
+ gluster_cmd = os.path.join(gluster_cmd_dir, 'gluster')
|
|
|
50dc83 |
+ po = Popen(prelude + [gluster_cmd, '--xml', '--remote-host=' + host,
|
|
|
50dc83 |
'volume', 'info', vol],
|
|
|
50dc83 |
stdout=PIPE, stderr=PIPE, universal_newlines=True)
|
|
|
50dc83 |
vix = po.stdout.read()
|
|
|
50dc83 |
--
|
|
|
50dc83 |
1.8.3.1
|
|
|
50dc83 |
|