74b1de
From 3528c4fb59ca4d3efda2cf0689b7549e449bb91b Mon Sep 17 00:00:00 2001
74b1de
From: Rinku Kothiya <rkothiya@redhat.com>
74b1de
Date: Fri, 14 Jun 2019 07:53:06 +0000
74b1de
Subject: [PATCH 224/255] core: replace inet_addr with inet_pton
74b1de
74b1de
Fixes warning raised by RPMDiff on the use of inet_addr, which may
74b1de
impact Ipv6 support
74b1de
74b1de
> upstream patch : https://review.gluster.org/#/c/glusterfs/+/22866/
74b1de
74b1de
>fixes: bz#1721385
74b1de
>Change-Id: Id2d9afa1747efa64bc79d90dd2566bff54deedeb
74b1de
>Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
74b1de
74b1de
BUG: 1698435
74b1de
Change-Id: Id2d9afa1747efa64bc79d90dd2566bff54deedeb
74b1de
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/175318
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
74b1de
---
74b1de
 libglusterfs/src/events.c | 8 +++++++-
74b1de
 1 file changed, 7 insertions(+), 1 deletion(-)
74b1de
74b1de
diff --git a/libglusterfs/src/events.c b/libglusterfs/src/events.c
74b1de
index 9b3a226..2509767 100644
74b1de
--- a/libglusterfs/src/events.c
74b1de
+++ b/libglusterfs/src/events.c
74b1de
@@ -41,6 +41,7 @@ _gf_event(eventtypes_t event, const char *fmt, ...)
74b1de
     char *host = NULL;
74b1de
     struct addrinfo hints;
74b1de
     struct addrinfo *result = NULL;
74b1de
+    xlator_t *this = THIS;
74b1de
 
74b1de
     /* Global context */
74b1de
     ctx = THIS->ctx;
74b1de
@@ -82,7 +83,12 @@ _gf_event(eventtypes_t event, const char *fmt, ...)
74b1de
     /* Socket Configurations */
74b1de
     server.sin_family = AF_INET;
74b1de
     server.sin_port = htons(EVENT_PORT);
74b1de
-    server.sin_addr.s_addr = inet_addr(host);
74b1de
+    ret = inet_pton(server.sin_family, host, &server.sin_addr);
74b1de
+    if (ret <= 0) {
74b1de
+        gf_msg(this->name, GF_LOG_ERROR, EINVAL, LG_MSG_INVALID_ARG,
74b1de
+               "inet_pton failed with return code %d", ret);
74b1de
+        goto out;
74b1de
+    }
74b1de
     memset(&server.sin_zero, '\0', sizeof(server.sin_zero));
74b1de
 
74b1de
     va_start(arguments, fmt);
74b1de
-- 
74b1de
1.8.3.1
74b1de