17b94a
From d2319a4746ba07ada5b3a20462ec2900e1c03c5a Mon Sep 17 00:00:00 2001
17b94a
From: Atin Mukherjee <amukherj@redhat.com>
17b94a
Date: Thu, 13 Jun 2019 19:56:32 +0530
17b94a
Subject: [PATCH 192/192] build: Ensure gluster-cli package is built as part of
17b94a
 client build
17b94a
17b94a
Till RHGS 3.4.x RHGS client was shipping gluster-cli rpm. With RHGS 3.5
17b94a
which is a rebase of glusterfs 6.0 gluster-cli is only built for server.
17b94a
gluster cli offers a remote cli execution capability with --remote-host
17b94a
option for which you need not to have cli and glusterd co located and
17b94a
hence shipping cli as part of the client package is mandatory. With out
17b94a
this change the client upgrade for RHEL minor versions are also broken.
17b94a
17b94a
>Fixes: bz#1720615
17b94a
>Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
17b94a
>Signed-off-by: Niels de Vos <ndevos@redhat.com>
17b94a
17b94a
upstream patch: https://review.gluster.org/#/c/glusterfs/+/22868/
17b94a
17b94a
BUG: 1720079
17b94a
Change-Id: I11ec3e2b4d98b3e701147c60ca797d54570d598e
17b94a
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/173388
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
---
17b94a
 cli/src/Makefile.am | 2 --
17b94a
 doc/Makefile.am     | 4 ++--
17b94a
 glusterfs.spec.in   | 9 +++------
17b94a
 3 files changed, 5 insertions(+), 10 deletions(-)
17b94a
17b94a
diff --git a/cli/src/Makefile.am b/cli/src/Makefile.am
17b94a
index 6be070f..3e7511f 100644
17b94a
--- a/cli/src/Makefile.am
17b94a
+++ b/cli/src/Makefile.am
17b94a
@@ -1,6 +1,4 @@
17b94a
-if WITH_SERVER
17b94a
 sbin_PROGRAMS = gluster
17b94a
-endif
17b94a
 
17b94a
 gluster_SOURCES = cli.c registry.c input.c cli-cmd.c cli-rl.c cli-cmd-global.c \
17b94a
 	 cli-cmd-volume.c cli-cmd-peer.c cli-rpc-ops.c cli-cmd-parser.c\
17b94a
diff --git a/doc/Makefile.am b/doc/Makefile.am
17b94a
index 7c04d74..9904767 100644
17b94a
--- a/doc/Makefile.am
17b94a
+++ b/doc/Makefile.am
17b94a
@@ -1,9 +1,9 @@
17b94a
 EXTRA_DIST = glusterfs.8 mount.glusterfs.8 gluster.8 \
17b94a
 			glusterd.8 glusterfsd.8
17b94a
 
17b94a
-man8_MANS = glusterfs.8 mount.glusterfs.8
17b94a
+man8_MANS = gluster.8 glusterfs.8 mount.glusterfs.8
17b94a
 if WITH_SERVER
17b94a
-man8_MANS += gluster.8 glusterd.8 glusterfsd.8
17b94a
+man8_MANS += glusterd.8 glusterfsd.8
17b94a
 endif
17b94a
 
17b94a
 CLEANFILES =
17b94a
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
17b94a
index 29e4a37..c505cd9 100644
17b94a
--- a/glusterfs.spec.in
17b94a
+++ b/glusterfs.spec.in
17b94a
@@ -353,7 +353,6 @@ is in user space and easily manageable.
17b94a
 
17b94a
 This package provides the api include files.
17b94a
 
17b94a
-%if ( 0%{!?_without_server:1} )
17b94a
 %package cli
17b94a
 Summary:          GlusterFS CLI
17b94a
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
17b94a
@@ -368,7 +367,6 @@ called Translators from GNU Hurd kernel. Much of the code in GlusterFS
17b94a
 is in user space and easily manageable.
17b94a
 
17b94a
 This package provides the GlusterFS CLI application and its man page
17b94a
-%endif
17b94a
 
17b94a
 %package cloudsync-plugins
17b94a
 Summary:          Cloudsync Plugins
17b94a
@@ -891,10 +889,8 @@ touch %{buildroot}%{_sharedstatedir}/glusterd/nfs/run/nfs.pid
17b94a
 find ./tests ./run-tests.sh -type f | cpio -pd %{buildroot}%{_prefix}/share/glusterfs
17b94a
 
17b94a
 ## Install bash completion for cli
17b94a
-%if ( 0%{!?_without_server:1} )
17b94a
 install -p -m 0744 -D extras/command-completion/gluster.bash \
17b94a
     %{buildroot}%{_sysconfdir}/bash_completion.d/gluster
17b94a
-%endif
17b94a
 
17b94a
 %if ( 0%{!?_without_server:1} )
17b94a
 echo "RHGS 3.5" > %{buildroot}%{_datadir}/glusterfs/release
17b94a
@@ -1193,12 +1189,10 @@ exit 0
17b94a
 %dir %{_includedir}/glusterfs/api
17b94a
      %{_includedir}/glusterfs/api/*
17b94a
 
17b94a
-%if ( 0%{!?_without_server:1} )
17b94a
 %files cli
17b94a
 %{_sbindir}/gluster
17b94a
 %{_mandir}/man8/gluster.8*
17b94a
 %{_sysconfdir}/bash_completion.d/gluster
17b94a
-%endif
17b94a
 
17b94a
 %files cloudsync-plugins
17b94a
 %dir %{_libdir}/glusterfs/%{version}%{?prereltag}/cloudsync-plugins
17b94a
@@ -1938,6 +1932,9 @@ fi
17b94a
 %endif
17b94a
 
17b94a
 %changelog
17b94a
+* Fri Jun 14 2019 Atin Mukherjee <amukherj@redhat.com>
17b94a
+- Ensure gluster-cli package is part of client build (#1720079)
17b94a
+
17b94a
 * Mon May 27 2019 Jiffin Tony Thottan <jthottan@redhat.com>
17b94a
 - Change the dependency to 2.7.3 on nfs-ganesha for glusterfs-ganesha (#1714078)
17b94a
 
17b94a
-- 
17b94a
1.8.3.1
17b94a