14f8ab
From d2319a4746ba07ada5b3a20462ec2900e1c03c5a Mon Sep 17 00:00:00 2001
14f8ab
From: Atin Mukherjee <amukherj@redhat.com>
14f8ab
Date: Thu, 13 Jun 2019 19:56:32 +0530
14f8ab
Subject: [PATCH 192/192] build: Ensure gluster-cli package is built as part of
14f8ab
 client build
14f8ab
14f8ab
Till RHGS 3.4.x RHGS client was shipping gluster-cli rpm. With RHGS 3.5
14f8ab
which is a rebase of glusterfs 6.0 gluster-cli is only built for server.
14f8ab
gluster cli offers a remote cli execution capability with --remote-host
14f8ab
option for which you need not to have cli and glusterd co located and
14f8ab
hence shipping cli as part of the client package is mandatory. With out
14f8ab
this change the client upgrade for RHEL minor versions are also broken.
14f8ab
14f8ab
>Fixes: bz#1720615
14f8ab
>Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
14f8ab
>Signed-off-by: Niels de Vos <ndevos@redhat.com>
14f8ab
14f8ab
upstream patch: https://review.gluster.org/#/c/glusterfs/+/22868/
14f8ab
14f8ab
BUG: 1720079
14f8ab
Change-Id: I11ec3e2b4d98b3e701147c60ca797d54570d598e
14f8ab
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/173388
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
---
14f8ab
 cli/src/Makefile.am | 2 --
14f8ab
 doc/Makefile.am     | 4 ++--
14f8ab
 glusterfs.spec.in   | 9 +++------
14f8ab
 3 files changed, 5 insertions(+), 10 deletions(-)
14f8ab
14f8ab
diff --git a/cli/src/Makefile.am b/cli/src/Makefile.am
14f8ab
index 6be070f..3e7511f 100644
14f8ab
--- a/cli/src/Makefile.am
14f8ab
+++ b/cli/src/Makefile.am
14f8ab
@@ -1,6 +1,4 @@
14f8ab
-if WITH_SERVER
14f8ab
 sbin_PROGRAMS = gluster
14f8ab
-endif
14f8ab
 
14f8ab
 gluster_SOURCES = cli.c registry.c input.c cli-cmd.c cli-rl.c cli-cmd-global.c \
14f8ab
 	 cli-cmd-volume.c cli-cmd-peer.c cli-rpc-ops.c cli-cmd-parser.c\
14f8ab
diff --git a/doc/Makefile.am b/doc/Makefile.am
14f8ab
index 7c04d74..9904767 100644
14f8ab
--- a/doc/Makefile.am
14f8ab
+++ b/doc/Makefile.am
14f8ab
@@ -1,9 +1,9 @@
14f8ab
 EXTRA_DIST = glusterfs.8 mount.glusterfs.8 gluster.8 \
14f8ab
 			glusterd.8 glusterfsd.8
14f8ab
 
14f8ab
-man8_MANS = glusterfs.8 mount.glusterfs.8
14f8ab
+man8_MANS = gluster.8 glusterfs.8 mount.glusterfs.8
14f8ab
 if WITH_SERVER
14f8ab
-man8_MANS += gluster.8 glusterd.8 glusterfsd.8
14f8ab
+man8_MANS += glusterd.8 glusterfsd.8
14f8ab
 endif
14f8ab
 
14f8ab
 CLEANFILES =
14f8ab
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
14f8ab
index 29e4a37..c505cd9 100644
14f8ab
--- a/glusterfs.spec.in
14f8ab
+++ b/glusterfs.spec.in
14f8ab
@@ -353,7 +353,6 @@ is in user space and easily manageable.
14f8ab
 
14f8ab
 This package provides the api include files.
14f8ab
 
14f8ab
-%if ( 0%{!?_without_server:1} )
14f8ab
 %package cli
14f8ab
 Summary:          GlusterFS CLI
14f8ab
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
14f8ab
@@ -368,7 +367,6 @@ called Translators from GNU Hurd kernel. Much of the code in GlusterFS
14f8ab
 is in user space and easily manageable.
14f8ab
 
14f8ab
 This package provides the GlusterFS CLI application and its man page
14f8ab
-%endif
14f8ab
 
14f8ab
 %package cloudsync-plugins
14f8ab
 Summary:          Cloudsync Plugins
14f8ab
@@ -891,10 +889,8 @@ touch %{buildroot}%{_sharedstatedir}/glusterd/nfs/run/nfs.pid
14f8ab
 find ./tests ./run-tests.sh -type f | cpio -pd %{buildroot}%{_prefix}/share/glusterfs
14f8ab
 
14f8ab
 ## Install bash completion for cli
14f8ab
-%if ( 0%{!?_without_server:1} )
14f8ab
 install -p -m 0744 -D extras/command-completion/gluster.bash \
14f8ab
     %{buildroot}%{_sysconfdir}/bash_completion.d/gluster
14f8ab
-%endif
14f8ab
 
14f8ab
 %if ( 0%{!?_without_server:1} )
14f8ab
 echo "RHGS 3.5" > %{buildroot}%{_datadir}/glusterfs/release
14f8ab
@@ -1193,12 +1189,10 @@ exit 0
14f8ab
 %dir %{_includedir}/glusterfs/api
14f8ab
      %{_includedir}/glusterfs/api/*
14f8ab
 
14f8ab
-%if ( 0%{!?_without_server:1} )
14f8ab
 %files cli
14f8ab
 %{_sbindir}/gluster
14f8ab
 %{_mandir}/man8/gluster.8*
14f8ab
 %{_sysconfdir}/bash_completion.d/gluster
14f8ab
-%endif
14f8ab
 
14f8ab
 %files cloudsync-plugins
14f8ab
 %dir %{_libdir}/glusterfs/%{version}%{?prereltag}/cloudsync-plugins
14f8ab
@@ -1938,6 +1932,9 @@ fi
14f8ab
 %endif
14f8ab
 
14f8ab
 %changelog
14f8ab
+* Fri Jun 14 2019 Atin Mukherjee <amukherj@redhat.com>
14f8ab
+- Ensure gluster-cli package is part of client build (#1720079)
14f8ab
+
14f8ab
 * Mon May 27 2019 Jiffin Tony Thottan <jthottan@redhat.com>
14f8ab
 - Change the dependency to 2.7.3 on nfs-ganesha for glusterfs-ganesha (#1714078)
14f8ab
 
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab