e3c68b
From d2319a4746ba07ada5b3a20462ec2900e1c03c5a Mon Sep 17 00:00:00 2001
e3c68b
From: Atin Mukherjee <amukherj@redhat.com>
e3c68b
Date: Thu, 13 Jun 2019 19:56:32 +0530
e3c68b
Subject: [PATCH 192/192] build: Ensure gluster-cli package is built as part of
e3c68b
 client build
e3c68b
e3c68b
Till RHGS 3.4.x RHGS client was shipping gluster-cli rpm. With RHGS 3.5
e3c68b
which is a rebase of glusterfs 6.0 gluster-cli is only built for server.
e3c68b
gluster cli offers a remote cli execution capability with --remote-host
e3c68b
option for which you need not to have cli and glusterd co located and
e3c68b
hence shipping cli as part of the client package is mandatory. With out
e3c68b
this change the client upgrade for RHEL minor versions are also broken.
e3c68b
e3c68b
>Fixes: bz#1720615
e3c68b
>Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
e3c68b
>Signed-off-by: Niels de Vos <ndevos@redhat.com>
e3c68b
e3c68b
upstream patch: https://review.gluster.org/#/c/glusterfs/+/22868/
e3c68b
e3c68b
BUG: 1720079
e3c68b
Change-Id: I11ec3e2b4d98b3e701147c60ca797d54570d598e
e3c68b
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
e3c68b
Reviewed-on: https://code.engineering.redhat.com/gerrit/173388
e3c68b
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e3c68b
---
e3c68b
 cli/src/Makefile.am | 2 --
e3c68b
 doc/Makefile.am     | 4 ++--
e3c68b
 glusterfs.spec.in   | 9 +++------
e3c68b
 3 files changed, 5 insertions(+), 10 deletions(-)
e3c68b
e3c68b
diff --git a/cli/src/Makefile.am b/cli/src/Makefile.am
e3c68b
index 6be070f..3e7511f 100644
e3c68b
--- a/cli/src/Makefile.am
e3c68b
+++ b/cli/src/Makefile.am
e3c68b
@@ -1,6 +1,4 @@
e3c68b
-if WITH_SERVER
e3c68b
 sbin_PROGRAMS = gluster
e3c68b
-endif
e3c68b
 
e3c68b
 gluster_SOURCES = cli.c registry.c input.c cli-cmd.c cli-rl.c cli-cmd-global.c \
e3c68b
 	 cli-cmd-volume.c cli-cmd-peer.c cli-rpc-ops.c cli-cmd-parser.c\
e3c68b
diff --git a/doc/Makefile.am b/doc/Makefile.am
e3c68b
index 7c04d74..9904767 100644
e3c68b
--- a/doc/Makefile.am
e3c68b
+++ b/doc/Makefile.am
e3c68b
@@ -1,9 +1,9 @@
e3c68b
 EXTRA_DIST = glusterfs.8 mount.glusterfs.8 gluster.8 \
e3c68b
 			glusterd.8 glusterfsd.8
e3c68b
 
e3c68b
-man8_MANS = glusterfs.8 mount.glusterfs.8
e3c68b
+man8_MANS = gluster.8 glusterfs.8 mount.glusterfs.8
e3c68b
 if WITH_SERVER
e3c68b
-man8_MANS += gluster.8 glusterd.8 glusterfsd.8
e3c68b
+man8_MANS += glusterd.8 glusterfsd.8
e3c68b
 endif
e3c68b
 
e3c68b
 CLEANFILES =
e3c68b
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
e3c68b
index 29e4a37..c505cd9 100644
e3c68b
--- a/glusterfs.spec.in
e3c68b
+++ b/glusterfs.spec.in
e3c68b
@@ -353,7 +353,6 @@ is in user space and easily manageable.
e3c68b
 
e3c68b
 This package provides the api include files.
e3c68b
 
e3c68b
-%if ( 0%{!?_without_server:1} )
e3c68b
 %package cli
e3c68b
 Summary:          GlusterFS CLI
e3c68b
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
e3c68b
@@ -368,7 +367,6 @@ called Translators from GNU Hurd kernel. Much of the code in GlusterFS
e3c68b
 is in user space and easily manageable.
e3c68b
 
e3c68b
 This package provides the GlusterFS CLI application and its man page
e3c68b
-%endif
e3c68b
 
e3c68b
 %package cloudsync-plugins
e3c68b
 Summary:          Cloudsync Plugins
e3c68b
@@ -891,10 +889,8 @@ touch %{buildroot}%{_sharedstatedir}/glusterd/nfs/run/nfs.pid
e3c68b
 find ./tests ./run-tests.sh -type f | cpio -pd %{buildroot}%{_prefix}/share/glusterfs
e3c68b
 
e3c68b
 ## Install bash completion for cli
e3c68b
-%if ( 0%{!?_without_server:1} )
e3c68b
 install -p -m 0744 -D extras/command-completion/gluster.bash \
e3c68b
     %{buildroot}%{_sysconfdir}/bash_completion.d/gluster
e3c68b
-%endif
e3c68b
 
e3c68b
 %if ( 0%{!?_without_server:1} )
e3c68b
 echo "RHGS 3.5" > %{buildroot}%{_datadir}/glusterfs/release
e3c68b
@@ -1193,12 +1189,10 @@ exit 0
e3c68b
 %dir %{_includedir}/glusterfs/api
e3c68b
      %{_includedir}/glusterfs/api/*
e3c68b
 
e3c68b
-%if ( 0%{!?_without_server:1} )
e3c68b
 %files cli
e3c68b
 %{_sbindir}/gluster
e3c68b
 %{_mandir}/man8/gluster.8*
e3c68b
 %{_sysconfdir}/bash_completion.d/gluster
e3c68b
-%endif
e3c68b
 
e3c68b
 %files cloudsync-plugins
e3c68b
 %dir %{_libdir}/glusterfs/%{version}%{?prereltag}/cloudsync-plugins
e3c68b
@@ -1938,6 +1932,9 @@ fi
e3c68b
 %endif
e3c68b
 
e3c68b
 %changelog
e3c68b
+* Fri Jun 14 2019 Atin Mukherjee <amukherj@redhat.com>
e3c68b
+- Ensure gluster-cli package is part of client build (#1720079)
e3c68b
+
e3c68b
 * Mon May 27 2019 Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
 - Change the dependency to 2.7.3 on nfs-ganesha for glusterfs-ganesha (#1714078)
e3c68b
 
e3c68b
-- 
e3c68b
1.8.3.1
e3c68b