50dc83
From d2319a4746ba07ada5b3a20462ec2900e1c03c5a Mon Sep 17 00:00:00 2001
50dc83
From: Atin Mukherjee <amukherj@redhat.com>
50dc83
Date: Thu, 13 Jun 2019 19:56:32 +0530
50dc83
Subject: [PATCH 192/192] build: Ensure gluster-cli package is built as part of
50dc83
 client build
50dc83
50dc83
Till RHGS 3.4.x RHGS client was shipping gluster-cli rpm. With RHGS 3.5
50dc83
which is a rebase of glusterfs 6.0 gluster-cli is only built for server.
50dc83
gluster cli offers a remote cli execution capability with --remote-host
50dc83
option for which you need not to have cli and glusterd co located and
50dc83
hence shipping cli as part of the client package is mandatory. With out
50dc83
this change the client upgrade for RHEL minor versions are also broken.
50dc83
50dc83
>Fixes: bz#1720615
50dc83
>Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
50dc83
>Signed-off-by: Niels de Vos <ndevos@redhat.com>
50dc83
50dc83
upstream patch: https://review.gluster.org/#/c/glusterfs/+/22868/
50dc83
50dc83
BUG: 1720079
50dc83
Change-Id: I11ec3e2b4d98b3e701147c60ca797d54570d598e
50dc83
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
50dc83
Reviewed-on: https://code.engineering.redhat.com/gerrit/173388
50dc83
Tested-by: RHGS Build Bot <nigelb@redhat.com>
50dc83
---
50dc83
 cli/src/Makefile.am | 2 --
50dc83
 doc/Makefile.am     | 4 ++--
50dc83
 glusterfs.spec.in   | 9 +++------
50dc83
 3 files changed, 5 insertions(+), 10 deletions(-)
50dc83
50dc83
diff --git a/cli/src/Makefile.am b/cli/src/Makefile.am
50dc83
index 6be070f..3e7511f 100644
50dc83
--- a/cli/src/Makefile.am
50dc83
+++ b/cli/src/Makefile.am
50dc83
@@ -1,6 +1,4 @@
50dc83
-if WITH_SERVER
50dc83
 sbin_PROGRAMS = gluster
50dc83
-endif
50dc83
 
50dc83
 gluster_SOURCES = cli.c registry.c input.c cli-cmd.c cli-rl.c cli-cmd-global.c \
50dc83
 	 cli-cmd-volume.c cli-cmd-peer.c cli-rpc-ops.c cli-cmd-parser.c\
50dc83
diff --git a/doc/Makefile.am b/doc/Makefile.am
50dc83
index 7c04d74..9904767 100644
50dc83
--- a/doc/Makefile.am
50dc83
+++ b/doc/Makefile.am
50dc83
@@ -1,9 +1,9 @@
50dc83
 EXTRA_DIST = glusterfs.8 mount.glusterfs.8 gluster.8 \
50dc83
 			glusterd.8 glusterfsd.8
50dc83
 
50dc83
-man8_MANS = glusterfs.8 mount.glusterfs.8
50dc83
+man8_MANS = gluster.8 glusterfs.8 mount.glusterfs.8
50dc83
 if WITH_SERVER
50dc83
-man8_MANS += gluster.8 glusterd.8 glusterfsd.8
50dc83
+man8_MANS += glusterd.8 glusterfsd.8
50dc83
 endif
50dc83
 
50dc83
 CLEANFILES =
50dc83
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
50dc83
index 29e4a37..c505cd9 100644
50dc83
--- a/glusterfs.spec.in
50dc83
+++ b/glusterfs.spec.in
50dc83
@@ -353,7 +353,6 @@ is in user space and easily manageable.
50dc83
 
50dc83
 This package provides the api include files.
50dc83
 
50dc83
-%if ( 0%{!?_without_server:1} )
50dc83
 %package cli
50dc83
 Summary:          GlusterFS CLI
50dc83
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
50dc83
@@ -368,7 +367,6 @@ called Translators from GNU Hurd kernel. Much of the code in GlusterFS
50dc83
 is in user space and easily manageable.
50dc83
 
50dc83
 This package provides the GlusterFS CLI application and its man page
50dc83
-%endif
50dc83
 
50dc83
 %package cloudsync-plugins
50dc83
 Summary:          Cloudsync Plugins
50dc83
@@ -891,10 +889,8 @@ touch %{buildroot}%{_sharedstatedir}/glusterd/nfs/run/nfs.pid
50dc83
 find ./tests ./run-tests.sh -type f | cpio -pd %{buildroot}%{_prefix}/share/glusterfs
50dc83
 
50dc83
 ## Install bash completion for cli
50dc83
-%if ( 0%{!?_without_server:1} )
50dc83
 install -p -m 0744 -D extras/command-completion/gluster.bash \
50dc83
     %{buildroot}%{_sysconfdir}/bash_completion.d/gluster
50dc83
-%endif
50dc83
 
50dc83
 %if ( 0%{!?_without_server:1} )
50dc83
 echo "RHGS 3.5" > %{buildroot}%{_datadir}/glusterfs/release
50dc83
@@ -1193,12 +1189,10 @@ exit 0
50dc83
 %dir %{_includedir}/glusterfs/api
50dc83
      %{_includedir}/glusterfs/api/*
50dc83
 
50dc83
-%if ( 0%{!?_without_server:1} )
50dc83
 %files cli
50dc83
 %{_sbindir}/gluster
50dc83
 %{_mandir}/man8/gluster.8*
50dc83
 %{_sysconfdir}/bash_completion.d/gluster
50dc83
-%endif
50dc83
 
50dc83
 %files cloudsync-plugins
50dc83
 %dir %{_libdir}/glusterfs/%{version}%{?prereltag}/cloudsync-plugins
50dc83
@@ -1938,6 +1932,9 @@ fi
50dc83
 %endif
50dc83
 
50dc83
 %changelog
50dc83
+* Fri Jun 14 2019 Atin Mukherjee <amukherj@redhat.com>
50dc83
+- Ensure gluster-cli package is part of client build (#1720079)
50dc83
+
50dc83
 * Mon May 27 2019 Jiffin Tony Thottan <jthottan@redhat.com>
50dc83
 - Change the dependency to 2.7.3 on nfs-ganesha for glusterfs-ganesha (#1714078)
50dc83
 
50dc83
-- 
50dc83
1.8.3.1
50dc83