74b1de
From d2319a4746ba07ada5b3a20462ec2900e1c03c5a Mon Sep 17 00:00:00 2001
74b1de
From: Atin Mukherjee <amukherj@redhat.com>
74b1de
Date: Thu, 13 Jun 2019 19:56:32 +0530
74b1de
Subject: [PATCH 192/192] build: Ensure gluster-cli package is built as part of
74b1de
 client build
74b1de
74b1de
Till RHGS 3.4.x RHGS client was shipping gluster-cli rpm. With RHGS 3.5
74b1de
which is a rebase of glusterfs 6.0 gluster-cli is only built for server.
74b1de
gluster cli offers a remote cli execution capability with --remote-host
74b1de
option for which you need not to have cli and glusterd co located and
74b1de
hence shipping cli as part of the client package is mandatory. With out
74b1de
this change the client upgrade for RHEL minor versions are also broken.
74b1de
74b1de
>Fixes: bz#1720615
74b1de
>Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
74b1de
>Signed-off-by: Niels de Vos <ndevos@redhat.com>
74b1de
74b1de
upstream patch: https://review.gluster.org/#/c/glusterfs/+/22868/
74b1de
74b1de
BUG: 1720079
74b1de
Change-Id: I11ec3e2b4d98b3e701147c60ca797d54570d598e
74b1de
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/173388
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
---
74b1de
 cli/src/Makefile.am | 2 --
74b1de
 doc/Makefile.am     | 4 ++--
74b1de
 glusterfs.spec.in   | 9 +++------
74b1de
 3 files changed, 5 insertions(+), 10 deletions(-)
74b1de
74b1de
diff --git a/cli/src/Makefile.am b/cli/src/Makefile.am
74b1de
index 6be070f..3e7511f 100644
74b1de
--- a/cli/src/Makefile.am
74b1de
+++ b/cli/src/Makefile.am
74b1de
@@ -1,6 +1,4 @@
74b1de
-if WITH_SERVER
74b1de
 sbin_PROGRAMS = gluster
74b1de
-endif
74b1de
 
74b1de
 gluster_SOURCES = cli.c registry.c input.c cli-cmd.c cli-rl.c cli-cmd-global.c \
74b1de
 	 cli-cmd-volume.c cli-cmd-peer.c cli-rpc-ops.c cli-cmd-parser.c\
74b1de
diff --git a/doc/Makefile.am b/doc/Makefile.am
74b1de
index 7c04d74..9904767 100644
74b1de
--- a/doc/Makefile.am
74b1de
+++ b/doc/Makefile.am
74b1de
@@ -1,9 +1,9 @@
74b1de
 EXTRA_DIST = glusterfs.8 mount.glusterfs.8 gluster.8 \
74b1de
 			glusterd.8 glusterfsd.8
74b1de
 
74b1de
-man8_MANS = glusterfs.8 mount.glusterfs.8
74b1de
+man8_MANS = gluster.8 glusterfs.8 mount.glusterfs.8
74b1de
 if WITH_SERVER
74b1de
-man8_MANS += gluster.8 glusterd.8 glusterfsd.8
74b1de
+man8_MANS += glusterd.8 glusterfsd.8
74b1de
 endif
74b1de
 
74b1de
 CLEANFILES =
74b1de
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
74b1de
index 29e4a37..c505cd9 100644
74b1de
--- a/glusterfs.spec.in
74b1de
+++ b/glusterfs.spec.in
74b1de
@@ -353,7 +353,6 @@ is in user space and easily manageable.
74b1de
 
74b1de
 This package provides the api include files.
74b1de
 
74b1de
-%if ( 0%{!?_without_server:1} )
74b1de
 %package cli
74b1de
 Summary:          GlusterFS CLI
74b1de
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
74b1de
@@ -368,7 +367,6 @@ called Translators from GNU Hurd kernel. Much of the code in GlusterFS
74b1de
 is in user space and easily manageable.
74b1de
 
74b1de
 This package provides the GlusterFS CLI application and its man page
74b1de
-%endif
74b1de
 
74b1de
 %package cloudsync-plugins
74b1de
 Summary:          Cloudsync Plugins
74b1de
@@ -891,10 +889,8 @@ touch %{buildroot}%{_sharedstatedir}/glusterd/nfs/run/nfs.pid
74b1de
 find ./tests ./run-tests.sh -type f | cpio -pd %{buildroot}%{_prefix}/share/glusterfs
74b1de
 
74b1de
 ## Install bash completion for cli
74b1de
-%if ( 0%{!?_without_server:1} )
74b1de
 install -p -m 0744 -D extras/command-completion/gluster.bash \
74b1de
     %{buildroot}%{_sysconfdir}/bash_completion.d/gluster
74b1de
-%endif
74b1de
 
74b1de
 %if ( 0%{!?_without_server:1} )
74b1de
 echo "RHGS 3.5" > %{buildroot}%{_datadir}/glusterfs/release
74b1de
@@ -1193,12 +1189,10 @@ exit 0
74b1de
 %dir %{_includedir}/glusterfs/api
74b1de
      %{_includedir}/glusterfs/api/*
74b1de
 
74b1de
-%if ( 0%{!?_without_server:1} )
74b1de
 %files cli
74b1de
 %{_sbindir}/gluster
74b1de
 %{_mandir}/man8/gluster.8*
74b1de
 %{_sysconfdir}/bash_completion.d/gluster
74b1de
-%endif
74b1de
 
74b1de
 %files cloudsync-plugins
74b1de
 %dir %{_libdir}/glusterfs/%{version}%{?prereltag}/cloudsync-plugins
74b1de
@@ -1938,6 +1932,9 @@ fi
74b1de
 %endif
74b1de
 
74b1de
 %changelog
74b1de
+* Fri Jun 14 2019 Atin Mukherjee <amukherj@redhat.com>
74b1de
+- Ensure gluster-cli package is part of client build (#1720079)
74b1de
+
74b1de
 * Mon May 27 2019 Jiffin Tony Thottan <jthottan@redhat.com>
74b1de
 - Change the dependency to 2.7.3 on nfs-ganesha for glusterfs-ganesha (#1714078)
74b1de
 
74b1de
-- 
74b1de
1.8.3.1
74b1de