233933
From d2319a4746ba07ada5b3a20462ec2900e1c03c5a Mon Sep 17 00:00:00 2001
233933
From: Atin Mukherjee <amukherj@redhat.com>
233933
Date: Thu, 13 Jun 2019 19:56:32 +0530
233933
Subject: [PATCH 192/192] build: Ensure gluster-cli package is built as part of
233933
 client build
233933
233933
Till RHGS 3.4.x RHGS client was shipping gluster-cli rpm. With RHGS 3.5
233933
which is a rebase of glusterfs 6.0 gluster-cli is only built for server.
233933
gluster cli offers a remote cli execution capability with --remote-host
233933
option for which you need not to have cli and glusterd co located and
233933
hence shipping cli as part of the client package is mandatory. With out
233933
this change the client upgrade for RHEL minor versions are also broken.
233933
233933
>Fixes: bz#1720615
233933
>Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
233933
>Signed-off-by: Niels de Vos <ndevos@redhat.com>
233933
233933
upstream patch: https://review.gluster.org/#/c/glusterfs/+/22868/
233933
233933
BUG: 1720079
233933
Change-Id: I11ec3e2b4d98b3e701147c60ca797d54570d598e
233933
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
233933
Reviewed-on: https://code.engineering.redhat.com/gerrit/173388
233933
Tested-by: RHGS Build Bot <nigelb@redhat.com>
233933
---
233933
 cli/src/Makefile.am | 2 --
233933
 doc/Makefile.am     | 4 ++--
233933
 glusterfs.spec.in   | 9 +++------
233933
 3 files changed, 5 insertions(+), 10 deletions(-)
233933
233933
diff --git a/cli/src/Makefile.am b/cli/src/Makefile.am
233933
index 6be070f..3e7511f 100644
233933
--- a/cli/src/Makefile.am
233933
+++ b/cli/src/Makefile.am
233933
@@ -1,6 +1,4 @@
233933
-if WITH_SERVER
233933
 sbin_PROGRAMS = gluster
233933
-endif
233933
 
233933
 gluster_SOURCES = cli.c registry.c input.c cli-cmd.c cli-rl.c cli-cmd-global.c \
233933
 	 cli-cmd-volume.c cli-cmd-peer.c cli-rpc-ops.c cli-cmd-parser.c\
233933
diff --git a/doc/Makefile.am b/doc/Makefile.am
233933
index 7c04d74..9904767 100644
233933
--- a/doc/Makefile.am
233933
+++ b/doc/Makefile.am
233933
@@ -1,9 +1,9 @@
233933
 EXTRA_DIST = glusterfs.8 mount.glusterfs.8 gluster.8 \
233933
 			glusterd.8 glusterfsd.8
233933
 
233933
-man8_MANS = glusterfs.8 mount.glusterfs.8
233933
+man8_MANS = gluster.8 glusterfs.8 mount.glusterfs.8
233933
 if WITH_SERVER
233933
-man8_MANS += gluster.8 glusterd.8 glusterfsd.8
233933
+man8_MANS += glusterd.8 glusterfsd.8
233933
 endif
233933
 
233933
 CLEANFILES =
233933
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
233933
index 29e4a37..c505cd9 100644
233933
--- a/glusterfs.spec.in
233933
+++ b/glusterfs.spec.in
233933
@@ -353,7 +353,6 @@ is in user space and easily manageable.
233933
 
233933
 This package provides the api include files.
233933
 
233933
-%if ( 0%{!?_without_server:1} )
233933
 %package cli
233933
 Summary:          GlusterFS CLI
233933
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
233933
@@ -368,7 +367,6 @@ called Translators from GNU Hurd kernel. Much of the code in GlusterFS
233933
 is in user space and easily manageable.
233933
 
233933
 This package provides the GlusterFS CLI application and its man page
233933
-%endif
233933
 
233933
 %package cloudsync-plugins
233933
 Summary:          Cloudsync Plugins
233933
@@ -891,10 +889,8 @@ touch %{buildroot}%{_sharedstatedir}/glusterd/nfs/run/nfs.pid
233933
 find ./tests ./run-tests.sh -type f | cpio -pd %{buildroot}%{_prefix}/share/glusterfs
233933
 
233933
 ## Install bash completion for cli
233933
-%if ( 0%{!?_without_server:1} )
233933
 install -p -m 0744 -D extras/command-completion/gluster.bash \
233933
     %{buildroot}%{_sysconfdir}/bash_completion.d/gluster
233933
-%endif
233933
 
233933
 %if ( 0%{!?_without_server:1} )
233933
 echo "RHGS 3.5" > %{buildroot}%{_datadir}/glusterfs/release
233933
@@ -1193,12 +1189,10 @@ exit 0
233933
 %dir %{_includedir}/glusterfs/api
233933
      %{_includedir}/glusterfs/api/*
233933
 
233933
-%if ( 0%{!?_without_server:1} )
233933
 %files cli
233933
 %{_sbindir}/gluster
233933
 %{_mandir}/man8/gluster.8*
233933
 %{_sysconfdir}/bash_completion.d/gluster
233933
-%endif
233933
 
233933
 %files cloudsync-plugins
233933
 %dir %{_libdir}/glusterfs/%{version}%{?prereltag}/cloudsync-plugins
233933
@@ -1938,6 +1932,9 @@ fi
233933
 %endif
233933
 
233933
 %changelog
233933
+* Fri Jun 14 2019 Atin Mukherjee <amukherj@redhat.com>
233933
+- Ensure gluster-cli package is part of client build (#1720079)
233933
+
233933
 * Mon May 27 2019 Jiffin Tony Thottan <jthottan@redhat.com>
233933
 - Change the dependency to 2.7.3 on nfs-ganesha for glusterfs-ganesha (#1714078)
233933
 
233933
-- 
233933
1.8.3.1
233933