256ebe
From a65982755b31fb548ff7a997ee754360a516da94 Mon Sep 17 00:00:00 2001
256ebe
From: Amar Tumballi <amarts@redhat.com>
256ebe
Date: Fri, 14 Jun 2019 13:58:25 +0530
256ebe
Subject: [PATCH 187/192] gfapi: statedump_path() add proper version number
256ebe
256ebe
An API should have the proper version number, and 'future' version
256ebe
number is just a place holder. One shouldn't be using it in the
256ebe
release versions.
256ebe
256ebe
With the previous backport of the patch, the version remained same
256ebe
as that of 'master' branch, which is future, but as it is an API,
256ebe
it needed a fixed version number. With this patch, corrected the same.
256ebe
256ebe
Label: DOWNSTREAM_ONLY
256ebe
256ebe
> In upstream, this is corrected by a backport to the stable version, 6.4
256ebe
> URL: https://review.gluster.org/22864
256ebe
256ebe
BUG: 1720461
256ebe
Change-Id: I939850689d47d4f240c9d43f6be1a11de29c4760
256ebe
Signed-off-by: Amar Tumballi <amarts@redhat.com>
256ebe
Reviewed-on: https://code.engineering.redhat.com/gerrit/173475
256ebe
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
256ebe
Tested-by: RHGS Build Bot <nigelb@redhat.com>
256ebe
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
256ebe
---
256ebe
 api/examples/glfsxmp.c | 5 +++++
256ebe
 api/src/gfapi.aliases  | 2 +-
256ebe
 api/src/gfapi.map      | 2 +-
256ebe
 api/src/glfs.c         | 2 +-
256ebe
 api/src/glfs.h         | 2 +-
256ebe
 5 files changed, 9 insertions(+), 4 deletions(-)
256ebe
256ebe
diff --git a/api/examples/glfsxmp.c b/api/examples/glfsxmp.c
256ebe
index 9d96eea..33f44df 100644
256ebe
--- a/api/examples/glfsxmp.c
256ebe
+++ b/api/examples/glfsxmp.c
256ebe
@@ -1573,6 +1573,11 @@ main(int argc, char *argv[])
256ebe
 
256ebe
     ret = glfs_set_logging(fs2, "/dev/stderr", 7);
256ebe
 
256ebe
+    ret = glfs_set_statedump_path(fs2, "/tmp");
256ebe
+    if (ret) {
256ebe
+        fprintf(stderr, "glfs_set_statedump_path: %s\n", strerror(errno));
256ebe
+    }
256ebe
+
256ebe
     ret = glfs_init(fs2);
256ebe
 
256ebe
     fprintf(stderr, "glfs_init: returned %d\n", ret);
256ebe
diff --git a/api/src/gfapi.aliases b/api/src/gfapi.aliases
256ebe
index 8fdf734..692ae13 100644
256ebe
--- a/api/src/gfapi.aliases
256ebe
+++ b/api/src/gfapi.aliases
256ebe
@@ -196,4 +196,4 @@ _pub_glfs_copy_file_range _glfs_copy_file_range$GFAPI_6.0
256ebe
 _pub_glfs_fsetattr _glfs_fsetattr$GFAPI_6.0
256ebe
 _pub_glfs_setattr _glfs_setattr$GFAPI_6.0
256ebe
 
256ebe
-_pub_glfs_set_statedump_path _glfs_set_statedump_path@GFAPI_future
256ebe
+_pub_glfs_set_statedump_path _glfs_set_statedump_path@GFAPI_6.4
256ebe
diff --git a/api/src/gfapi.map b/api/src/gfapi.map
256ebe
index cf118e8..df65837 100644
256ebe
--- a/api/src/gfapi.map
256ebe
+++ b/api/src/gfapi.map
256ebe
@@ -272,7 +272,7 @@ GFAPI_PRIVATE_6.1 {
256ebe
 		glfs_setfspid;
256ebe
 } GFAPI_6.0;
256ebe
 
256ebe
-GFAPI_future {
256ebe
+GFAPI_6.4 {
256ebe
 	global:
256ebe
 		glfs_set_statedump_path;
256ebe
 } GFAPI_PRIVATE_6.1;
256ebe
diff --git a/api/src/glfs.c b/api/src/glfs.c
256ebe
index ba513e6..6bbb620 100644
256ebe
--- a/api/src/glfs.c
256ebe
+++ b/api/src/glfs.c
256ebe
@@ -1800,4 +1800,4 @@ invalid_fs:
256ebe
     return -1;
256ebe
 }
256ebe
 
256ebe
-GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_set_statedump_path, future);
256ebe
+GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_set_statedump_path, 6.4);
256ebe
diff --git a/api/src/glfs.h b/api/src/glfs.h
256ebe
index a6c12e1..08b6ca0 100644
256ebe
--- a/api/src/glfs.h
256ebe
+++ b/api/src/glfs.h
256ebe
@@ -1479,7 +1479,7 @@ glfs_setattr(struct glfs *fs, const char *path, struct glfs_stat *stat,
256ebe
 
256ebe
 int
256ebe
 glfs_set_statedump_path(struct glfs *fs, const char *path) __THROW
256ebe
-    GFAPI_PUBLIC(glfs_set_statedump_path, future);
256ebe
+    GFAPI_PUBLIC(glfs_set_statedump_path, 6.4);
256ebe
 
256ebe
 __END_DECLS
256ebe
 #endif /* !_GLFS_H */
256ebe
-- 
256ebe
1.8.3.1
256ebe