|
 |
233933 |
From be925e84edcecd879e953bdb68c10f98825dba53 Mon Sep 17 00:00:00 2001
|
|
|
233933 |
From: Shwetha K Acharya <sacharya@redhat.com>
|
|
|
233933 |
Date: Mon, 3 Jun 2019 18:05:24 +0530
|
|
|
233933 |
Subject: [PATCH 186/192] cli: Remove-brick warning seems unnecessary
|
|
|
233933 |
|
|
|
233933 |
As force-migration option is disabled by default,
|
|
|
233933 |
the warning seems unnessary.
|
|
|
233933 |
|
|
|
233933 |
Rephrased the warning to make best sense out of it.
|
|
|
233933 |
|
|
|
233933 |
>fixes: bz#1712668
|
|
|
233933 |
>Change-Id: Ia18c3c5e7b3fec808fce2194ca0504a837708822
|
|
|
233933 |
>Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
|
|
|
233933 |
|
|
|
233933 |
backport of https://review.gluster.org/#/c/glusterfs/+/22805/
|
|
|
233933 |
|
|
|
233933 |
Bug: 1708183
|
|
|
233933 |
Change-Id: Ia18c3c5e7b3fec808fce2194ca0504a837708822
|
|
|
233933 |
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
|
|
|
233933 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/173447
|
|
|
233933 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
233933 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
233933 |
---
|
|
|
233933 |
cli/src/cli-cmd-volume.c | 17 +++++++++--------
|
|
|
233933 |
1 file changed, 9 insertions(+), 8 deletions(-)
|
|
|
233933 |
|
|
|
233933 |
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c
|
|
|
233933 |
index 564aef7..a42e663 100644
|
|
|
233933 |
--- a/cli/src/cli-cmd-volume.c
|
|
|
233933 |
+++ b/cli/src/cli-cmd-volume.c
|
|
|
233933 |
@@ -2090,14 +2090,15 @@ cli_cmd_volume_remove_brick_cbk(struct cli_state *state,
|
|
|
233933 |
" on the volume.\nDo you want to continue?";
|
|
|
233933 |
} else if (command == GF_OP_CMD_START) {
|
|
|
233933 |
question =
|
|
|
233933 |
- "Running remove-brick with cluster.force-migration"
|
|
|
233933 |
- " enabled can result in data corruption. It is safer"
|
|
|
233933 |
- " to disable this option so that files that receive "
|
|
|
233933 |
- "writes during migration are not migrated.\nFiles "
|
|
|
233933 |
- "that are not migrated can then be manually copied "
|
|
|
233933 |
- "after the remove-brick commit operation.\nDo you "
|
|
|
233933 |
- "want to continue with your current "
|
|
|
233933 |
- "cluster.force-migration settings?";
|
|
|
233933 |
+ "It is recommended that remove-brick be run with"
|
|
|
233933 |
+ " cluster.force-migration option disabled to prevent"
|
|
|
233933 |
+ " possible data corruption. Doing so will ensure that"
|
|
|
233933 |
+ " files that receive writes during migration will not"
|
|
|
233933 |
+ " be migrated and will need to be manually copied"
|
|
|
233933 |
+ " after the remove-brick commit operation. Please"
|
|
|
233933 |
+ " check the value of the option and update accordingly."
|
|
|
233933 |
+ " \nDo you want to continue with your current"
|
|
|
233933 |
+ " cluster.force-migration settings?";
|
|
|
233933 |
}
|
|
|
233933 |
|
|
|
233933 |
if (!brick_count) {
|
|
|
233933 |
--
|
|
|
233933 |
1.8.3.1
|
|
|
233933 |
|