50dc83
From fe1d641e4666f9a20f656b1799cf6e7b75af1279 Mon Sep 17 00:00:00 2001
50dc83
From: karthik-us <ksubrahm@redhat.com>
50dc83
Date: Tue, 11 Jun 2019 11:31:02 +0530
50dc83
Subject: [PATCH 179/192] tests: Fix split-brain-favorite-child-policy.t
50dc83
 failure
50dc83
50dc83
Backport of: https://review.gluster.org/#/c/glusterfs/+/22850/
50dc83
50dc83
Problem:
50dc83
The test case is failing to heal the volume within $HEAL_TIMEOUT @195.
50dc83
This is happening because as part of split-brain resolution the file
50dc83
gets expunged from the sink and the new entry mark for that file will
50dc83
be done on the source bricks as part of impunging. Since the source
50dc83
bricks shd-threads failed to get the heal-domain lock, they will wait
50dc83
for the heal-timeout of 10 minutes, which is greater than $HEAL_TIMEOUT.
50dc83
50dc83
Fix:
50dc83
Set the cluster.heal-timeout to 5 seconds to trigger the heal so that
50dc83
one of the source brick heals the file within the $HEAL_TIMEOUT.
50dc83
50dc83
Change-Id: Iae5e819aa564ccde6639c51711f49d1152260c2d
50dc83
updates: bz#1704562
50dc83
Signed-off-by: karthik-us <ksubrahm@redhat.com>
50dc83
Reviewed-on: https://code.engineering.redhat.com/gerrit/172965
50dc83
Tested-by: RHGS Build Bot <nigelb@redhat.com>
50dc83
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
50dc83
---
50dc83
 tests/basic/afr/split-brain-favorite-child-policy.t | 7 ++++---
50dc83
 1 file changed, 4 insertions(+), 3 deletions(-)
50dc83
50dc83
diff --git a/tests/basic/afr/split-brain-favorite-child-policy.t b/tests/basic/afr/split-brain-favorite-child-policy.t
50dc83
index 0e321c6..c268c12 100644
50dc83
--- a/tests/basic/afr/split-brain-favorite-child-policy.t
50dc83
+++ b/tests/basic/afr/split-brain-favorite-child-policy.t
50dc83
@@ -16,6 +16,7 @@ TEST $CLI volume set $V0 cluster.self-heal-daemon off
50dc83
 TEST $CLI volume set $V0 cluster.entry-self-heal off
50dc83
 TEST $CLI volume set $V0 cluster.data-self-heal off
50dc83
 TEST $CLI volume set $V0 cluster.metadata-self-heal off
50dc83
+TEST $CLI volume set $V0 cluster.heal-timeout 5
50dc83
 TEST $CLI volume start $V0
50dc83
 TEST $GFS --volfile-id=/$V0 --volfile-server=$H0 $M0
50dc83
 TEST touch $M0/file
50dc83
@@ -38,7 +39,7 @@ EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 0
50dc83
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 1
50dc83
 TEST $CLI volume heal $V0
50dc83
 
50dc83
-#file fill in split-brain
50dc83
+#file still in split-brain
50dc83
 cat $M0/file > /dev/null
50dc83
 EXPECT "1" echo $?
50dc83
 
50dc83
@@ -124,7 +125,7 @@ EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 0
50dc83
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 1
50dc83
 TEST $CLI volume heal $V0
50dc83
 
50dc83
-#file fill in split-brain
50dc83
+#file still in split-brain
50dc83
 cat $M0/file > /dev/null
50dc83
 EXPECT "1" echo $?
50dc83
 
50dc83
@@ -179,7 +180,7 @@ EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 1
50dc83
 EXPECT_WITHIN $CHILD_UP_TIMEOUT "1" afr_child_up_status_in_shd $V0 2
50dc83
 TEST $CLI volume heal $V0
50dc83
 
50dc83
-#file fill in split-brain
50dc83
+#file still in split-brain
50dc83
 cat $M0/file > /dev/null
50dc83
 EXPECT "1" echo $?
50dc83
 
50dc83
-- 
50dc83
1.8.3.1
50dc83