256ebe
From 6198461bce7d264b71fe91e981aa3af3a19a8abe Mon Sep 17 00:00:00 2001
256ebe
From: N Balachandran <nbalacha@redhat.com>
256ebe
Date: Tue, 4 Jun 2019 14:51:44 +0530
256ebe
Subject: [PATCH 168/169] cluster/dht: Fix directory perms during selfheal
256ebe
256ebe
Fixed a bug in the revalidate code path that wiped out
256ebe
directory permissions if no mds subvol was found.
256ebe
256ebe
upstream: https://review.gluster.org/#/c/glusterfs/+/22813/
256ebe
256ebe
> Change-Id: I8b4239ffee7001493c59d4032a2d3062586ea115
256ebe
> fixes: bz#1716830
256ebe
> Signed-off-by: N Balachandran <nbalacha@redhat.com>
256ebe
256ebe
BUG: 1716821
256ebe
Change-Id: I6d84d381d07a27d1ef9113a2104a62ceaf2110e3
256ebe
Signed-off-by: N Balachandran <nbalacha@redhat.com>
256ebe
Reviewed-on: https://code.engineering.redhat.com/gerrit/172622
256ebe
Tested-by: RHGS Build Bot <nigelb@redhat.com>
256ebe
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
256ebe
---
256ebe
 xlators/cluster/dht/src/dht-common.c | 8 +++++---
256ebe
 1 file changed, 5 insertions(+), 3 deletions(-)
256ebe
256ebe
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c
256ebe
index 183872f..e1edb38 100644
256ebe
--- a/xlators/cluster/dht/src/dht-common.c
256ebe
+++ b/xlators/cluster/dht/src/dht-common.c
256ebe
@@ -1739,9 +1739,11 @@ unlock:
256ebe
 
256ebe
             if (dht_needs_selfheal(frame, this)) {
256ebe
                 if (!__is_root_gfid(local->loc.inode->gfid)) {
256ebe
-                    local->stbuf.ia_gid = local->mds_stbuf.ia_gid;
256ebe
-                    local->stbuf.ia_uid = local->mds_stbuf.ia_uid;
256ebe
-                    local->stbuf.ia_prot = local->mds_stbuf.ia_prot;
256ebe
+                    if (local->mds_subvol) {
256ebe
+                        local->stbuf.ia_gid = local->mds_stbuf.ia_gid;
256ebe
+                        local->stbuf.ia_uid = local->mds_stbuf.ia_uid;
256ebe
+                        local->stbuf.ia_prot = local->mds_stbuf.ia_prot;
256ebe
+                    }
256ebe
                 } else {
256ebe
                     local->stbuf.ia_gid = local->prebuf.ia_gid;
256ebe
                     local->stbuf.ia_uid = local->prebuf.ia_uid;
256ebe
-- 
256ebe
1.8.3.1
256ebe