|
 |
3604df |
From 59ce7264c0bb66af1726d7fb60114c865a5225d6 Mon Sep 17 00:00:00 2001
|
|
|
3604df |
From: moagrawa <moagrawa@redhat.com>
|
|
|
3604df |
Date: Wed, 16 Nov 2016 12:01:13 +0530
|
|
|
3604df |
Subject: [PATCH 164/206] glusterfsd: Continuous errors are getting in mount
|
|
|
3604df |
logs while glusterd is down
|
|
|
3604df |
|
|
|
3604df |
Problem: when glusterd is down, getting the continuous mgmt_rpc_notify errors
|
|
|
3604df |
messages in the volume mount log for every 3 seconds,it will consume
|
|
|
3604df |
disk space.
|
|
|
3604df |
|
|
|
3604df |
Solution: To reduce the frequency of error messages use GF_LOG_OCCASIONALLY.
|
|
|
3604df |
|
|
|
3604df |
> BUG: 1388877
|
|
|
3604df |
> Change-Id: I6cf24c6ddd9ab380afd058bc0ecd556d664332b1
|
|
|
3604df |
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
|
|
3604df |
> Reviewed-on: http://review.gluster.org/15732
|
|
|
3604df |
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
|
|
|
3604df |
> Smoke: Gluster Build System <jenkins@build.gluster.org>
|
|
|
3604df |
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
|
|
|
3604df |
> Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
|
|
|
3604df |
> Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
|
|
|
3604df |
> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
|
|
|
3604df |
> (cherry picked from commit 7874ed245bcc80658547992205f8396f4dd3c76a)
|
|
|
3604df |
|
|
|
3604df |
BUG: 1380655
|
|
|
3604df |
Change-Id: I5f30c75e679c09897dd4570bf8377bde5680496b
|
|
|
3604df |
Signed-off-by: moagrawa <moagrawa@redhat.com>
|
|
|
3604df |
Reviewed-on: https://code.engineering.redhat.com/gerrit/90289
|
|
|
3604df |
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
|
|
|
3604df |
---
|
|
|
3604df |
glusterfsd/src/glusterfsd-mgmt.c | 9 ++++++---
|
|
|
3604df |
1 file changed, 6 insertions(+), 3 deletions(-)
|
|
|
3604df |
|
|
|
3604df |
diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c
|
|
|
3604df |
index 2a090eb..38fb5b2 100644
|
|
|
3604df |
--- a/glusterfsd/src/glusterfsd-mgmt.c
|
|
|
3604df |
+++ b/glusterfsd/src/glusterfsd-mgmt.c
|
|
|
3604df |
@@ -1909,6 +1909,8 @@ mgmt_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event,
|
|
|
3604df |
rpc_transport_t *rpc_trans = NULL;
|
|
|
3604df |
int need_term = 0;
|
|
|
3604df |
int emval = 0;
|
|
|
3604df |
+ static int log_ctr1;
|
|
|
3604df |
+ static int log_ctr2;
|
|
|
3604df |
struct dnscache6 *dnscache = NULL;
|
|
|
3604df |
|
|
|
3604df |
this = mydata;
|
|
|
3604df |
@@ -1917,7 +1919,7 @@ mgmt_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event,
|
|
|
3604df |
|
|
|
3604df |
switch (event) {
|
|
|
3604df |
case RPC_CLNT_DISCONNECT:
|
|
|
3604df |
- gf_log ("glusterfsd-mgmt", GF_LOG_ERROR,
|
|
|
3604df |
+ GF_LOG_OCCASIONALLY (log_ctr1, "glusterfsd-mgmt", GF_LOG_ERROR,
|
|
|
3604df |
"failed to connect with remote-host: %s (%s)",
|
|
|
3604df |
ctx->cmd_args.volfile_server, strerror (errno));
|
|
|
3604df |
if (!rpc->disabled) {
|
|
|
3604df |
@@ -1935,8 +1937,9 @@ mgmt_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event,
|
|
|
3604df |
if (!ctx->active)
|
|
|
3604df |
need_term = 1;
|
|
|
3604df |
emval = ENOTCONN;
|
|
|
3604df |
- gf_log("glusterfsd-mgmt", GF_LOG_INFO,
|
|
|
3604df |
- "Exhausted all volfile servers");
|
|
|
3604df |
+ GF_LOG_OCCASIONALLY (log_ctr2, "glusterfsd-mgmt",
|
|
|
3604df |
+ GF_LOG_INFO,
|
|
|
3604df |
+ "Exhausted all volfile servers");
|
|
|
3604df |
break;
|
|
|
3604df |
}
|
|
|
3604df |
server = list_entry (server->list.next, typeof(*server), list);
|
|
|
3604df |
--
|
|
|
3604df |
2.9.3
|
|
|
3604df |
|