256ebe
From e44b75fdb86dcf759204816c873b4f9f4efbefa8 Mon Sep 17 00:00:00 2001
256ebe
From: Susant Palai <spalai@redhat.com>
256ebe
Date: Tue, 21 May 2019 16:17:09 +0530
256ebe
Subject: [PATCH 142/169] lock: check null value of dict to avoid log flooding
256ebe
256ebe
> updates: bz#1712322
256ebe
> Change-Id: I120a1d23506f9ebcf88c7ea2f2eff4978a61cf4a
256ebe
> Signed-off-by: Susant Palai <spalai@redhat.com>
256ebe
(backport of fix https://review.gluster.org/#/c/glusterfs/+/22756/)
256ebe
256ebe
BUG: bz#1704181
256ebe
Change-Id: I2a192236328ebb39666ffef1146df312c08a377d
256ebe
Signed-off-by: Susant Palai <spalai@redhat.com>
256ebe
Reviewed-on: https://code.engineering.redhat.com/gerrit/171325
256ebe
Tested-by: RHGS Build Bot <nigelb@redhat.com>
256ebe
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
256ebe
---
256ebe
 xlators/features/locks/src/posix.c | 2 +-
256ebe
 1 file changed, 1 insertion(+), 1 deletion(-)
256ebe
256ebe
diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c
256ebe
index 3f1c7a7..adb0df5 100644
256ebe
--- a/xlators/features/locks/src/posix.c
256ebe
+++ b/xlators/features/locks/src/posix.c
256ebe
@@ -121,7 +121,7 @@ fetch_pathinfo(xlator_t *, inode_t *, int32_t *, char **);
256ebe
 
256ebe
 #define PL_CHECK_LOCK_ENFORCE_KEY(frame, dict, name, this, loc, fd, priv)      \
256ebe
     do {                                                                       \
256ebe
-        if (dict_get(dict, GF_ENFORCE_MANDATORY_LOCK) ||                       \
256ebe
+        if ((dict && (dict_get(dict, GF_ENFORCE_MANDATORY_LOCK))) ||           \
256ebe
             (name && (strcmp(name, GF_ENFORCE_MANDATORY_LOCK) == 0))) {        \
256ebe
             inode_t *__inode = (loc ? loc->inode : fd->inode);                 \
256ebe
             pl_inode_t *__pl_inode = pl_inode_get(this, __inode, NULL);        \
256ebe
-- 
256ebe
1.8.3.1
256ebe