|
 |
50dc83 |
From 40bd6e9c186adb427e136a84eaab631e6a6f5263 Mon Sep 17 00:00:00 2001
|
|
|
50dc83 |
From: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
50dc83 |
Date: Sun, 5 May 2019 21:17:24 +0530
|
|
|
50dc83 |
Subject: [PATCH 140/141] cluster/ec: Reopen shouldn't happen with O_TRUNC
|
|
|
50dc83 |
|
|
|
50dc83 |
Problem:
|
|
|
50dc83 |
Doing re-open with O_TRUNC will truncate the fragment even when it is not
|
|
|
50dc83 |
needed needing extra heals
|
|
|
50dc83 |
|
|
|
50dc83 |
Fix:
|
|
|
50dc83 |
At the time of re-open don't use O_TRUNC.
|
|
|
50dc83 |
|
|
|
50dc83 |
Upstream-patch: https://review.gluster.org/c/glusterfs/+/22660/
|
|
|
50dc83 |
|
|
|
50dc83 |
fixes bz#1706549
|
|
|
50dc83 |
Change-Id: Idc6408968efaad897b95a5a52481c66e843d3fb8
|
|
|
50dc83 |
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
|
|
|
50dc83 |
Reviewed-on: https://code.engineering.redhat.com/gerrit/169982
|
|
|
50dc83 |
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
|
50dc83 |
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
|
50dc83 |
---
|
|
|
50dc83 |
xlators/cluster/ec/src/ec-common.c | 2 +-
|
|
|
50dc83 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
50dc83 |
|
|
|
50dc83 |
diff --git a/xlators/cluster/ec/src/ec-common.c b/xlators/cluster/ec/src/ec-common.c
|
|
|
50dc83 |
index 1454ae2..b1ba5e9 100644
|
|
|
50dc83 |
--- a/xlators/cluster/ec/src/ec-common.c
|
|
|
50dc83 |
+++ b/xlators/cluster/ec/src/ec-common.c
|
|
|
50dc83 |
@@ -128,7 +128,7 @@ ec_fix_open(ec_fop_data_t *fop, uintptr_t mask)
|
|
|
50dc83 |
} else {
|
|
|
50dc83 |
ec_open(fop->frame, fop->xl, need_open,
|
|
|
50dc83 |
EC_MINIMUM_ONE | EC_FOP_NO_PROPAGATE_ERROR, NULL, NULL, &loc,
|
|
|
50dc83 |
- fop->fd->flags, fop->fd, NULL);
|
|
|
50dc83 |
+ fop->fd->flags & (~O_TRUNC), fop->fd, NULL);
|
|
|
50dc83 |
}
|
|
|
50dc83 |
|
|
|
50dc83 |
out:
|
|
|
50dc83 |
--
|
|
|
50dc83 |
1.8.3.1
|
|
|
50dc83 |
|