e3c68b
From 677f575d2289285d2e553ddd610944856cb947db Mon Sep 17 00:00:00 2001
e3c68b
From: Sunny Kumar <sunkumar@redhat.com>
e3c68b
Date: Fri, 10 May 2019 11:21:03 +0530
e3c68b
Subject: [PATCH 135/141] geo-rep: fix incorrectly formatted authorized_keys
e3c68b
e3c68b
There are two ways for creating secret pem pub file during geo-rep
e3c68b
setup.
e3c68b
1. gluster-georep-sshkey generate
e3c68b
2. gluster system:: execute gsec_create
e3c68b
e3c68b
Below patch solves this problem for `gluster-georep-sshkey generate`
e3c68b
method.
e3c68b
Patch link: https://review.gluster.org/#/c/glusterfs/+/22246/
e3c68b
e3c68b
This patch is added to support old way of creating secret pem pub file
e3c68b
`gluster system:: execute gsec_create`.
e3c68b
e3c68b
Problem:  While Geo-rep setup when creating an ssh authorized_keys
e3c68b
          the geo-rep setup inserts an extra space before the "ssh-rsa" label.
e3c68b
          This gets flagged by an enterprise customer's security scan as a
e3c68b
          security violation.
e3c68b
Solution: Remove extra space while creating secret key.
e3c68b
e3c68b
Upstream Patch: https://review.gluster.org/#/c/glusterfs/+/22673/
e3c68b
e3c68b
>fixes: bz#1679401
e3c68b
>Change-Id: I92ba7e25aaa5123dae9ebe2f3c68d14315aa5f0e
e3c68b
>Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
e3c68b
e3c68b
BUG: 1671862
e3c68b
Change-Id: I11e90c00a14a301a5d95e14b5e8984867e6ff893
e3c68b
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
e3c68b
Reviewed-on: https://code.engineering.redhat.com/gerrit/169870
e3c68b
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e3c68b
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
e3c68b
---
e3c68b
 geo-replication/src/peer_gsec_create.in | 4 ++--
e3c68b
 1 file changed, 2 insertions(+), 2 deletions(-)
e3c68b
e3c68b
diff --git a/geo-replication/src/peer_gsec_create.in b/geo-replication/src/peer_gsec_create.in
e3c68b
index 05c1638..6d4a484 100755
e3c68b
--- a/geo-replication/src/peer_gsec_create.in
e3c68b
+++ b/geo-replication/src/peer_gsec_create.in
e3c68b
@@ -18,7 +18,7 @@ if [ "Xcontainer" = "X$1" ]; then
e3c68b
     output1=`cat "$GLUSTERD_WORKDIR"/geo-replication/secret.pem.pub`
e3c68b
     output2=`cat "$GLUSTERD_WORKDIR"/geo-replication/tar_ssh.pem.pub`
e3c68b
 else
e3c68b
-    output1=`echo command=\"${libexecdir}/glusterfs/gsyncd\" " "``cat "$GLUSTERD_WORKDIR"/geo-replication/secret.pem.pub`
e3c68b
-    output2=`echo command=\"tar \$\{SSH_ORIGINAL_COMMAND#* \}\" " "``cat "$GLUSTERD_WORKDIR"/geo-replication/tar_ssh.pem.pub`
e3c68b
+    output1=`echo command=\"${libexecdir}/glusterfs/gsyncd\" ""``cat "$GLUSTERD_WORKDIR"/geo-replication/secret.pem.pub`
e3c68b
+    output2=`echo command=\"tar \$\{SSH_ORIGINAL_COMMAND#* \}\" ""``cat "$GLUSTERD_WORKDIR"/geo-replication/tar_ssh.pem.pub`
e3c68b
 fi
e3c68b
 echo -e "$output1\n$output2"
e3c68b
-- 
e3c68b
1.8.3.1
e3c68b