256ebe
From 677f575d2289285d2e553ddd610944856cb947db Mon Sep 17 00:00:00 2001
256ebe
From: Sunny Kumar <sunkumar@redhat.com>
256ebe
Date: Fri, 10 May 2019 11:21:03 +0530
256ebe
Subject: [PATCH 135/141] geo-rep: fix incorrectly formatted authorized_keys
256ebe
256ebe
There are two ways for creating secret pem pub file during geo-rep
256ebe
setup.
256ebe
1. gluster-georep-sshkey generate
256ebe
2. gluster system:: execute gsec_create
256ebe
256ebe
Below patch solves this problem for `gluster-georep-sshkey generate`
256ebe
method.
256ebe
Patch link: https://review.gluster.org/#/c/glusterfs/+/22246/
256ebe
256ebe
This patch is added to support old way of creating secret pem pub file
256ebe
`gluster system:: execute gsec_create`.
256ebe
256ebe
Problem:  While Geo-rep setup when creating an ssh authorized_keys
256ebe
          the geo-rep setup inserts an extra space before the "ssh-rsa" label.
256ebe
          This gets flagged by an enterprise customer's security scan as a
256ebe
          security violation.
256ebe
Solution: Remove extra space while creating secret key.
256ebe
256ebe
Upstream Patch: https://review.gluster.org/#/c/glusterfs/+/22673/
256ebe
256ebe
>fixes: bz#1679401
256ebe
>Change-Id: I92ba7e25aaa5123dae9ebe2f3c68d14315aa5f0e
256ebe
>Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
256ebe
256ebe
BUG: 1671862
256ebe
Change-Id: I11e90c00a14a301a5d95e14b5e8984867e6ff893
256ebe
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
256ebe
Reviewed-on: https://code.engineering.redhat.com/gerrit/169870
256ebe
Tested-by: RHGS Build Bot <nigelb@redhat.com>
256ebe
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
256ebe
---
256ebe
 geo-replication/src/peer_gsec_create.in | 4 ++--
256ebe
 1 file changed, 2 insertions(+), 2 deletions(-)
256ebe
256ebe
diff --git a/geo-replication/src/peer_gsec_create.in b/geo-replication/src/peer_gsec_create.in
256ebe
index 05c1638..6d4a484 100755
256ebe
--- a/geo-replication/src/peer_gsec_create.in
256ebe
+++ b/geo-replication/src/peer_gsec_create.in
256ebe
@@ -18,7 +18,7 @@ if [ "Xcontainer" = "X$1" ]; then
256ebe
     output1=`cat "$GLUSTERD_WORKDIR"/geo-replication/secret.pem.pub`
256ebe
     output2=`cat "$GLUSTERD_WORKDIR"/geo-replication/tar_ssh.pem.pub`
256ebe
 else
256ebe
-    output1=`echo command=\"${libexecdir}/glusterfs/gsyncd\" " "``cat "$GLUSTERD_WORKDIR"/geo-replication/secret.pem.pub`
256ebe
-    output2=`echo command=\"tar \$\{SSH_ORIGINAL_COMMAND#* \}\" " "``cat "$GLUSTERD_WORKDIR"/geo-replication/tar_ssh.pem.pub`
256ebe
+    output1=`echo command=\"${libexecdir}/glusterfs/gsyncd\" ""``cat "$GLUSTERD_WORKDIR"/geo-replication/secret.pem.pub`
256ebe
+    output2=`echo command=\"tar \$\{SSH_ORIGINAL_COMMAND#* \}\" ""``cat "$GLUSTERD_WORKDIR"/geo-replication/tar_ssh.pem.pub`
256ebe
 fi
256ebe
 echo -e "$output1\n$output2"
256ebe
-- 
256ebe
1.8.3.1
256ebe