e3c68b
From 70842c77735a655a053ed4a7cb77fec01028355a Mon Sep 17 00:00:00 2001
e3c68b
From: Sunil Kumar Acharya <sheggodu@redhat.com>
e3c68b
Date: Mon, 22 Apr 2019 12:48:13 +0530
e3c68b
Subject: [PATCH 117/124] spec: Remove thin-arbiter package
e3c68b
e3c68b
Thin-arbiter is not supported in downstream. Updated the
e3c68b
code to avoid RPMdiff warnings. Marked thin-arbiter
e3c68b
test cases as bad to avoid nightly runs from reporting
e3c68b
expected failures.
e3c68b
e3c68b
Label: DOWNSTREAM ONLY
e3c68b
e3c68b
BUG: 1698436
e3c68b
Change-Id: Ic36bccdfe1c7039fb7e5ce078a8b64cf71056970
e3c68b
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
e3c68b
Reviewed-on: https://code.engineering.redhat.com/gerrit/168406
e3c68b
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e3c68b
---
e3c68b
 configure.ac                            |  2 --
e3c68b
 extras/systemd/Makefile.am              |  6 ++---
e3c68b
 glusterfs.spec.in                       | 39 +++++----------------------------
e3c68b
 tests/basic/afr/ta-check-locks.t        |  2 ++
e3c68b
 tests/basic/afr/ta-read.t               |  2 ++
e3c68b
 tests/basic/afr/ta-shd.t                |  2 ++
e3c68b
 tests/basic/afr/ta-write-on-bad-brick.t |  2 ++
e3c68b
 xlators/features/Makefile.am            |  2 +-
e3c68b
 8 files changed, 18 insertions(+), 39 deletions(-)
e3c68b
e3c68b
diff --git a/configure.ac b/configure.ac
e3c68b
index 521671b..3065077 100644
e3c68b
--- a/configure.ac
e3c68b
+++ b/configure.ac
e3c68b
@@ -116,8 +116,6 @@ AC_CONFIG_FILES([Makefile
e3c68b
                 xlators/features/Makefile
e3c68b
                 xlators/features/arbiter/Makefile
e3c68b
                 xlators/features/arbiter/src/Makefile
e3c68b
-                xlators/features/thin-arbiter/Makefile
e3c68b
-                xlators/features/thin-arbiter/src/Makefile
e3c68b
                 xlators/features/changelog/Makefile
e3c68b
                 xlators/features/changelog/src/Makefile
e3c68b
                 xlators/features/changelog/lib/Makefile
e3c68b
diff --git a/extras/systemd/Makefile.am b/extras/systemd/Makefile.am
e3c68b
index 61446a9..b849775 100644
e3c68b
--- a/extras/systemd/Makefile.am
e3c68b
+++ b/extras/systemd/Makefile.am
e3c68b
@@ -1,8 +1,8 @@
e3c68b
-CLEANFILES = glusterd.service glustereventsd.service glusterfssharedstorage.service gluster-ta-volume.service
e3c68b
-EXTRA_DIST = glusterd.service.in glustereventsd.service.in glusterfssharedstorage.service.in gluster-ta-volume.service.in
e3c68b
+CLEANFILES = glusterd.service glustereventsd.service glusterfssharedstorage.service
e3c68b
+EXTRA_DIST = glusterd.service.in glustereventsd.service.in glusterfssharedstorage.service.in
e3c68b
 
e3c68b
 if USE_SYSTEMD
e3c68b
-systemd_DATA = gluster-ta-volume.service
e3c68b
+systemd_DATA =
e3c68b
 endif
e3c68b
 
e3c68b
 if WITH_SERVER
e3c68b
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
e3c68b
index ba095b7..bf72a55 100644
e3c68b
--- a/glusterfs.spec.in
e3c68b
+++ b/glusterfs.spec.in
e3c68b
@@ -682,18 +682,6 @@ is in user space and easily manageable.
e3c68b
 This package provides the glusterfs server daemon.
e3c68b
 %endif
e3c68b
 
e3c68b
-%package thin-arbiter
e3c68b
-Summary:          GlusterFS thin-arbiter module
e3c68b
-Requires:         %{name}%{?_isa} = %{version}-%{release}
e3c68b
-Requires:         %{name}-server%{?_isa} = %{version}-%{release}
e3c68b
-
e3c68b
-%description thin-arbiter
e3c68b
-This package provides a tie-breaker functionality to GlusterFS
e3c68b
-replicate volume. It includes translators required to provide the
e3c68b
-functionality, and also few other scripts required for getting the setup done.
e3c68b
-
e3c68b
-This package provides the glusterfs thin-arbiter translator.
e3c68b
-
e3c68b
 %package client-xlators
e3c68b
 Summary:          GlusterFS client-side translators
e3c68b
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
e3c68b
@@ -1045,14 +1033,6 @@ fi
e3c68b
 exit 0
e3c68b
 %endif
e3c68b
 
e3c68b
-%preun thin-arbiter
e3c68b
-if [ $1 -eq 0 ]; then
e3c68b
-    if [ -f %glusterta_svcfile ]; then
e3c68b
-        %service_stop gluster-ta-volume
e3c68b
-        %systemd_preun gluster-ta-volume
e3c68b
-    fi
e3c68b
-fi
e3c68b
-
e3c68b
 ##-----------------------------------------------------------------------------
e3c68b
 ## All %%postun should be placed here and keep them sorted
e3c68b
 ##
e3c68b
@@ -1188,6 +1168,12 @@ exit 0
e3c68b
 %exclude %{_prefix}/lib/ocf/resource.d/heartbeat/*
e3c68b
 %endif
e3c68b
 
e3c68b
+%exclude %{_datadir}/glusterfs/scripts/setup-thin-arbiter.sh
e3c68b
+
e3c68b
+%if ( 0%{?_without_server:1} )
e3c68b
+%exclude %{_sysconfdir}/glusterfs/thin-arbiter.vol
e3c68b
+%endif
e3c68b
+
e3c68b
 %files api
e3c68b
 %exclude %{_libdir}/*.so
e3c68b
 # libgfapi files
e3c68b
@@ -1263,19 +1249,6 @@ exit 0
e3c68b
 %{_bindir}/fusermount-glusterfs
e3c68b
 %endif
e3c68b
 
e3c68b
-%files thin-arbiter
e3c68b
-%dir %{_libdir}/glusterfs/%{version}%{?prereltag}/xlator
e3c68b
-%dir %{_libdir}/glusterfs/%{version}%{?prereltag}/xlator/features
e3c68b
-     %{_libdir}/glusterfs/%{version}%{?prereltag}/xlator/features/thin-arbiter.so
e3c68b
-%dir %{_datadir}/glusterfs/scripts
e3c68b
-     %{_datadir}/glusterfs/scripts/setup-thin-arbiter.sh
e3c68b
-%config %{_sysconfdir}/glusterfs/thin-arbiter.vol
e3c68b
-
e3c68b
-%if ( 0%{?_with_systemd:1} )
e3c68b
-%{_unitdir}/gluster-ta-volume.service
e3c68b
-%endif
e3c68b
-
e3c68b
-
e3c68b
 %if ( 0%{!?_without_georeplication:1} )
e3c68b
 %files geo-replication
e3c68b
 %config(noreplace) %{_sysconfdir}/logrotate.d/glusterfs-georep
e3c68b
diff --git a/tests/basic/afr/ta-check-locks.t b/tests/basic/afr/ta-check-locks.t
e3c68b
index c0102c3..c51aa39 100644
e3c68b
--- a/tests/basic/afr/ta-check-locks.t
e3c68b
+++ b/tests/basic/afr/ta-check-locks.t
e3c68b
@@ -66,3 +66,5 @@ TEST ta_start_brick_process brick0
e3c68b
 EXPECT_WITHIN $HEAL_TIMEOUT "0" get_lock_count_on_ta
e3c68b
 
e3c68b
 cleanup;
e3c68b
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
e3c68b
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
e3c68b
diff --git a/tests/basic/afr/ta-read.t b/tests/basic/afr/ta-read.t
e3c68b
index f2b3c38..1b36dba 100644
e3c68b
--- a/tests/basic/afr/ta-read.t
e3c68b
+++ b/tests/basic/afr/ta-read.t
e3c68b
@@ -58,3 +58,5 @@ TEST [ -z $TA_PID ]
e3c68b
 # Read must now succeed.
e3c68b
 TEST cat $M0/FILE
e3c68b
 cleanup;
e3c68b
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
e3c68b
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
e3c68b
diff --git a/tests/basic/afr/ta-shd.t b/tests/basic/afr/ta-shd.t
e3c68b
index bb2e58b..4b1ea85 100644
e3c68b
--- a/tests/basic/afr/ta-shd.t
e3c68b
+++ b/tests/basic/afr/ta-shd.t
e3c68b
@@ -47,3 +47,5 @@ TEST ta_start_mount_process $M0
e3c68b
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" ta_up_status $V0 $M0 0
e3c68b
 EXPECT "Hello" cat $M0/a.txt
e3c68b
 cleanup;
e3c68b
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
e3c68b
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
e3c68b
diff --git a/tests/basic/afr/ta-write-on-bad-brick.t b/tests/basic/afr/ta-write-on-bad-brick.t
e3c68b
index 18cb65b..77cbf5f 100644
e3c68b
--- a/tests/basic/afr/ta-write-on-bad-brick.t
e3c68b
+++ b/tests/basic/afr/ta-write-on-bad-brick.t
e3c68b
@@ -49,3 +49,5 @@ EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" afr_child_up_status_meta $M0 $V0-replicate
e3c68b
 TEST dd if=/dev/zero of=$M0/a.txt bs=1M count=5
e3c68b
 
e3c68b
 cleanup;
e3c68b
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
e3c68b
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
e3c68b
diff --git a/xlators/features/Makefile.am b/xlators/features/Makefile.am
e3c68b
index 545c02b..537c148 100644
e3c68b
--- a/xlators/features/Makefile.am
e3c68b
+++ b/xlators/features/Makefile.am
e3c68b
@@ -4,7 +4,7 @@ endif
e3c68b
 
e3c68b
 SUBDIRS = locks quota read-only quiesce marker index barrier arbiter upcall \
e3c68b
 	compress changelog gfid-access snapview-client snapview-server trash \
e3c68b
-	shard bit-rot leases selinux sdfs namespace $(CLOUDSYNC_DIR) thin-arbiter \
e3c68b
+	shard bit-rot leases selinux sdfs namespace $(CLOUDSYNC_DIR) \
e3c68b
 	utime changetimerecorder
e3c68b
 
e3c68b
 CLEANFILES =
e3c68b
-- 
e3c68b
1.8.3.1
e3c68b