14f8ab
From 70842c77735a655a053ed4a7cb77fec01028355a Mon Sep 17 00:00:00 2001
14f8ab
From: Sunil Kumar Acharya <sheggodu@redhat.com>
14f8ab
Date: Mon, 22 Apr 2019 12:48:13 +0530
14f8ab
Subject: [PATCH 117/124] spec: Remove thin-arbiter package
14f8ab
14f8ab
Thin-arbiter is not supported in downstream. Updated the
14f8ab
code to avoid RPMdiff warnings. Marked thin-arbiter
14f8ab
test cases as bad to avoid nightly runs from reporting
14f8ab
expected failures.
14f8ab
14f8ab
Label: DOWNSTREAM ONLY
14f8ab
14f8ab
BUG: 1698436
14f8ab
Change-Id: Ic36bccdfe1c7039fb7e5ce078a8b64cf71056970
14f8ab
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/168406
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
---
14f8ab
 configure.ac                            |  2 --
14f8ab
 extras/systemd/Makefile.am              |  6 ++---
14f8ab
 glusterfs.spec.in                       | 39 +++++----------------------------
14f8ab
 tests/basic/afr/ta-check-locks.t        |  2 ++
14f8ab
 tests/basic/afr/ta-read.t               |  2 ++
14f8ab
 tests/basic/afr/ta-shd.t                |  2 ++
14f8ab
 tests/basic/afr/ta-write-on-bad-brick.t |  2 ++
14f8ab
 xlators/features/Makefile.am            |  2 +-
14f8ab
 8 files changed, 18 insertions(+), 39 deletions(-)
14f8ab
14f8ab
diff --git a/configure.ac b/configure.ac
14f8ab
index 521671b..3065077 100644
14f8ab
--- a/configure.ac
14f8ab
+++ b/configure.ac
14f8ab
@@ -116,8 +116,6 @@ AC_CONFIG_FILES([Makefile
14f8ab
                 xlators/features/Makefile
14f8ab
                 xlators/features/arbiter/Makefile
14f8ab
                 xlators/features/arbiter/src/Makefile
14f8ab
-                xlators/features/thin-arbiter/Makefile
14f8ab
-                xlators/features/thin-arbiter/src/Makefile
14f8ab
                 xlators/features/changelog/Makefile
14f8ab
                 xlators/features/changelog/src/Makefile
14f8ab
                 xlators/features/changelog/lib/Makefile
14f8ab
diff --git a/extras/systemd/Makefile.am b/extras/systemd/Makefile.am
14f8ab
index 61446a9..b849775 100644
14f8ab
--- a/extras/systemd/Makefile.am
14f8ab
+++ b/extras/systemd/Makefile.am
14f8ab
@@ -1,8 +1,8 @@
14f8ab
-CLEANFILES = glusterd.service glustereventsd.service glusterfssharedstorage.service gluster-ta-volume.service
14f8ab
-EXTRA_DIST = glusterd.service.in glustereventsd.service.in glusterfssharedstorage.service.in gluster-ta-volume.service.in
14f8ab
+CLEANFILES = glusterd.service glustereventsd.service glusterfssharedstorage.service
14f8ab
+EXTRA_DIST = glusterd.service.in glustereventsd.service.in glusterfssharedstorage.service.in
14f8ab
 
14f8ab
 if USE_SYSTEMD
14f8ab
-systemd_DATA = gluster-ta-volume.service
14f8ab
+systemd_DATA =
14f8ab
 endif
14f8ab
 
14f8ab
 if WITH_SERVER
14f8ab
diff --git a/glusterfs.spec.in b/glusterfs.spec.in
14f8ab
index ba095b7..bf72a55 100644
14f8ab
--- a/glusterfs.spec.in
14f8ab
+++ b/glusterfs.spec.in
14f8ab
@@ -682,18 +682,6 @@ is in user space and easily manageable.
14f8ab
 This package provides the glusterfs server daemon.
14f8ab
 %endif
14f8ab
 
14f8ab
-%package thin-arbiter
14f8ab
-Summary:          GlusterFS thin-arbiter module
14f8ab
-Requires:         %{name}%{?_isa} = %{version}-%{release}
14f8ab
-Requires:         %{name}-server%{?_isa} = %{version}-%{release}
14f8ab
-
14f8ab
-%description thin-arbiter
14f8ab
-This package provides a tie-breaker functionality to GlusterFS
14f8ab
-replicate volume. It includes translators required to provide the
14f8ab
-functionality, and also few other scripts required for getting the setup done.
14f8ab
-
14f8ab
-This package provides the glusterfs thin-arbiter translator.
14f8ab
-
14f8ab
 %package client-xlators
14f8ab
 Summary:          GlusterFS client-side translators
14f8ab
 Requires:         %{name}-libs%{?_isa} = %{version}-%{release}
14f8ab
@@ -1045,14 +1033,6 @@ fi
14f8ab
 exit 0
14f8ab
 %endif
14f8ab
 
14f8ab
-%preun thin-arbiter
14f8ab
-if [ $1 -eq 0 ]; then
14f8ab
-    if [ -f %glusterta_svcfile ]; then
14f8ab
-        %service_stop gluster-ta-volume
14f8ab
-        %systemd_preun gluster-ta-volume
14f8ab
-    fi
14f8ab
-fi
14f8ab
-
14f8ab
 ##-----------------------------------------------------------------------------
14f8ab
 ## All %%postun should be placed here and keep them sorted
14f8ab
 ##
14f8ab
@@ -1188,6 +1168,12 @@ exit 0
14f8ab
 %exclude %{_prefix}/lib/ocf/resource.d/heartbeat/*
14f8ab
 %endif
14f8ab
 
14f8ab
+%exclude %{_datadir}/glusterfs/scripts/setup-thin-arbiter.sh
14f8ab
+
14f8ab
+%if ( 0%{?_without_server:1} )
14f8ab
+%exclude %{_sysconfdir}/glusterfs/thin-arbiter.vol
14f8ab
+%endif
14f8ab
+
14f8ab
 %files api
14f8ab
 %exclude %{_libdir}/*.so
14f8ab
 # libgfapi files
14f8ab
@@ -1263,19 +1249,6 @@ exit 0
14f8ab
 %{_bindir}/fusermount-glusterfs
14f8ab
 %endif
14f8ab
 
14f8ab
-%files thin-arbiter
14f8ab
-%dir %{_libdir}/glusterfs/%{version}%{?prereltag}/xlator
14f8ab
-%dir %{_libdir}/glusterfs/%{version}%{?prereltag}/xlator/features
14f8ab
-     %{_libdir}/glusterfs/%{version}%{?prereltag}/xlator/features/thin-arbiter.so
14f8ab
-%dir %{_datadir}/glusterfs/scripts
14f8ab
-     %{_datadir}/glusterfs/scripts/setup-thin-arbiter.sh
14f8ab
-%config %{_sysconfdir}/glusterfs/thin-arbiter.vol
14f8ab
-
14f8ab
-%if ( 0%{?_with_systemd:1} )
14f8ab
-%{_unitdir}/gluster-ta-volume.service
14f8ab
-%endif
14f8ab
-
14f8ab
-
14f8ab
 %if ( 0%{!?_without_georeplication:1} )
14f8ab
 %files geo-replication
14f8ab
 %config(noreplace) %{_sysconfdir}/logrotate.d/glusterfs-georep
14f8ab
diff --git a/tests/basic/afr/ta-check-locks.t b/tests/basic/afr/ta-check-locks.t
14f8ab
index c0102c3..c51aa39 100644
14f8ab
--- a/tests/basic/afr/ta-check-locks.t
14f8ab
+++ b/tests/basic/afr/ta-check-locks.t
14f8ab
@@ -66,3 +66,5 @@ TEST ta_start_brick_process brick0
14f8ab
 EXPECT_WITHIN $HEAL_TIMEOUT "0" get_lock_count_on_ta
14f8ab
 
14f8ab
 cleanup;
14f8ab
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
14f8ab
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
14f8ab
diff --git a/tests/basic/afr/ta-read.t b/tests/basic/afr/ta-read.t
14f8ab
index f2b3c38..1b36dba 100644
14f8ab
--- a/tests/basic/afr/ta-read.t
14f8ab
+++ b/tests/basic/afr/ta-read.t
14f8ab
@@ -58,3 +58,5 @@ TEST [ -z $TA_PID ]
14f8ab
 # Read must now succeed.
14f8ab
 TEST cat $M0/FILE
14f8ab
 cleanup;
14f8ab
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
14f8ab
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
14f8ab
diff --git a/tests/basic/afr/ta-shd.t b/tests/basic/afr/ta-shd.t
14f8ab
index bb2e58b..4b1ea85 100644
14f8ab
--- a/tests/basic/afr/ta-shd.t
14f8ab
+++ b/tests/basic/afr/ta-shd.t
14f8ab
@@ -47,3 +47,5 @@ TEST ta_start_mount_process $M0
14f8ab
 EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" ta_up_status $V0 $M0 0
14f8ab
 EXPECT "Hello" cat $M0/a.txt
14f8ab
 cleanup;
14f8ab
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
14f8ab
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
14f8ab
diff --git a/tests/basic/afr/ta-write-on-bad-brick.t b/tests/basic/afr/ta-write-on-bad-brick.t
14f8ab
index 18cb65b..77cbf5f 100644
14f8ab
--- a/tests/basic/afr/ta-write-on-bad-brick.t
14f8ab
+++ b/tests/basic/afr/ta-write-on-bad-brick.t
14f8ab
@@ -49,3 +49,5 @@ EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" afr_child_up_status_meta $M0 $V0-replicate
14f8ab
 TEST dd if=/dev/zero of=$M0/a.txt bs=1M count=5
14f8ab
 
14f8ab
 cleanup;
14f8ab
+#G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=0000000
14f8ab
+#G_TESTDEF_TEST_STATUS_NETBSD7=BAD_TEST,BUG=0000000
14f8ab
diff --git a/xlators/features/Makefile.am b/xlators/features/Makefile.am
14f8ab
index 545c02b..537c148 100644
14f8ab
--- a/xlators/features/Makefile.am
14f8ab
+++ b/xlators/features/Makefile.am
14f8ab
@@ -4,7 +4,7 @@ endif
14f8ab
 
14f8ab
 SUBDIRS = locks quota read-only quiesce marker index barrier arbiter upcall \
14f8ab
 	compress changelog gfid-access snapview-client snapview-server trash \
14f8ab
-	shard bit-rot leases selinux sdfs namespace $(CLOUDSYNC_DIR) thin-arbiter \
14f8ab
+	shard bit-rot leases selinux sdfs namespace $(CLOUDSYNC_DIR) \
14f8ab
 	utime changetimerecorder
14f8ab
 
14f8ab
 CLEANFILES =
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab