17b94a
From 45c9eeb5544738d4d1d0aefb8a7f61e5d8859ad8 Mon Sep 17 00:00:00 2001
17b94a
From: Mohammed Rafi KC <rkavunga@redhat.com>
17b94a
Date: Tue, 12 Mar 2019 18:00:37 +0530
17b94a
Subject: [PATCH 103/124] dht: NULL check before setting error flag
17b94a
17b94a
Function dht_common_mark_mdsxattr blindly setting value for
17b94a
an integer pointer without validating it. In fact there are
17b94a
two callers of this function that passes NULL value to the
17b94a
same pointer which leads to a crash.
17b94a
17b94a
Backport of : https://review.gluster.org/#/c/22345/
17b94a
17b94a
>Change-Id: Id94ffe216f6a21f007b3291bff0b1e1c1989075c
17b94a
>fixes: bz#1687811
17b94a
>Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
17b94a
17b94a
Change-Id: Id9785c16184fd80e8184e5ae135fb63bf44692cd
17b94a
BUG: 1471742
17b94a
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/167846
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
17b94a
---
17b94a
 xlators/cluster/dht/src/dht-common.c | 3 ++-
17b94a
 1 file changed, 2 insertions(+), 1 deletion(-)
17b94a
17b94a
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c
17b94a
index 367548f..2a68193 100644
17b94a
--- a/xlators/cluster/dht/src/dht-common.c
17b94a
+++ b/xlators/cluster/dht/src/dht-common.c
17b94a
@@ -852,7 +852,8 @@ dht_common_mark_mdsxattr(call_frame_t *frame, int *errst,
17b94a
                    "Failed to get hashed subvol for path %s"
17b94a
                    "gfid is %s ",
17b94a
                    local->loc.path, gfid_local);
17b94a
-            (*errst) = 1;
17b94a
+            if (errst)
17b94a
+                (*errst) = 1;
17b94a
             ret = -1;
17b94a
             goto out;
17b94a
         }
17b94a
-- 
17b94a
1.8.3.1
17b94a