14f8ab
From dab37dc78d21762ac3379ad505f8fc4ec996d0f7 Mon Sep 17 00:00:00 2001
14f8ab
From: Atin Mukherjee <amukherj@redhat.com>
14f8ab
Date: Tue, 9 Apr 2019 14:58:29 +0530
14f8ab
Subject: [PATCH 094/124] glusterd: load ctime in the client graph only if it's
14f8ab
 not turned off
14f8ab
14f8ab
Considering ctime is a client side feature, we can't blindly load ctime
14f8ab
xlator into the client graph if it's explicitly turned off, that'd
14f8ab
result into backward compatibility issue where an old client can't mount
14f8ab
a volume configured on a server which is having ctime feature.
14f8ab
14f8ab
> Upstream patch : https://review.gluster.org/#/c/glusterfs/+/22536/
14f8ab
>Fixes: bz#1697907
14f8ab
>Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
14f8ab
>Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
14f8ab
14f8ab
BUG: 1697820
14f8ab
Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
14f8ab
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
14f8ab
Reviewed-on: https://code.engineering.redhat.com/gerrit/167815
14f8ab
Tested-by: RHGS Build Bot <nigelb@redhat.com>
14f8ab
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
14f8ab
Reviewed-by: Amar Tumballi Suryanarayan <amarts@redhat.com>
14f8ab
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
14f8ab
---
14f8ab
 xlators/mgmt/glusterd/src/glusterd-volgen.c | 3 ++-
14f8ab
 1 file changed, 2 insertions(+), 1 deletion(-)
14f8ab
14f8ab
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
14f8ab
index ed24858..012f38e 100644
14f8ab
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
14f8ab
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
14f8ab
@@ -4358,7 +4358,8 @@ client_graph_builder(volgen_graph_t *graph, glusterd_volinfo_t *volinfo,
14f8ab
         }
14f8ab
     }
14f8ab
 
14f8ab
-    if (conf->op_version >= GD_OP_VERSION_5_0) {
14f8ab
+    if (conf->op_version >= GD_OP_VERSION_5_0 &&
14f8ab
+        !dict_get_str_boolean(set_dict, "features.ctime", _gf_false)) {
14f8ab
         xl = volgen_graph_add(graph, "features/utime", volname);
14f8ab
         if (!xl) {
14f8ab
             ret = -1;
14f8ab
-- 
14f8ab
1.8.3.1
14f8ab