74b1de
From dab37dc78d21762ac3379ad505f8fc4ec996d0f7 Mon Sep 17 00:00:00 2001
74b1de
From: Atin Mukherjee <amukherj@redhat.com>
74b1de
Date: Tue, 9 Apr 2019 14:58:29 +0530
74b1de
Subject: [PATCH 094/124] glusterd: load ctime in the client graph only if it's
74b1de
 not turned off
74b1de
74b1de
Considering ctime is a client side feature, we can't blindly load ctime
74b1de
xlator into the client graph if it's explicitly turned off, that'd
74b1de
result into backward compatibility issue where an old client can't mount
74b1de
a volume configured on a server which is having ctime feature.
74b1de
74b1de
> Upstream patch : https://review.gluster.org/#/c/glusterfs/+/22536/
74b1de
>Fixes: bz#1697907
74b1de
>Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
74b1de
>Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
74b1de
74b1de
BUG: 1697820
74b1de
Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
74b1de
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/167815
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
74b1de
Reviewed-by: Amar Tumballi Suryanarayan <amarts@redhat.com>
74b1de
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
74b1de
---
74b1de
 xlators/mgmt/glusterd/src/glusterd-volgen.c | 3 ++-
74b1de
 1 file changed, 2 insertions(+), 1 deletion(-)
74b1de
74b1de
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
74b1de
index ed24858..012f38e 100644
74b1de
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
74b1de
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
74b1de
@@ -4358,7 +4358,8 @@ client_graph_builder(volgen_graph_t *graph, glusterd_volinfo_t *volinfo,
74b1de
         }
74b1de
     }
74b1de
 
74b1de
-    if (conf->op_version >= GD_OP_VERSION_5_0) {
74b1de
+    if (conf->op_version >= GD_OP_VERSION_5_0 &&
74b1de
+        !dict_get_str_boolean(set_dict, "features.ctime", _gf_false)) {
74b1de
         xl = volgen_graph_add(graph, "features/utime", volname);
74b1de
         if (!xl) {
74b1de
             ret = -1;
74b1de
-- 
74b1de
1.8.3.1
74b1de