50dc83
From dab37dc78d21762ac3379ad505f8fc4ec996d0f7 Mon Sep 17 00:00:00 2001
50dc83
From: Atin Mukherjee <amukherj@redhat.com>
50dc83
Date: Tue, 9 Apr 2019 14:58:29 +0530
50dc83
Subject: [PATCH 094/124] glusterd: load ctime in the client graph only if it's
50dc83
 not turned off
50dc83
50dc83
Considering ctime is a client side feature, we can't blindly load ctime
50dc83
xlator into the client graph if it's explicitly turned off, that'd
50dc83
result into backward compatibility issue where an old client can't mount
50dc83
a volume configured on a server which is having ctime feature.
50dc83
50dc83
> Upstream patch : https://review.gluster.org/#/c/glusterfs/+/22536/
50dc83
>Fixes: bz#1697907
50dc83
>Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
50dc83
>Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
50dc83
50dc83
BUG: 1697820
50dc83
Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
50dc83
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
50dc83
Reviewed-on: https://code.engineering.redhat.com/gerrit/167815
50dc83
Tested-by: RHGS Build Bot <nigelb@redhat.com>
50dc83
Reviewed-by: Mohit Agrawal <moagrawa@redhat.com>
50dc83
Reviewed-by: Amar Tumballi Suryanarayan <amarts@redhat.com>
50dc83
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
50dc83
---
50dc83
 xlators/mgmt/glusterd/src/glusterd-volgen.c | 3 ++-
50dc83
 1 file changed, 2 insertions(+), 1 deletion(-)
50dc83
50dc83
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
50dc83
index ed24858..012f38e 100644
50dc83
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
50dc83
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
50dc83
@@ -4358,7 +4358,8 @@ client_graph_builder(volgen_graph_t *graph, glusterd_volinfo_t *volinfo,
50dc83
         }
50dc83
     }
50dc83
 
50dc83
-    if (conf->op_version >= GD_OP_VERSION_5_0) {
50dc83
+    if (conf->op_version >= GD_OP_VERSION_5_0 &&
50dc83
+        !dict_get_str_boolean(set_dict, "features.ctime", _gf_false)) {
50dc83
         xl = volgen_graph_add(graph, "features/utime", volname);
50dc83
         if (!xl) {
50dc83
             ret = -1;
50dc83
-- 
50dc83
1.8.3.1
50dc83