17b94a
From c5c6720c5186741a3b01a5ba2b34633fc1a00fc5 Mon Sep 17 00:00:00 2001
17b94a
From: Jiffin Tony Thottan <jthottan@redhat.com>
17b94a
Date: Mon, 30 Apr 2018 12:35:01 +0530
17b94a
Subject: [PATCH 080/124] glusterd/ganesha : Skip non-ganesha nodes properly
17b94a
 for ganesha HA set up
17b94a
17b94a
Label: DOWNSTREAM ONLY
17b94a
17b94a
Upstream reference:
17b94a
>Patch unlink https://review.gluster.org/#/c/19949/
17b94a
>Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
17b94a
>BUG: 1573078
17b94a
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
17b94a
17b94a
Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
17b94a
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
17b94a
Reviewed-on: https://code.engineering.redhat.com/gerrit/167165
17b94a
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
17b94a
Tested-by: RHGS Build Bot <nigelb@redhat.com>
17b94a
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
17b94a
---
17b94a
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 23 +++++++++++++----------
17b94a
 1 file changed, 13 insertions(+), 10 deletions(-)
17b94a
17b94a
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
17b94a
index ff36476..d882105 100644
17b94a
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
17b94a
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
17b94a
@@ -842,17 +842,20 @@ static int
17b94a
 pre_setup(gf_boolean_t run_setup, char **op_errstr)
17b94a
 {
17b94a
     int ret = 0;
17b94a
-
17b94a
-    if (check_host_list()) {
17b94a
-        ret = setup_cluster(run_setup);
17b94a
-        if (ret == -1)
17b94a
+    if (run_setup) {
17b94a
+        if (!check_host_list()) {
17b94a
             gf_asprintf(op_errstr,
17b94a
-                        "Failed to set up HA "
17b94a
-                        "config for NFS-Ganesha. "
17b94a
-                        "Please check the log file for details");
17b94a
-    } else
17b94a
-        ret = -1;
17b94a
-
17b94a
+                        "Running nfs-ganesha setup command "
17b94a
+                        "from node which is not part of ganesha cluster");
17b94a
+            return -1;
17b94a
+        }
17b94a
+    }
17b94a
+    ret = setup_cluster(run_setup);
17b94a
+    if (ret == -1)
17b94a
+        gf_asprintf(op_errstr,
17b94a
+                    "Failed to set up HA "
17b94a
+                    "config for NFS-Ganesha. "
17b94a
+                    "Please check the log file for details");
17b94a
     return ret;
17b94a
 }
17b94a
 
17b94a
-- 
17b94a
1.8.3.1
17b94a