e3c68b
From c5c6720c5186741a3b01a5ba2b34633fc1a00fc5 Mon Sep 17 00:00:00 2001
e3c68b
From: Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
Date: Mon, 30 Apr 2018 12:35:01 +0530
e3c68b
Subject: [PATCH 080/124] glusterd/ganesha : Skip non-ganesha nodes properly
e3c68b
 for ganesha HA set up
e3c68b
e3c68b
Label: DOWNSTREAM ONLY
e3c68b
e3c68b
Upstream reference:
e3c68b
>Patch unlink https://review.gluster.org/#/c/19949/
e3c68b
>Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
e3c68b
>BUG: 1573078
e3c68b
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
e3c68b
Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
e3c68b
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
Reviewed-on: https://code.engineering.redhat.com/gerrit/167165
e3c68b
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
e3c68b
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e3c68b
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
e3c68b
---
e3c68b
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 23 +++++++++++++----------
e3c68b
 1 file changed, 13 insertions(+), 10 deletions(-)
e3c68b
e3c68b
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e3c68b
index ff36476..d882105 100644
e3c68b
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e3c68b
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e3c68b
@@ -842,17 +842,20 @@ static int
e3c68b
 pre_setup(gf_boolean_t run_setup, char **op_errstr)
e3c68b
 {
e3c68b
     int ret = 0;
e3c68b
-
e3c68b
-    if (check_host_list()) {
e3c68b
-        ret = setup_cluster(run_setup);
e3c68b
-        if (ret == -1)
e3c68b
+    if (run_setup) {
e3c68b
+        if (!check_host_list()) {
e3c68b
             gf_asprintf(op_errstr,
e3c68b
-                        "Failed to set up HA "
e3c68b
-                        "config for NFS-Ganesha. "
e3c68b
-                        "Please check the log file for details");
e3c68b
-    } else
e3c68b
-        ret = -1;
e3c68b
-
e3c68b
+                        "Running nfs-ganesha setup command "
e3c68b
+                        "from node which is not part of ganesha cluster");
e3c68b
+            return -1;
e3c68b
+        }
e3c68b
+    }
e3c68b
+    ret = setup_cluster(run_setup);
e3c68b
+    if (ret == -1)
e3c68b
+        gf_asprintf(op_errstr,
e3c68b
+                    "Failed to set up HA "
e3c68b
+                    "config for NFS-Ganesha. "
e3c68b
+                    "Please check the log file for details");
e3c68b
     return ret;
e3c68b
 }
e3c68b
 
e3c68b
-- 
e3c68b
1.8.3.1
e3c68b