74b1de
From c5c6720c5186741a3b01a5ba2b34633fc1a00fc5 Mon Sep 17 00:00:00 2001
74b1de
From: Jiffin Tony Thottan <jthottan@redhat.com>
74b1de
Date: Mon, 30 Apr 2018 12:35:01 +0530
74b1de
Subject: [PATCH 080/124] glusterd/ganesha : Skip non-ganesha nodes properly
74b1de
 for ganesha HA set up
74b1de
74b1de
Label: DOWNSTREAM ONLY
74b1de
74b1de
Upstream reference:
74b1de
>Patch unlink https://review.gluster.org/#/c/19949/
74b1de
>Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
74b1de
>BUG: 1573078
74b1de
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
74b1de
74b1de
Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
74b1de
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/167165
74b1de
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
74b1de
---
74b1de
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 23 +++++++++++++----------
74b1de
 1 file changed, 13 insertions(+), 10 deletions(-)
74b1de
74b1de
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
74b1de
index ff36476..d882105 100644
74b1de
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
74b1de
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
74b1de
@@ -842,17 +842,20 @@ static int
74b1de
 pre_setup(gf_boolean_t run_setup, char **op_errstr)
74b1de
 {
74b1de
     int ret = 0;
74b1de
-
74b1de
-    if (check_host_list()) {
74b1de
-        ret = setup_cluster(run_setup);
74b1de
-        if (ret == -1)
74b1de
+    if (run_setup) {
74b1de
+        if (!check_host_list()) {
74b1de
             gf_asprintf(op_errstr,
74b1de
-                        "Failed to set up HA "
74b1de
-                        "config for NFS-Ganesha. "
74b1de
-                        "Please check the log file for details");
74b1de
-    } else
74b1de
-        ret = -1;
74b1de
-
74b1de
+                        "Running nfs-ganesha setup command "
74b1de
+                        "from node which is not part of ganesha cluster");
74b1de
+            return -1;
74b1de
+        }
74b1de
+    }
74b1de
+    ret = setup_cluster(run_setup);
74b1de
+    if (ret == -1)
74b1de
+        gf_asprintf(op_errstr,
74b1de
+                    "Failed to set up HA "
74b1de
+                    "config for NFS-Ganesha. "
74b1de
+                    "Please check the log file for details");
74b1de
     return ret;
74b1de
 }
74b1de
 
74b1de
-- 
74b1de
1.8.3.1
74b1de