50dc83
From c5c6720c5186741a3b01a5ba2b34633fc1a00fc5 Mon Sep 17 00:00:00 2001
50dc83
From: Jiffin Tony Thottan <jthottan@redhat.com>
50dc83
Date: Mon, 30 Apr 2018 12:35:01 +0530
50dc83
Subject: [PATCH 080/124] glusterd/ganesha : Skip non-ganesha nodes properly
50dc83
 for ganesha HA set up
50dc83
50dc83
Label: DOWNSTREAM ONLY
50dc83
50dc83
Upstream reference:
50dc83
>Patch unlink https://review.gluster.org/#/c/19949/
50dc83
>Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
50dc83
>BUG: 1573078
50dc83
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
50dc83
50dc83
Change-Id: Iff7bc3ead43e97847219c5a5cc8b967bf0967903
50dc83
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
50dc83
Reviewed-on: https://code.engineering.redhat.com/gerrit/167165
50dc83
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
50dc83
Tested-by: RHGS Build Bot <nigelb@redhat.com>
50dc83
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
50dc83
---
50dc83
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 23 +++++++++++++----------
50dc83
 1 file changed, 13 insertions(+), 10 deletions(-)
50dc83
50dc83
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
50dc83
index ff36476..d882105 100644
50dc83
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
50dc83
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
50dc83
@@ -842,17 +842,20 @@ static int
50dc83
 pre_setup(gf_boolean_t run_setup, char **op_errstr)
50dc83
 {
50dc83
     int ret = 0;
50dc83
-
50dc83
-    if (check_host_list()) {
50dc83
-        ret = setup_cluster(run_setup);
50dc83
-        if (ret == -1)
50dc83
+    if (run_setup) {
50dc83
+        if (!check_host_list()) {
50dc83
             gf_asprintf(op_errstr,
50dc83
-                        "Failed to set up HA "
50dc83
-                        "config for NFS-Ganesha. "
50dc83
-                        "Please check the log file for details");
50dc83
-    } else
50dc83
-        ret = -1;
50dc83
-
50dc83
+                        "Running nfs-ganesha setup command "
50dc83
+                        "from node which is not part of ganesha cluster");
50dc83
+            return -1;
50dc83
+        }
50dc83
+    }
50dc83
+    ret = setup_cluster(run_setup);
50dc83
+    if (ret == -1)
50dc83
+        gf_asprintf(op_errstr,
50dc83
+                    "Failed to set up HA "
50dc83
+                    "config for NFS-Ganesha. "
50dc83
+                    "Please check the log file for details");
50dc83
     return ret;
50dc83
 }
50dc83
 
50dc83
-- 
50dc83
1.8.3.1
50dc83