233933
From d91eadbbb3e2d02e7297214da394b0e232544386 Mon Sep 17 00:00:00 2001
233933
From: Jiffin Tony Thottan <jthottan@redhat.com>
233933
Date: Tue, 2 May 2017 14:06:00 +0530
233933
Subject: [PATCH 066/124] glusterd/ganesha : add proper NULL check in
233933
 manage_export_config
233933
233933
Label: DOWNSTREAM ONLY
233933
233933
Change-Id: I872b2b6b027f04e61f60ad85588f50e1ef2f988c
233933
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
233933
Reviewed-on: https://review.gluster.org/17150
233933
Smoke: Gluster Build System <jenkins@build.gluster.org>
233933
Reviewed-by: soumya k <skoduri@redhat.com>
233933
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
233933
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
233933
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
233933
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
233933
Reviewed-on: https://code.engineering.redhat.com/gerrit/167151
233933
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
233933
Tested-by: RHGS Build Bot <nigelb@redhat.com>
233933
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
233933
---
233933
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 2 +-
233933
 1 file changed, 1 insertion(+), 1 deletion(-)
233933
233933
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
233933
index d9fdfc6..fe0bffc 100644
233933
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
233933
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
233933
@@ -435,7 +435,7 @@ manage_export_config(char *volname, char *value, char **op_errstr)
233933
                     CONFDIR, value, volname, NULL);
233933
     ret = runner_run(&runner);
233933
 
233933
-    if (ret && !(*op_errstr))
233933
+    if (ret && op_errstr)
233933
         gf_asprintf(op_errstr,
233933
                     "Failed to create"
233933
                     " NFS-Ganesha export config file.");
233933
-- 
233933
1.8.3.1
233933