e3c68b
From 37bf4daca164cfcb260760ee2fd25d66f920dc7f Mon Sep 17 00:00:00 2001
e3c68b
From: Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
Date: Wed, 22 Feb 2017 18:26:30 +0530
e3c68b
Subject: [PATCH 064/124] glusterd/ganesha : return proper value in pre_setup()
e3c68b
e3c68b
Label: DOWNSTREAM ONLY
e3c68b
e3c68b
Change-Id: I6f7ce82488904c7d418ee078162f26f1ec81e9d9
e3c68b
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
Reviewed-on: https://review.gluster.org/16733
e3c68b
Smoke: Gluster Build System <jenkins@build.gluster.org>
e3c68b
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
e3c68b
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
e3c68b
Tested-by: Raghavendra Talur <rtalur@redhat.com>
e3c68b
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
e3c68b
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
e3c68b
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
e3c68b
Reviewed-on: https://code.engineering.redhat.com/gerrit/167149
e3c68b
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
e3c68b
Tested-by: RHGS Build Bot <nigelb@redhat.com>
e3c68b
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
e3c68b
---
e3c68b
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 7 +++----
e3c68b
 1 file changed, 3 insertions(+), 4 deletions(-)
e3c68b
e3c68b
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e3c68b
index 1c2ba7a..d9fdfc6 100644
e3c68b
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e3c68b
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e3c68b
@@ -843,16 +843,15 @@ pre_setup(gf_boolean_t run_setup, char **op_errstr)
e3c68b
 {
e3c68b
     int ret = 0;
e3c68b
 
e3c68b
-    ret = check_host_list();
e3c68b
-
e3c68b
-    if (ret) {
e3c68b
+    if (check_host_list()) {
e3c68b
         ret = setup_cluster(run_setup);
e3c68b
         if (ret == -1)
e3c68b
             gf_asprintf(op_errstr,
e3c68b
                         "Failed to set up HA "
e3c68b
                         "config for NFS-Ganesha. "
e3c68b
                         "Please check the log file for details");
e3c68b
-    }
e3c68b
+    } else
e3c68b
+        ret = -1;
e3c68b
 
e3c68b
     return ret;
e3c68b
 }
e3c68b
-- 
e3c68b
1.8.3.1
e3c68b