256ebe
From 37bf4daca164cfcb260760ee2fd25d66f920dc7f Mon Sep 17 00:00:00 2001
256ebe
From: Jiffin Tony Thottan <jthottan@redhat.com>
256ebe
Date: Wed, 22 Feb 2017 18:26:30 +0530
256ebe
Subject: [PATCH 064/124] glusterd/ganesha : return proper value in pre_setup()
256ebe
256ebe
Label: DOWNSTREAM ONLY
256ebe
256ebe
Change-Id: I6f7ce82488904c7d418ee078162f26f1ec81e9d9
256ebe
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
256ebe
Reviewed-on: https://review.gluster.org/16733
256ebe
Smoke: Gluster Build System <jenkins@build.gluster.org>
256ebe
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
256ebe
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
256ebe
Tested-by: Raghavendra Talur <rtalur@redhat.com>
256ebe
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
256ebe
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
256ebe
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
256ebe
Reviewed-on: https://code.engineering.redhat.com/gerrit/167149
256ebe
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
256ebe
Tested-by: RHGS Build Bot <nigelb@redhat.com>
256ebe
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
256ebe
---
256ebe
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 7 +++----
256ebe
 1 file changed, 3 insertions(+), 4 deletions(-)
256ebe
256ebe
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
256ebe
index 1c2ba7a..d9fdfc6 100644
256ebe
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
256ebe
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
256ebe
@@ -843,16 +843,15 @@ pre_setup(gf_boolean_t run_setup, char **op_errstr)
256ebe
 {
256ebe
     int ret = 0;
256ebe
 
256ebe
-    ret = check_host_list();
256ebe
-
256ebe
-    if (ret) {
256ebe
+    if (check_host_list()) {
256ebe
         ret = setup_cluster(run_setup);
256ebe
         if (ret == -1)
256ebe
             gf_asprintf(op_errstr,
256ebe
                         "Failed to set up HA "
256ebe
                         "config for NFS-Ganesha. "
256ebe
                         "Please check the log file for details");
256ebe
-    }
256ebe
+    } else
256ebe
+        ret = -1;
256ebe
 
256ebe
     return ret;
256ebe
 }
256ebe
-- 
256ebe
1.8.3.1
256ebe