74b1de
From 37bf4daca164cfcb260760ee2fd25d66f920dc7f Mon Sep 17 00:00:00 2001
d1681e
From: Jiffin Tony Thottan <jthottan@redhat.com>
d1681e
Date: Wed, 22 Feb 2017 18:26:30 +0530
74b1de
Subject: [PATCH 064/124] glusterd/ganesha : return proper value in pre_setup()
74b1de
74b1de
Label: DOWNSTREAM ONLY
d1681e
d1681e
Change-Id: I6f7ce82488904c7d418ee078162f26f1ec81e9d9
d1681e
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
d1681e
Reviewed-on: https://review.gluster.org/16733
d1681e
Smoke: Gluster Build System <jenkins@build.gluster.org>
d1681e
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
d1681e
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
d1681e
Tested-by: Raghavendra Talur <rtalur@redhat.com>
d1681e
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
d1681e
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
74b1de
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
74b1de
Reviewed-on: https://code.engineering.redhat.com/gerrit/167149
74b1de
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
74b1de
Tested-by: RHGS Build Bot <nigelb@redhat.com>
74b1de
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
d1681e
---
d1681e
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 7 +++----
d1681e
 1 file changed, 3 insertions(+), 4 deletions(-)
d1681e
d1681e
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
74b1de
index 1c2ba7a..d9fdfc6 100644
d1681e
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
d1681e
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
74b1de
@@ -843,16 +843,15 @@ pre_setup(gf_boolean_t run_setup, char **op_errstr)
d1681e
 {
74b1de
     int ret = 0;
d1681e
 
74b1de
-    ret = check_host_list();
d1681e
-
74b1de
-    if (ret) {
74b1de
+    if (check_host_list()) {
74b1de
         ret = setup_cluster(run_setup);
74b1de
         if (ret == -1)
74b1de
             gf_asprintf(op_errstr,
74b1de
                         "Failed to set up HA "
74b1de
                         "config for NFS-Ganesha. "
74b1de
                         "Please check the log file for details");
74b1de
-    }
74b1de
+    } else
74b1de
+        ret = -1;
d1681e
 
74b1de
     return ret;
d1681e
 }
d1681e
-- 
d1681e
1.8.3.1
d1681e