a3470f
From 05c63817ac715fdcf9065568d796b93d97c0be7f Mon Sep 17 00:00:00 2001
a3470f
From: Jiffin Tony Thottan <jthottan@redhat.com>
a3470f
Date: Tue, 2 May 2017 14:06:00 +0530
a3470f
Subject: [PATCH 62/74] glusterd/ganesha : add proper NULL check in
a3470f
 manage_export_config
a3470f
a3470f
Change-Id: I872b2b6b027f04e61f60ad85588f50e1ef2f988c
a3470f
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
a3470f
Reviewed-on: https://review.gluster.org/17150
a3470f
Smoke: Gluster Build System <jenkins@build.gluster.org>
a3470f
Reviewed-by: soumya k <skoduri@redhat.com>
a3470f
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
a3470f
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
a3470f
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
a3470f
---
a3470f
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 2 +-
a3470f
 1 file changed, 1 insertion(+), 1 deletion(-)
a3470f
a3470f
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
a3470f
index cd591df..7ba25ee 100644
a3470f
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
a3470f
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
a3470f
@@ -454,7 +454,7 @@ manage_export_config (char *volname, char *value, char **op_errstr)
a3470f
                          CONFDIR, value, volname, NULL);
a3470f
         ret = runner_run(&runner);
a3470f
 
a3470f
-        if (ret && !(*op_errstr))
a3470f
+        if (ret && op_errstr)
a3470f
                 gf_asprintf (op_errstr, "Failed to create"
a3470f
                             " NFS-Ganesha export config file.");
a3470f
 
a3470f
-- 
a3470f
1.8.3.1
a3470f