d1681e
From 0ae0579f3c92ecf6270eea308905518ce75efb7b Mon Sep 17 00:00:00 2001
d1681e
From: Jiffin Tony Thottan <jthottan@redhat.com>
d1681e
Date: Wed, 22 Feb 2017 18:26:30 +0530
d1681e
Subject: [PATCH 60/74] glusterd/ganesha : return proper value in pre_setup()
d1681e
d1681e
Change-Id: I6f7ce82488904c7d418ee078162f26f1ec81e9d9
d1681e
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
d1681e
Reviewed-on: https://review.gluster.org/16733
d1681e
Smoke: Gluster Build System <jenkins@build.gluster.org>
d1681e
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
d1681e
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
d1681e
Tested-by: Raghavendra Talur <rtalur@redhat.com>
d1681e
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
d1681e
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
d1681e
---
d1681e
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 7 +++----
d1681e
 1 file changed, 3 insertions(+), 4 deletions(-)
d1681e
d1681e
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
d1681e
index 5d6144a..cd591df 100644
d1681e
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
d1681e
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
d1681e
@@ -834,15 +834,14 @@ pre_setup (gf_boolean_t run_setup, char **op_errstr)
d1681e
 {
d1681e
         int    ret = 0;
d1681e
 
d1681e
-        ret = check_host_list();
d1681e
-
d1681e
-        if (ret) {
d1681e
+        if (check_host_list()) {
d1681e
                 ret = setup_cluster(run_setup);
d1681e
                 if (ret == -1)
d1681e
                         gf_asprintf (op_errstr, "Failed to set up HA "
d1681e
                                      "config for NFS-Ganesha. "
d1681e
                                      "Please check the log file for details");
d1681e
-        }
d1681e
+        } else
d1681e
+		ret = -1;
d1681e
 
d1681e
         return ret;
d1681e
 }
d1681e
-- 
d1681e
1.8.3.1
d1681e