e7a346
From 0ae0579f3c92ecf6270eea308905518ce75efb7b Mon Sep 17 00:00:00 2001
e7a346
From: Jiffin Tony Thottan <jthottan@redhat.com>
e7a346
Date: Wed, 22 Feb 2017 18:26:30 +0530
e7a346
Subject: [PATCH 60/74] glusterd/ganesha : return proper value in pre_setup()
e7a346
e7a346
Change-Id: I6f7ce82488904c7d418ee078162f26f1ec81e9d9
e7a346
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
e7a346
Reviewed-on: https://review.gluster.org/16733
e7a346
Smoke: Gluster Build System <jenkins@build.gluster.org>
e7a346
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
e7a346
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
e7a346
Tested-by: Raghavendra Talur <rtalur@redhat.com>
e7a346
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
e7a346
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
e7a346
---
e7a346
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 7 +++----
e7a346
 1 file changed, 3 insertions(+), 4 deletions(-)
e7a346
e7a346
diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e7a346
index 5d6144a..cd591df 100644
e7a346
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e7a346
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
e7a346
@@ -834,15 +834,14 @@ pre_setup (gf_boolean_t run_setup, char **op_errstr)
e7a346
 {
e7a346
         int    ret = 0;
e7a346
 
e7a346
-        ret = check_host_list();
e7a346
-
e7a346
-        if (ret) {
e7a346
+        if (check_host_list()) {
e7a346
                 ret = setup_cluster(run_setup);
e7a346
                 if (ret == -1)
e7a346
                         gf_asprintf (op_errstr, "Failed to set up HA "
e7a346
                                      "config for NFS-Ganesha. "
e7a346
                                      "Please check the log file for details");
e7a346
-        }
e7a346
+        } else
e7a346
+		ret = -1;
e7a346
 
e7a346
         return ret;
e7a346
 }
e7a346
-- 
e7a346
1.8.3.1
e7a346