|
 |
256ebe |
From 9b58731c83bc1ee9c5f2a3cd58a8f845cf09ee82 Mon Sep 17 00:00:00 2001
|
|
|
256ebe |
From: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
|
|
256ebe |
Date: Mon, 21 Mar 2016 13:54:19 +0530
|
|
|
256ebe |
Subject: [PATCH 03/52] rpc: set bind-insecure to off by default
|
|
|
256ebe |
|
|
|
256ebe |
commit 243a5b429f225acb8e7132264fe0a0835ff013d5 turn's 'ON'
|
|
|
256ebe |
allow-insecure and bind-insecure by default.
|
|
|
256ebe |
|
|
|
256ebe |
Problem:
|
|
|
256ebe |
Now with newer versions we have bind-insecure 'ON' by default.
|
|
|
256ebe |
So, while upgrading subset of nodes from a trusted storage pool,
|
|
|
256ebe |
nodes which have older versions of glusterfs will expect
|
|
|
256ebe |
connection from secure ports only (since they still have
|
|
|
256ebe |
bind-insecure off) thus they reject connection from upgraded
|
|
|
256ebe |
nodes which now have insecure ports.
|
|
|
256ebe |
|
|
|
256ebe |
Hence we will run into connection issues between peers.
|
|
|
256ebe |
|
|
|
256ebe |
Solution:
|
|
|
256ebe |
This patch will turn bind-insecure 'OFF' by default to avoid
|
|
|
256ebe |
problem explained above.
|
|
|
256ebe |
|
|
|
256ebe |
Label: DOWNSTREAM ONLY
|
|
|
256ebe |
|
|
|
256ebe |
Change-Id: Id7a19b4872399d3b019243b0857c9c7af75472f7
|
|
|
256ebe |
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
|
|
256ebe |
Reviewed-on: https://code.engineering.redhat.com/gerrit/70313
|
|
|
256ebe |
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
|
|
|
256ebe |
Tested-by: Atin Mukherjee <amukherj@redhat.com>
|
|
|
256ebe |
---
|
|
|
256ebe |
rpc/rpc-lib/src/rpc-transport.c | 4 ++--
|
|
|
256ebe |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
256ebe |
|
|
|
256ebe |
diff --git a/rpc/rpc-lib/src/rpc-transport.c b/rpc/rpc-lib/src/rpc-transport.c
|
|
|
256ebe |
index f9cbdf1..4beaaf9 100644
|
|
|
256ebe |
--- a/rpc/rpc-lib/src/rpc-transport.c
|
|
|
256ebe |
+++ b/rpc/rpc-lib/src/rpc-transport.c
|
|
|
256ebe |
@@ -269,8 +269,8 @@ rpc_transport_load(glusterfs_ctx_t *ctx, dict_t *options, char *trans_name)
|
|
|
256ebe |
else
|
|
|
256ebe |
trans->bind_insecure = 0;
|
|
|
256ebe |
} else {
|
|
|
256ebe |
- /* By default allow bind insecure */
|
|
|
256ebe |
- trans->bind_insecure = 1;
|
|
|
256ebe |
+ /* Turning off bind insecure by default*/
|
|
|
256ebe |
+ trans->bind_insecure = 0;
|
|
|
256ebe |
}
|
|
|
256ebe |
|
|
|
256ebe |
ret = dict_get_str(options, "transport-type", &type);
|
|
|
256ebe |
--
|
|
|
256ebe |
1.8.3.1
|
|
|
256ebe |
|