|
 |
190885 |
From d867c25060d86f0223347734ef5005ad0792554c Mon Sep 17 00:00:00 2001
|
|
|
190885 |
From: Fangrui Song <maskray@google.com>
|
|
|
190885 |
Date: Tue, 2 Nov 2021 20:59:52 -0700
|
|
|
190885 |
Subject: [PATCH] x86-64: Replace movzx with movzbl
|
|
|
190885 |
|
|
|
190885 |
Clang cannot assemble movzx in the AT&T dialect mode.
|
|
|
190885 |
|
|
|
190885 |
../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction
|
|
|
190885 |
movzx (%rsi), %ecx
|
|
|
190885 |
^~~~
|
|
|
190885 |
|
|
|
190885 |
Change movzx to movzbl, which follows the AT&T dialect and is used
|
|
|
190885 |
elsewhere in the file.
|
|
|
190885 |
|
|
|
190885 |
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
|
|
|
190885 |
(cherry picked from commit 6720d36b6623c5e48c070d86acf61198b33e144e)
|
|
|
190885 |
---
|
|
|
190885 |
sysdeps/x86_64/multiarch/strcmp-sse42.S | 4 ++--
|
|
|
190885 |
sysdeps/x86_64/strcmp.S | 4 ++--
|
|
|
190885 |
2 files changed, 4 insertions(+), 4 deletions(-)
|
|
|
190885 |
|
|
|
190885 |
diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
|
|
|
190885 |
index a1ebea46..d8fdeb3a 100644
|
|
|
190885 |
--- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
|
|
|
190885 |
+++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
|
|
|
190885 |
@@ -1771,8 +1771,8 @@ LABEL(strcmp_exitz):
|
|
|
190885 |
.p2align 4
|
|
|
190885 |
// XXX Same as code above
|
|
|
190885 |
LABEL(Byte0):
|
|
|
190885 |
- movzx (%rsi), %ecx
|
|
|
190885 |
- movzx (%rdi), %eax
|
|
|
190885 |
+ movzbl (%rsi), %ecx
|
|
|
190885 |
+ movzbl (%rdi), %eax
|
|
|
190885 |
|
|
|
190885 |
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
|
|
|
190885 |
leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
|
|
|
190885 |
diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S
|
|
|
190885 |
index f47c8ad4..aa6df898 100644
|
|
|
190885 |
--- a/sysdeps/x86_64/strcmp.S
|
|
|
190885 |
+++ b/sysdeps/x86_64/strcmp.S
|
|
|
190885 |
@@ -2232,8 +2232,8 @@ LABEL(strcmp_exitz):
|
|
|
190885 |
|
|
|
190885 |
.p2align 4
|
|
|
190885 |
LABEL(Byte0):
|
|
|
190885 |
- movzx (%rsi), %ecx
|
|
|
190885 |
- movzx (%rdi), %eax
|
|
|
190885 |
+ movzbl (%rsi), %ecx
|
|
|
190885 |
+ movzbl (%rdi), %eax
|
|
|
190885 |
|
|
|
190885 |
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
|
|
|
190885 |
leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
|
|
|
190885 |
--
|
|
|
190885 |
GitLab
|
|
|
190885 |
|