93dc2d
commit b50d5b746cc0af5ad52164dcb0d3628f08b05a0d
93dc2d
Author: Noah Goldstein <goldstein.w.n@gmail.com>
93dc2d
Date:   Sun Jan 9 16:02:21 2022 -0600
93dc2d
93dc2d
    x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755]
93dc2d
    
93dc2d
    Fixes [BZ# 28755] for wcsncmp by redirecting length >= 2^56 to
93dc2d
    __wcscmp_avx2. For x86_64 this covers the entire address range so any
93dc2d
    length larger could not possibly be used to bound `s1` or `s2`.
93dc2d
    
93dc2d
    test-strcmp, test-strncmp, test-wcscmp, and test-wcsncmp all pass.
93dc2d
    
93dc2d
    Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
93dc2d
    (cherry picked from commit ddf0992cf57a93200e0c782e2a94d0733a5a0b87)
93dc2d
93dc2d
diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
93dc2d
index 40333010a65650f9..3dfcb1bf803cf9ec 100644
93dc2d
--- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
93dc2d
+++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
93dc2d
@@ -87,6 +87,16 @@ ENTRY (STRCMP)
93dc2d
 	je	L(char0)
93dc2d
 	jb	L(zero)
93dc2d
 #  ifdef USE_AS_WCSCMP
93dc2d
+#  ifndef __ILP32__
93dc2d
+	movq	%rdx, %rcx
93dc2d
+	/* Check if length could overflow when multiplied by
93dc2d
+	   sizeof(wchar_t). Checking top 8 bits will cover all potential
93dc2d
+	   overflow cases as well as redirect cases where its impossible to
93dc2d
+	   length to bound a valid memory region. In these cases just use
93dc2d
+	   'wcscmp'.  */
93dc2d
+	shrq	$56, %rcx
93dc2d
+	jnz	__wcscmp_avx2
93dc2d
+#  endif
93dc2d
 	/* Convert units: from wide to byte char.  */
93dc2d
 	shl	$2, %RDX_LP
93dc2d
 #  endif