94084c
commit b50d5b746cc0af5ad52164dcb0d3628f08b05a0d
94084c
Author: Noah Goldstein <goldstein.w.n@gmail.com>
94084c
Date:   Sun Jan 9 16:02:21 2022 -0600
94084c
94084c
    x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755]
94084c
    
94084c
    Fixes [BZ# 28755] for wcsncmp by redirecting length >= 2^56 to
94084c
    __wcscmp_avx2. For x86_64 this covers the entire address range so any
94084c
    length larger could not possibly be used to bound `s1` or `s2`.
94084c
    
94084c
    test-strcmp, test-strncmp, test-wcscmp, and test-wcsncmp all pass.
94084c
    
94084c
    Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
94084c
    (cherry picked from commit ddf0992cf57a93200e0c782e2a94d0733a5a0b87)
94084c
94084c
diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
94084c
index 40333010a65650f9..3dfcb1bf803cf9ec 100644
94084c
--- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
94084c
+++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
94084c
@@ -87,6 +87,16 @@ ENTRY (STRCMP)
94084c
 	je	L(char0)
94084c
 	jb	L(zero)
94084c
 #  ifdef USE_AS_WCSCMP
94084c
+#  ifndef __ILP32__
94084c
+	movq	%rdx, %rcx
94084c
+	/* Check if length could overflow when multiplied by
94084c
+	   sizeof(wchar_t). Checking top 8 bits will cover all potential
94084c
+	   overflow cases as well as redirect cases where its impossible to
94084c
+	   length to bound a valid memory region. In these cases just use
94084c
+	   'wcscmp'.  */
94084c
+	shrq	$56, %rcx
94084c
+	jnz	__wcscmp_avx2
94084c
+#  endif
94084c
 	/* Convert units: from wide to byte char.  */
94084c
 	shl	$2, %RDX_LP
94084c
 #  endif