94084c
commit 1d401d1fccb85046402089268b94d86d822070e6
94084c
Author: Aurelien Jarno <aurelien@aurel32.net>
94084c
Date:   Mon Jan 17 19:41:40 2022 +0100
94084c
94084c
    x86: use default cache size if it cannot be determined [BZ #28784]
94084c
    
94084c
    In some cases (e.g QEMU, non-Intel/AMD CPU) the cache information can
94084c
    not be retrieved and the corresponding values are set to 0.
94084c
    
94084c
    Commit 2d651eb9265d ("x86: Move x86 processor cache info to
94084c
    cpu_features") changed the behaviour in such case by defining the
94084c
    __x86_shared_cache_size and __x86_data_cache_size variables to 0 instead
94084c
    of using the default values. This cause an issue with the i686 SSE2
94084c
    optimized bzero/routine which assumes that the cache size is at least
94084c
    128 bytes, and otherwise tries to zero/set the whole address space minus
94084c
    128 bytes.
94084c
    
94084c
    Fix that by restoring the original code to only update
94084c
    __x86_shared_cache_size and __x86_data_cache_size variables if the
94084c
    corresponding cache sizes are not zero.
94084c
    
94084c
    Fixes bug 28784
94084c
    Fixes commit 2d651eb9265d
94084c
    
94084c
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
94084c
    (cherry picked from commit c242fcce06e3102ca663b2f992611d0bda4f2668)
94084c
94084c
diff --git a/sysdeps/x86/cacheinfo.h b/sysdeps/x86/cacheinfo.h
94084c
index 41d2c81369840ada..63f36877e3f35d99 100644
94084c
--- a/sysdeps/x86/cacheinfo.h
94084c
+++ b/sysdeps/x86/cacheinfo.h
94084c
@@ -61,14 +61,20 @@ init_cacheinfo (void)
94084c
   long int data = cpu_features->data_cache_size;
94084c
   /* Round data cache size to multiple of 256 bytes.  */
94084c
   data = data & ~255L;
94084c
-  __x86_data_cache_size_half = data / 2;
94084c
-  __x86_data_cache_size = data;
94084c
+  if (data > 0)
94084c
+    {
94084c
+      __x86_data_cache_size_half = data / 2;
94084c
+      __x86_data_cache_size = data;
94084c
+    }
94084c
 
94084c
   long int shared = cpu_features->shared_cache_size;
94084c
   /* Round shared cache size to multiple of 256 bytes.  */
94084c
   shared = shared & ~255L;
94084c
-  __x86_shared_cache_size_half = shared / 2;
94084c
-  __x86_shared_cache_size = shared;
94084c
+  if (shared > 0)
94084c
+    {
94084c
+      __x86_shared_cache_size_half = shared / 2;
94084c
+      __x86_shared_cache_size = shared;
94084c
+    }
94084c
 
94084c
   __x86_shared_non_temporal_threshold
94084c
     = cpu_features->non_temporal_threshold;