|
 |
6ca6e8 |
commit e3976287b22422787f3cc6fc9adda58304b55bd9
|
|
|
6ca6e8 |
Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
|
|
|
6ca6e8 |
Date: Tue Oct 4 18:40:25 2022 -0400
|
|
|
6ca6e8 |
|
|
|
6ca6e8 |
nscd: Drop local address tuple variable [BZ #29607]
|
|
|
6ca6e8 |
|
|
|
6ca6e8 |
When a request needs to be resent (e.g. due to insufficient buffer
|
|
|
6ca6e8 |
space), the references to subsequent tuples in the local variable are
|
|
|
6ca6e8 |
stale and should not be used. This used to work by accident before, but
|
|
|
6ca6e8 |
since 1d495912a it no longer does. Instead of trying to reset it, just
|
|
|
6ca6e8 |
let gethostbyname4_r write into TUMPBUF6 for us, thus maintaining a
|
|
|
6ca6e8 |
consistent state at all times. This is now consistent with what is done
|
|
|
6ca6e8 |
in gaih_inet for getaddrinfo.
|
|
|
6ca6e8 |
|
|
|
6ca6e8 |
Resolves: BZ #29607
|
|
|
6ca6e8 |
Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com>
|
|
|
6ca6e8 |
Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>
|
|
|
6ca6e8 |
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
|
|
|
6ca6e8 |
(cherry picked from commit 6e33e5c4b73cea7b8aa3de0947123db16200fb65)
|
|
|
6ca6e8 |
|
|
|
6ca6e8 |
diff --git a/nscd/aicache.c b/nscd/aicache.c
|
|
|
6ca6e8 |
index 737ace11cc276021..3b300ad9b7db2297 100644
|
|
|
6ca6e8 |
--- a/nscd/aicache.c
|
|
|
6ca6e8 |
+++ b/nscd/aicache.c
|
|
|
6ca6e8 |
@@ -111,11 +111,10 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req,
|
|
|
6ca6e8 |
"gethostbyname4_r");
|
|
|
6ca6e8 |
if (fct4 != NULL)
|
|
|
6ca6e8 |
{
|
|
|
6ca6e8 |
- struct gaih_addrtuple atmem;
|
|
|
6ca6e8 |
struct gaih_addrtuple *at;
|
|
|
6ca6e8 |
while (1)
|
|
|
6ca6e8 |
{
|
|
|
6ca6e8 |
- at = &atmem;
|
|
|
6ca6e8 |
+ at = NULL;
|
|
|
6ca6e8 |
rc6 = 0;
|
|
|
6ca6e8 |
herrno = 0;
|
|
|
6ca6e8 |
status[1] = DL_CALL_FCT (fct4, (key, &at,
|
|
|
6ca6e8 |
@@ -138,7 +137,7 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req,
|
|
|
6ca6e8 |
goto next_nip;
|
|
|
6ca6e8 |
|
|
|
6ca6e8 |
/* We found the data. Count the addresses and the size. */
|
|
|
6ca6e8 |
- for (const struct gaih_addrtuple *at2 = at = &atmem; at2 != NULL;
|
|
|
6ca6e8 |
+ for (const struct gaih_addrtuple *at2 = at; at2 != NULL;
|
|
|
6ca6e8 |
at2 = at2->next)
|
|
|
6ca6e8 |
{
|
|
|
6ca6e8 |
++naddrs;
|