6ca6e8
commit 43760d33d78f9ea8c8af942b570112ee801b99df
6ca6e8
Author: Jangwoong Kim <6812skiii@gmail.com>
6ca6e8
Date:   Tue Dec 14 21:30:51 2021 +0900
6ca6e8
6ca6e8
    nptl: Effectively skip CAS in spinlock loop
6ca6e8
    
6ca6e8
    The commit:
6ca6e8
    "Add LLL_MUTEX_READ_LOCK [BZ #28537]"
6ca6e8
    SHA1: d672a98a1af106bd68deb15576710cd61363f7a6
6ca6e8
    
6ca6e8
    introduced LLL_MUTEX_READ_LOCK, to skip CAS in spinlock loop
6ca6e8
    if atomic load fails. But, "continue" inside of do-while loop
6ca6e8
    does not skip the evaluation of escape expression, thus CAS
6ca6e8
    is not skipped.
6ca6e8
    
6ca6e8
    Replace do-while with while and skip LLL_MUTEX_TRYLOCK if
6ca6e8
    LLL_MUTEX_READ_LOCK fails.
6ca6e8
    
6ca6e8
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
6ca6e8
    (cherry picked from commit 6b8dbbd03ac88f169b65b5c7d7278576a11d2e44)
6ca6e8
6ca6e8
diff --git a/nptl/pthread_mutex_lock.c b/nptl/pthread_mutex_lock.c
6ca6e8
index 49901ffa0a96d659..bbe754a272b97d91 100644
6ca6e8
--- a/nptl/pthread_mutex_lock.c
6ca6e8
+++ b/nptl/pthread_mutex_lock.c
6ca6e8
@@ -147,10 +147,9 @@ PTHREAD_MUTEX_LOCK (pthread_mutex_t *mutex)
6ca6e8
 		  break;
6ca6e8
 		}
6ca6e8
 	      atomic_spin_nop ();
6ca6e8
-	      if (LLL_MUTEX_READ_LOCK (mutex) != 0)
6ca6e8
-		continue;
6ca6e8
 	    }
6ca6e8
-	  while (LLL_MUTEX_TRYLOCK (mutex) != 0);
6ca6e8
+	  while (LLL_MUTEX_READ_LOCK (mutex) != 0
6ca6e8
+		 || LLL_MUTEX_TRYLOCK (mutex) != 0);
6ca6e8
 
6ca6e8
 	  mutex->__data.__spins += (cnt - mutex->__data.__spins) / 8;
6ca6e8
 	}