08c3a6
commit 368c5c3e001a37571b61ab342f2b654c3d23643d
08c3a6
Author: Sam James <sam@gentoo.org>
08c3a6
Date:   Sun Jun 5 04:57:09 2022 +0100
08c3a6
08c3a6
    nss: add assert to DB_LOOKUP_FCT (BZ #28752)
08c3a6
    
08c3a6
    It's interesting if we have a null action list,
08c3a6
    so an assert is worthwhile.
08c3a6
    
08c3a6
    Suggested-by: DJ Delorie <dj@redhat.com>
08c3a6
    Signed-off-by: Sam James <sam@gentoo.org>
08c3a6
    Reviewed-by: DJ Delorie <dj@redhat.com>
08c3a6
    (cherry picked from commit 3fdf0a205b622e40fa7e3c4ed1e4ed4d5c6c5380)
08c3a6
08c3a6
diff --git a/nss/XXX-lookup.c b/nss/XXX-lookup.c
08c3a6
index dbc87868dd408d9f..343fd9869bd12714 100644
08c3a6
--- a/nss/XXX-lookup.c
08c3a6
+++ b/nss/XXX-lookup.c
08c3a6
@@ -16,6 +16,7 @@
08c3a6
    License along with the GNU C Library; if not, see
08c3a6
    <https://www.gnu.org/licenses/>.  */
08c3a6
 
08c3a6
+#include <assert.h>
08c3a6
 #include "nsswitch.h"
08c3a6
 
08c3a6
 /*******************************************************************\
08c3a6
@@ -55,6 +56,10 @@ DB_LOOKUP_FCT (nss_action_list *ni, const char *fct_name, const char *fct2_name,
08c3a6
 
08c3a6
   *ni = DATABASE_NAME_SYMBOL;
08c3a6
 
08c3a6
+  /* We want to know about it if we've somehow got a NULL action list;
08c3a6
+   in the past, we had bad state if seccomp interfered with setup. */
08c3a6
+  assert(*ni != NULL);
08c3a6
+
08c3a6
   return __nss_lookup (ni, fct_name, fct2_name, fctp);
08c3a6
 }
08c3a6
 libc_hidden_def (DB_LOOKUP_FCT)