08c3a6
commit 88a8637cb4658cd91a002659db05867716b88b36
08c3a6
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
08c3a6
Date:   Wed Apr 27 13:40:30 2022 -0300
08c3a6
08c3a6
    linux: Fix fchmodat with AT_SYMLINK_NOFOLLOW for 64 bit time_t (BZ#29097)
08c3a6
    
08c3a6
    The AT_SYMLINK_NOFOLLOW emulation ues the default 32 bit stat internal
08c3a6
    calls, which fails with EOVERFLOW if the file constains timestamps
08c3a6
    beyond 2038.
08c3a6
    
08c3a6
    Checked on i686-linux-gnu.
08c3a6
    
08c3a6
    (cherry picked from commit 118a2aee07f64d605b6668cbe195c1f44eac6be6)
08c3a6
08c3a6
diff --git a/io/Makefile b/io/Makefile
08c3a6
index 9871ecbc74020a6d..01968b81042e01e4 100644
08c3a6
--- a/io/Makefile
08c3a6
+++ b/io/Makefile
08c3a6
@@ -81,16 +81,17 @@ tests		:= test-utime test-stat test-stat2 test-lfs tst-getcwd \
08c3a6
 		   tst-closefrom \
08c3a6
 
08c3a6
 tests-time64 := \
08c3a6
+  tst-fcntl-time64 \
08c3a6
+  tst-fts-time64 \
08c3a6
   tst-futimens-time64 \
08c3a6
   tst-futimes-time64\
08c3a6
-  tst-fts-time64 \
08c3a6
+  tst-futimesat-time64 \
08c3a6
+  tst-lchmod-time64 \
08c3a6
   tst-lutimes-time64 \
08c3a6
   tst-stat-time64 \
08c3a6
-  tst-futimesat-time64 \
08c3a6
   tst-utime-time64 \
08c3a6
   tst-utimensat-time64 \
08c3a6
   tst-utimes-time64 \
08c3a6
-  tst-fcntl-time64 \
08c3a6
   # tests-time64
08c3a6
 
08c3a6
 # Likewise for statx, but we do not need static linking here.
08c3a6
@@ -134,6 +135,7 @@ CFLAGS-close.c += -fexceptions -fasynchronous-unwind-tables
08c3a6
 
08c3a6
 CFLAGS-test-stat.c += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE
08c3a6
 CFLAGS-test-lfs.c += -D_LARGEFILE64_SOURCE
08c3a6
+CFLAGS-tst-lchmod.c += -D_FILE_OFFSET_BITS=64
08c3a6
 
08c3a6
 test-stat2-ARGS = Makefile . $(objpfx)test-stat2
08c3a6
 
08c3a6
diff --git a/io/tst-lchmod-time64.c b/io/tst-lchmod-time64.c
08c3a6
new file mode 100644
08c3a6
index 0000000000000000..f2b7cc9d358f2a77
08c3a6
--- /dev/null
08c3a6
+++ b/io/tst-lchmod-time64.c
08c3a6
@@ -0,0 +1,2 @@
08c3a6
+#define CHECK_TIME64
08c3a6
+#include "tst-lchmod.c"
08c3a6
diff --git a/io/tst-lchmod.c b/io/tst-lchmod.c
08c3a6
index 0fe98e01b74b713d..472766b186975922 100644
08c3a6
--- a/io/tst-lchmod.c
08c3a6
+++ b/io/tst-lchmod.c
08c3a6
@@ -66,10 +66,27 @@ select_path (bool do_relative_path, const char *full_path, const char *relative_
08c3a6
     return full_path;
08c3a6
 }
08c3a6
 
08c3a6
+static void
08c3a6
+update_file_time_to_y2038 (const char *fname, int flags)
08c3a6
+{
08c3a6
+#ifdef CHECK_TIME64
08c3a6
+  /* Y2038 threshold plus 1 second.  */
08c3a6
+  const struct timespec ts[] = { { 0x80000001LL, 0}, { 0x80000001LL } };
08c3a6
+  TEST_VERIFY_EXIT (utimensat (AT_FDCWD, fname, ts, flags) == 0);
08c3a6
+#endif
08c3a6
+}
08c3a6
+
08c3a6
 static void
08c3a6
 test_1 (bool do_relative_path, int (*chmod_func) (int fd, const char *, mode_t, int))
08c3a6
 {
08c3a6
   char *tempdir = support_create_temp_directory ("tst-lchmod-");
08c3a6
+#ifdef CHECK_TIME64
08c3a6
+  if (!support_path_support_time64 (tempdir))
08c3a6
+    {
08c3a6
+      puts ("info: test skipped, filesystem does not support 64 bit time_t");
08c3a6
+      return;
08c3a6
+    }
08c3a6
+#endif
08c3a6
 
08c3a6
   char *path_dangling = xasprintf ("%s/dangling", tempdir);
08c3a6
   char *path_file = xasprintf ("%s/file", tempdir);
08c3a6
@@ -93,9 +110,12 @@ test_1 (bool do_relative_path, int (*chmod_func) (int fd, const char *, mode_t,
08c3a6
   xsymlink ("loop", path_loop);
08c3a6
   xsymlink ("target-does-not-exist", path_dangling);
08c3a6
 
08c3a6
+  update_file_time_to_y2038 (path_file, 0);
08c3a6
+  update_file_time_to_y2038 (path_to_file, AT_SYMLINK_NOFOLLOW);
08c3a6
+
08c3a6
   /* Check that the modes do not collide with what we will use in the
08c3a6
      test.  */
08c3a6
-  struct stat64 st;
08c3a6
+  struct stat st;
08c3a6
   xstat (path_file, &st);
08c3a6
   TEST_VERIFY ((st.st_mode & 0777) != 1);
08c3a6
   xlstat (path_to_file, &st);
08c3a6
diff --git a/sysdeps/unix/sysv/linux/fchmodat.c b/sysdeps/unix/sysv/linux/fchmodat.c
08c3a6
index 5bd1eb96a5d78130..b0cf61949a9302d9 100644
08c3a6
--- a/sysdeps/unix/sysv/linux/fchmodat.c
08c3a6
+++ b/sysdeps/unix/sysv/linux/fchmodat.c
08c3a6
@@ -48,8 +48,8 @@ fchmodat (int fd, const char *file, mode_t mode, int flag)
08c3a6
 
08c3a6
       /* Use fstatat because fstat does not work on O_PATH descriptors
08c3a6
 	 before Linux 3.6.  */
08c3a6
-      struct stat64 st;
08c3a6
-      if (__fstatat64 (pathfd, "", &st, AT_EMPTY_PATH) != 0)
08c3a6
+      struct __stat64_t64 st;
08c3a6
+      if (__fstatat64_time64 (pathfd, "", &st, AT_EMPTY_PATH) != 0)
08c3a6
 	{
08c3a6
 	  __close_nocancel (pathfd);
08c3a6
 	  return -1;