|
 |
08dac2 |
commit c353689e49e72f3aafa1a9e68d4f7a4f33a79cbe
|
|
|
08dac2 |
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
|
|
|
08dac2 |
Date: Tue Jul 5 12:58:40 2022 -0300
|
|
|
08dac2 |
|
|
|
08dac2 |
elf: Fix wrong fscanf usage on tst-pldd
|
|
|
08dac2 |
|
|
|
08dac2 |
The fix done b2cd93fce666fdc8c9a5c64af2741a8a6940ac99 does not really
|
|
|
08dac2 |
work since macro strification does not expand the sizeof nor the
|
|
|
08dac2 |
arithmetic operation.
|
|
|
08dac2 |
|
|
|
08dac2 |
Checked on x86_64-linux-gnu.
|
|
|
08dac2 |
|
|
|
08dac2 |
diff --git a/elf/tst-pldd.c b/elf/tst-pldd.c
|
|
|
08dac2 |
index ab89798e250fdccc..52c0a75be5a808d1 100644
|
|
|
08dac2 |
--- a/elf/tst-pldd.c
|
|
|
08dac2 |
+++ b/elf/tst-pldd.c
|
|
|
08dac2 |
@@ -108,15 +108,16 @@ do_test (void)
|
|
|
08dac2 |
loader and libc. */
|
|
|
08dac2 |
{
|
|
|
08dac2 |
pid_t pid;
|
|
|
08dac2 |
- char buffer[512];
|
|
|
08dac2 |
-#define STRINPUT(size) "%" # size "s"
|
|
|
08dac2 |
+#define BUFFERLEN 511
|
|
|
08dac2 |
+ char buffer[BUFFERLEN + 1];
|
|
|
08dac2 |
+#define STRINPUT(size) XSTRINPUT(size)
|
|
|
08dac2 |
+#define XSTRINPUT(size) "%" # size "s"
|
|
|
08dac2 |
|
|
|
08dac2 |
FILE *out = fmemopen (pldd.out.buffer, pldd.out.length, "r");
|
|
|
08dac2 |
TEST_VERIFY (out != NULL);
|
|
|
08dac2 |
|
|
|
08dac2 |
/* First line is in the form of <pid>: <full path of executable> */
|
|
|
08dac2 |
- TEST_COMPARE (fscanf (out, "%u: " STRINPUT (sizeof (buffer) - 1), &pid,
|
|
|
08dac2 |
- buffer), 2);
|
|
|
08dac2 |
+ TEST_COMPARE (fscanf (out, "%u: " STRINPUT (BUFFERLEN), &pid, buffer), 2);
|
|
|
08dac2 |
|
|
|
08dac2 |
TEST_COMPARE (pid, *target_pid_ptr);
|
|
|
08dac2 |
TEST_COMPARE (strcmp (basename (buffer), "tst-pldd"), 0);
|