|
 |
3b25a6 |
commit a23820f6052a740246fdc7dcd9c43ce8eed0c45a
|
|
|
3b25a6 |
Author: Javier Pello <devel@otheo.eu>
|
|
|
3b25a6 |
Date: Mon Sep 5 20:09:01 2022 +0200
|
|
|
3b25a6 |
|
|
|
3b25a6 |
elf: Fix hwcaps string size overestimation
|
|
|
3b25a6 |
|
|
|
3b25a6 |
Commit dad90d528259b669342757c37dedefa8577e2636 added glibc-hwcaps
|
|
|
3b25a6 |
support for LD_LIBRARY_PATH and, for this, it adjusted the total
|
|
|
3b25a6 |
string size required in _dl_important_hwcaps. However, in doing so
|
|
|
3b25a6 |
it inadvertently altered the calculation of the size required for
|
|
|
3b25a6 |
the power set strings, as the computation of the power set string
|
|
|
3b25a6 |
size depended on the first value assigned to the total variable,
|
|
|
3b25a6 |
which is later shifted, resulting in overallocation of string
|
|
|
3b25a6 |
space. Fix this now by using a different variable to hold the
|
|
|
3b25a6 |
string size required for glibc-hwcaps.
|
|
|
3b25a6 |
|
|
|
3b25a6 |
Signed-off-by: Javier Pello <devel@otheo.eu>
|
|
|
3b25a6 |
|
|
|
3b25a6 |
diff --git a/elf/dl-hwcaps.c b/elf/dl-hwcaps.c
|
|
|
3b25a6 |
index 2fc4ae67a0f5d051..7ac27fd689187edc 100644
|
|
|
3b25a6 |
--- a/elf/dl-hwcaps.c
|
|
|
3b25a6 |
+++ b/elf/dl-hwcaps.c
|
|
|
3b25a6 |
@@ -193,7 +193,7 @@ _dl_important_hwcaps (const char *glibc_hwcaps_prepend,
|
|
|
3b25a6 |
/* Each hwcaps subdirectory has a GLIBC_HWCAPS_PREFIX string prefix
|
|
|
3b25a6 |
and a "/" suffix once stored in the result. */
|
|
|
3b25a6 |
hwcaps_counts.maximum_length += strlen (GLIBC_HWCAPS_PREFIX) + 1;
|
|
|
3b25a6 |
- size_t total = (hwcaps_counts.count * (strlen (GLIBC_HWCAPS_PREFIX) + 1)
|
|
|
3b25a6 |
+ size_t hwcaps_sz = (hwcaps_counts.count * (strlen (GLIBC_HWCAPS_PREFIX) + 1)
|
|
|
3b25a6 |
+ hwcaps_counts.total_length);
|
|
|
3b25a6 |
|
|
|
3b25a6 |
/* Count the number of bits set in the masked value. */
|
|
|
3b25a6 |
@@ -229,11 +229,12 @@ _dl_important_hwcaps (const char *glibc_hwcaps_prepend,
|
|
|
3b25a6 |
assert (m == cnt);
|
|
|
3b25a6 |
|
|
|
3b25a6 |
/* Determine the total size of all strings together. */
|
|
|
3b25a6 |
+ size_t total;
|
|
|
3b25a6 |
if (cnt == 1)
|
|
|
3b25a6 |
- total += temp[0].len + 1;
|
|
|
3b25a6 |
+ total = temp[0].len + 1;
|
|
|
3b25a6 |
else
|
|
|
3b25a6 |
{
|
|
|
3b25a6 |
- total += temp[0].len + temp[cnt - 1].len + 2;
|
|
|
3b25a6 |
+ total = temp[0].len + temp[cnt - 1].len + 2;
|
|
|
3b25a6 |
if (cnt > 2)
|
|
|
3b25a6 |
{
|
|
|
3b25a6 |
total <<= 1;
|
|
|
3b25a6 |
@@ -255,6 +256,7 @@ _dl_important_hwcaps (const char *glibc_hwcaps_prepend,
|
|
|
3b25a6 |
/* This is the overall result, including both glibc-hwcaps
|
|
|
3b25a6 |
subdirectories and the legacy hwcaps subdirectories using the
|
|
|
3b25a6 |
power set construction. */
|
|
|
3b25a6 |
+ total += hwcaps_sz;
|
|
|
3b25a6 |
struct r_strlenpair *overall_result
|
|
|
3b25a6 |
= malloc (*sz * sizeof (*result) + total);
|
|
|
3b25a6 |
if (overall_result == NULL)
|