1feee8
commit dd2315a866a4ac2b838ea1cb10c5ea1c35d51a2f
1feee8
Author: Florian Weimer <fweimer@redhat.com>
1feee8
Date:   Tue Aug 16 08:27:50 2022 +0200
1feee8
1feee8
    elf: Run tst-audit-tlsdesc, tst-audit-tlsdesc-dlopen everywhere
1feee8
    
1feee8
    The test is valid for all TLS models, but we want to make a reasonable
1feee8
    effort to test the GNU2 model specifically.  For example, aarch64
1feee8
    defaults to GNU2, but does not have -mtls-dialect=gnu2, and the test
1feee8
    was not run there.
1feee8
    
1feee8
    Suggested-by: Martin Coufal <mcoufal@redhat.com>
1feee8
1feee8
Conflicts:
1feee8
	elf/Makefile
1feee8
	  (missing tst-align3 test downstream)
1feee8
1feee8
diff --git a/elf/Makefile b/elf/Makefile
1feee8
index ea1512549be3f628..613d244e7781d479 100644
1feee8
--- a/elf/Makefile
1feee8
+++ b/elf/Makefile
1feee8
@@ -361,6 +361,8 @@ tests += \
1feee8
   tst-addr1 \
1feee8
   tst-align \
1feee8
   tst-align2 \
1feee8
+  tst-audit-tlsdesc \
1feee8
+  tst-audit-tlsdesc-dlopen \
1feee8
   tst-audit1 \
1feee8
   tst-audit2 \
1feee8
   tst-audit8 \
1feee8
@@ -679,6 +681,8 @@ modules-names = \
1feee8
   tst-alignmod2 \
1feee8
   tst-array2dep \
1feee8
   tst-array5dep \
1feee8
+  tst-audit-tlsdesc-mod1 \
1feee8
+  tst-audit-tlsdesc-mod2 \
1feee8
   tst-audit11mod1 \
1feee8
   tst-audit11mod2 \
1feee8
   tst-audit12mod1 \
1feee8
@@ -712,6 +716,7 @@ modules-names = \
1feee8
   tst-auditmanymod7 \
1feee8
   tst-auditmanymod8 \
1feee8
   tst-auditmanymod9 \
1feee8
+  tst-auditmod-tlsdesc  \
1feee8
   tst-auditmod1 \
1feee8
   tst-auditmod9a \
1feee8
   tst-auditmod9b \
1feee8
@@ -889,23 +894,8 @@ modules-names += tst-gnu2-tls1mod
1feee8
 $(objpfx)tst-gnu2-tls1: $(objpfx)tst-gnu2-tls1mod.so
1feee8
 tst-gnu2-tls1mod.so-no-z-defs = yes
1feee8
 CFLAGS-tst-gnu2-tls1mod.c += -mtls-dialect=gnu2
1feee8
+endif # $(have-mtls-dialect-gnu2)
1feee8
 
1feee8
-tests += tst-audit-tlsdesc tst-audit-tlsdesc-dlopen
1feee8
-modules-names += tst-audit-tlsdesc-mod1 tst-audit-tlsdesc-mod2 tst-auditmod-tlsdesc
1feee8
-$(objpfx)tst-audit-tlsdesc: $(objpfx)tst-audit-tlsdesc-mod1.so \
1feee8
-			    $(objpfx)tst-audit-tlsdesc-mod2.so \
1feee8
-			    $(shared-thread-library)
1feee8
-CFLAGS-tst-audit-tlsdesc-mod1.c += -mtls-dialect=gnu2
1feee8
-CFLAGS-tst-audit-tlsdesc-mod2.c += -mtls-dialect=gnu2
1feee8
-$(objpfx)tst-audit-tlsdesc-dlopen: $(shared-thread-library)
1feee8
-$(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-audit-tlsdesc-mod1.so \
1feee8
-				       $(objpfx)tst-audit-tlsdesc-mod2.so
1feee8
-$(objpfx)tst-audit-tlsdesc-mod1.so: $(objpfx)tst-audit-tlsdesc-mod2.so
1feee8
-$(objpfx)tst-audit-tlsdesc.out: $(objpfx)tst-auditmod-tlsdesc.so
1feee8
-tst-audit-tlsdesc-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
1feee8
-$(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-auditmod-tlsdesc.so
1feee8
-tst-audit-tlsdesc-dlopen-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
1feee8
-endif
1feee8
 ifeq (yes,$(have-protected-data))
1feee8
 modules-names += tst-protected1moda tst-protected1modb
1feee8
 tests += tst-protected1a tst-protected1b
1feee8
@@ -2656,3 +2646,21 @@ $(objpfx)tst-tls-allocation-failure-static-patched.out: \
1feee8
 	grep -q '^Fatal glibc error: Cannot allocate TLS block$$' $@ \
1feee8
 	  && grep -q '^status: 127$$' $@; \
1feee8
 	  $(evaluate-test)
1feee8
+
1feee8
+$(objpfx)tst-audit-tlsdesc: $(objpfx)tst-audit-tlsdesc-mod1.so \
1feee8
+			    $(objpfx)tst-audit-tlsdesc-mod2.so \
1feee8
+			    $(shared-thread-library)
1feee8
+ifeq (yes,$(have-mtls-dialect-gnu2))
1feee8
+# The test is valid for all TLS types, but we want to exercise GNU2
1feee8
+# TLS if possible.
1feee8
+CFLAGS-tst-audit-tlsdesc-mod1.c += -mtls-dialect=gnu2
1feee8
+CFLAGS-tst-audit-tlsdesc-mod2.c += -mtls-dialect=gnu2
1feee8
+endif
1feee8
+$(objpfx)tst-audit-tlsdesc-dlopen: $(shared-thread-library)
1feee8
+$(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-audit-tlsdesc-mod1.so \
1feee8
+				       $(objpfx)tst-audit-tlsdesc-mod2.so
1feee8
+$(objpfx)tst-audit-tlsdesc-mod1.so: $(objpfx)tst-audit-tlsdesc-mod2.so
1feee8
+$(objpfx)tst-audit-tlsdesc.out: $(objpfx)tst-auditmod-tlsdesc.so
1feee8
+tst-audit-tlsdesc-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
1feee8
+$(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-auditmod-tlsdesc.so
1feee8
+tst-audit-tlsdesc-dlopen-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so