00c0d4
commit 7de01e60c200c431d3469deb784da8fd4508fc15
00c0d4
Author: Florian Weimer <fweimer@redhat.com>
00c0d4
Date:   Fri Jan 14 20:16:05 2022 +0100
00c0d4
00c0d4
    elf/Makefile: Reflow and sort most variable assignments
00c0d4
    
00c0d4
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
00c0d4
00c0d4
Conflicts:
00c0d4
	elf/Makefile
00c0d4
		Complete rewrite of reflow.
00c0d4
00c0d4
diff --git a/elf/Makefile b/elf/Makefile
00c0d4
index 53faca4585220048..954cd08c199f5037 100644
00c0d4
--- a/elf/Makefile
00c0d4
+++ b/elf/Makefile
00c0d4
@@ -21,20 +21,60 @@ subdir		:= elf
00c0d4
 
00c0d4
 include ../Makeconfig
00c0d4
 
00c0d4
-headers		= elf.h bits/elfclass.h link.h bits/link.h bits/link_lavcurrent.h
00c0d4
-routines	= $(all-dl-routines) dl-support dl-iteratephdr \
00c0d4
-		  dl-addr dl-addr-obj enbl-secure dl-profstub \
00c0d4
-		  dl-origin dl-libc dl-sym dl-sysdep dl-error \
00c0d4
-		  dl-reloc-static-pie libc_early_init
00c0d4
+headers	= \
00c0d4
+  bits/elfclass.h \
00c0d4
+  bits/link.h \
00c0d4
+  bits/link_lavcurrent.h \
00c0d4
+  elf.h \
00c0d4
+  link.h \
00c0d4
+  # headers
00c0d4
+
00c0d4
+routines = \
00c0d4
+  $(all-dl-routines) \
00c0d4
+  dl-addr \
00c0d4
+  dl-addr-obj \
00c0d4
+  dl-error \
00c0d4
+  dl-iteratephdr \
00c0d4
+  dl-libc \
00c0d4
+  dl-origin \
00c0d4
+  dl-profstub \
00c0d4
+  dl-reloc-static-pie \
00c0d4
+  dl-support \
00c0d4
+  dl-sym \
00c0d4
+  dl-sysdep \
00c0d4
+  enbl-secure \
00c0d4
+  libc_early_init \
00c0d4
+  # routines
00c0d4
 
00c0d4
 # The core dynamic linking functions are in libc for the static and
00c0d4
 # profiled libraries.
00c0d4
-dl-routines	= $(addprefix dl-,load lookup object reloc deps \
00c0d4
-				  runtime init fini debug misc \
00c0d4
-				  version profile tls origin scope \
00c0d4
-				  execstack open close trampoline \
00c0d4
-				  exception sort-maps lookup-direct \
00c0d4
-				  call-libc-early-init write)
00c0d4
+dl-routines = \
00c0d4
+  dl-call-libc-early-init \
00c0d4
+  dl-close \
00c0d4
+  dl-debug \
00c0d4
+  dl-deps \
00c0d4
+  dl-exception \
00c0d4
+  dl-execstack \
00c0d4
+  dl-fini \
00c0d4
+  dl-init \
00c0d4
+  dl-load \
00c0d4
+  dl-lookup \
00c0d4
+  dl-lookup-direct \
00c0d4
+  dl-misc \
00c0d4
+  dl-object \
00c0d4
+  dl-open \
00c0d4
+  dl-origin \
00c0d4
+  dl-profile \
00c0d4
+  dl-reloc \
00c0d4
+  dl-runtime \
00c0d4
+  dl-scope \
00c0d4
+  dl-sort-maps \
00c0d4
+  dl-tls \
00c0d4
+  dl-trampoline \
00c0d4
+  dl-version \
00c0d4
+  dl-write \
00c0d4
+  # dl-routines
00c0d4
+
00c0d4
 ifeq (yes,$(use-ldconfig))
00c0d4
 dl-routines += dl-cache
00c0d4
 endif
00c0d4
@@ -57,15 +97,36 @@ endif
00c0d4
 
00c0d4
 all-dl-routines = $(dl-routines) $(sysdep-dl-routines)
00c0d4
 # But they are absent from the shared libc, because that code is in ld.so.
00c0d4
-elide-routines.os = $(all-dl-routines) dl-support enbl-secure dl-origin \
00c0d4
-		    dl-sysdep dl-exception dl-reloc-static-pie
00c0d4
+elide-routines.os = \
00c0d4
+  $(all-dl-routines) \
00c0d4
+  dl-exception \
00c0d4
+  dl-origin \
00c0d4
+  dl-reloc-static-pie \
00c0d4
+  dl-support \
00c0d4
+  dl-sysdep \
00c0d4
+  enbl-secure \
00c0d4
+  # elide-routines.os
00c0d4
 
00c0d4
 # ld.so uses those routines, plus some special stuff for being the program
00c0d4
 # interpreter and operating independent of libc.
00c0d4
-rtld-routines	= rtld $(all-dl-routines) dl-sysdep dl-environ dl-minimal \
00c0d4
-  dl-error-minimal dl-conflict dl-hwcaps dl-hwcaps_split dl-hwcaps-subdirs \
00c0d4
-  dl-usage dl-diagnostics dl-diagnostics-kernel dl-diagnostics-cpu \
00c0d4
-  dl-audit
00c0d4
+rtld-routines = \
00c0d4
+  $(all-dl-routines) \
00c0d4
+  dl-audit \
00c0d4
+  dl-conflict \
00c0d4
+  dl-diagnostics \
00c0d4
+  dl-diagnostics-cpu \
00c0d4
+  dl-diagnostics-kernel \
00c0d4
+  dl-environ \
00c0d4
+  dl-error-minimal \
00c0d4
+  dl-hwcaps \
00c0d4
+  dl-hwcaps-subdirs \
00c0d4
+  dl-hwcaps_split \
00c0d4
+  dl-minimal \
00c0d4
+  dl-sysdep \
00c0d4
+  dl-usage \
00c0d4
+  rtld \
00c0d4
+  # rtld-routines
00c0d4
+
00c0d4
 all-rtld-routines = $(rtld-routines) $(sysdep-rtld-routines)
00c0d4
 
00c0d4
 CFLAGS-dl-runtime.c += -fexceptions -fasynchronous-unwind-tables
00c0d4
@@ -98,8 +159,18 @@ ld-map		= $(common-objpfx)ld.map
00c0d4
 endif
00c0d4
 
00c0d4
 ifeq (yes,$(build-shared))
00c0d4
-extra-objs	= $(all-rtld-routines:%=%.os) soinit.os sofini.os interp.os
00c0d4
-generated	+= librtld.os dl-allobjs.os ld.so ldd
00c0d4
+extra-objs = \
00c0d4
+  $(all-rtld-routines:%=%.os) \
00c0d4
+  sofini.os \
00c0d4
+  soinit.os \
00c0d4
+  interp.os \
00c0d4
+  # extra-objs
00c0d4
+generated += \
00c0d4
+  dl-allobjs.os \
00c0d4
+  ldd \
00c0d4
+  ld.so \
00c0d4
+  librtld.os \
00c0d4
+  # generated
00c0d4
 install-others	= $(inst_rtlddir)/$(rtld-installed-name) $(inst_bindir)/ld.so
00c0d4
 install-bin-script = ldd
00c0d4
 endif
00c0d4
@@ -117,8 +188,15 @@ others-static	+= ldconfig
00c0d4
 others		+= ldconfig
00c0d4
 install-rootsbin += ldconfig
00c0d4
 
00c0d4
-ldconfig-modules := cache readlib xmalloc xstrdup chroot_canon static-stubs \
00c0d4
-  stringtable
00c0d4
+ldconfig-modules := \
00c0d4
+  cache \
00c0d4
+  chroot_canon \
00c0d4
+  readlib \
00c0d4
+  static-stubs \
00c0d4
+  stringtable \
00c0d4
+  xmalloc \
00c0d4
+  xstrdup \
00c0d4
+  # ldconfig-modules
00c0d4
 extra-objs	+= $(ldconfig-modules:=.o)
00c0d4
 others-extras   = $(ldconfig-modules)
00c0d4
 endif
00c0d4
@@ -153,20 +231,34 @@ $(inst_auditdir)/sotruss-lib.so: $(objpfx)sotruss-lib.so $(+force)
00c0d4
 	$(do-install-program)
00c0d4
 endif
00c0d4
 
00c0d4
-tests-static-normal := tst-leaks1-static tst-array1-static tst-array5-static \
00c0d4
-	       tst-dl-iter-static \
00c0d4
-	       tst-tlsalign-static tst-tlsalign-extern-static \
00c0d4
-	       tst-linkall-static tst-env-setuid tst-env-setuid-tunables \
00c0d4
-	       tst-dst-static
00c0d4
-tests-static-internal := tst-tls1-static tst-tls2-static \
00c0d4
-	       tst-ptrguard1-static tst-stackguard1-static \
00c0d4
-	       tst-tls1-static-non-pie tst-libc_dlvsym-static
00c0d4
+tests-static-normal := \
00c0d4
+  tst-array1-static \
00c0d4
+  tst-array5-static \
00c0d4
+  tst-dl-iter-static \
00c0d4
+  tst-dst-static \
00c0d4
+  tst-env-setuid \
00c0d4
+  tst-env-setuid-tunables \
00c0d4
+  tst-leaks1-static \
00c0d4
+  tst-linkall-static \
00c0d4
+  tst-tlsalign-extern-static \
00c0d4
+  tst-tlsalign-static \
00c0d4
+  # tests-static-normal
00c0d4
+
00c0d4
+tests-static-internal := \
00c0d4
+  tst-libc_dlvsym-static \
00c0d4
+  tst-ptrguard1-static \
00c0d4
+  tst-stackguard1-static \
00c0d4
+  tst-tls1-static \
00c0d4
+  tst-tls1-static-non-pie \
00c0d4
+  tst-tls2-static \
00c0d4
+  # tests-static-internal
00c0d4
 
00c0d4
 CRT-tst-tls1-static-non-pie := $(csu-objpfx)crt1.o
00c0d4
 tst-tls1-static-non-pie-no-pie = yes
00c0d4
 
00c0d4
 tests-container = \
00c0d4
-			  tst-ldconfig-bad-aux-cache
00c0d4
+  tst-ldconfig-bad-aux-cache \
00c0d4
+  # tests-container
00c0d4
 
00c0d4
 ifeq (no,$(build-hardcoded-path-in-tests))
00c0d4
 # This is an ld.so.cache test, and RPATH/RUNPATH in the executable
00c0d4
@@ -174,14 +266,31 @@ ifeq (no,$(build-hardcoded-path-in-tests))
00c0d4
 tests-container += tst-glibc-hwcaps-prepend-cache
00c0d4
 endif
00c0d4
 
00c0d4
-tests := tst-tls9 tst-leaks1 \
00c0d4
-	tst-array1 tst-array2 tst-array3 tst-array4 tst-array5 \
00c0d4
-	tst-auxv tst-stringtable
00c0d4
-tests-internal := tst-tls1 tst-tls2 $(tests-static-internal)
00c0d4
+tests := \
00c0d4
+  tst-array1 \
00c0d4
+  tst-array2 \
00c0d4
+  tst-array3 \
00c0d4
+  tst-array4 \
00c0d4
+  tst-array5 \
00c0d4
+  tst-auxv \
00c0d4
+  tst-leaks1 \
00c0d4
+  tst-stringtable \
00c0d4
+  tst-tls9 \
00c0d4
+  # tests
00c0d4
+
00c0d4
+tests-internal := \
00c0d4
+  $(tests-static-internal) \
00c0d4
+  tst-tls1 \
00c0d4
+  tst-tls2 \
00c0d4
+  # tests-internal
00c0d4
+
00c0d4
 tests-static := $(tests-static-normal) $(tests-static-internal)
00c0d4
 
00c0d4
 ifeq (yes,$(build-shared))
00c0d4
-tests-static += tst-tls9-static
00c0d4
+tests-static += \
00c0d4
+  tst-tls9-static \
00c0d4
+  # tests-static
00c0d4
+
00c0d4
 tst-tls9-static-ENV = \
00c0d4
        LD_LIBRARY_PATH=$(objpfx):$(common-objpfx):$(common-objpfx)dlfcn
00c0d4
 
00c0d4
@@ -302,37 +411,71 @@ tests += \
00c0d4
   unload6 \
00c0d4
   unload7 \
00c0d4
   unload8 \
00c0d4
-#	 reldep9
00c0d4
+  # tests
00c0d4
 tests-cxx = \
00c0d4
   tst-dlopen-nodelete-reloc \
00c0d4
   tst-nodelete \
00c0d4
   tst-unique3 \
00c0d4
   tst-unique4 \
00c0d4
-# tests-cxx
00c0d4
+  # tests-cxx
00c0d4
 
00c0d4
 tests += $(if $(CXX),$(tests-cxx))
00c0d4
-tests-internal += loadtest unload unload2 circleload1 \
00c0d4
-	 neededtest neededtest2 neededtest3 neededtest4 \
00c0d4
-	 tst-tls3 tst-tls6 tst-tls7 tst-tls8 tst-dlmopen2 \
00c0d4
-	 tst-ptrguard1 tst-stackguard1 tst-libc_dlvsym \
00c0d4
-	 tst-create_format1 tst-tls-surplus tst-dl-hwcaps_split \
00c0d4
-	 tst-audit19a
00c0d4
-tests-container += tst-pldd tst-preload-pthread-libc
00c0d4
+
00c0d4
+tests-internal += \
00c0d4
+  circleload1 \
00c0d4
+  loadtest \
00c0d4
+  neededtest \
00c0d4
+  neededtest2 \
00c0d4
+  neededtest3 \
00c0d4
+  neededtest4 \
00c0d4
+  tst-audit19a \
00c0d4
+  tst-create_format1 \
00c0d4
+  tst-dl-hwcaps_split \
00c0d4
+  tst-dlmopen2 \
00c0d4
+  tst-libc_dlvsym \
00c0d4
+  tst-ptrguard1 \
00c0d4
+  tst-stackguard1 \
00c0d4
+  tst-tls-surplus \
00c0d4
+  tst-tls3 \
00c0d4
+  tst-tls6 \
00c0d4
+  tst-tls7 \
00c0d4
+  tst-tls8 \
00c0d4
+  unload \
00c0d4
+  unload2 \
00c0d4
+  # tests-internal
00c0d4
+
00c0d4
+tests-container += \
00c0d4
+  tst-pldd \
00c0d4
+  tst-preload-pthread-libc
00c0d4
+  # tests-container
00c0d4
+
00c0d4
 ifeq ($(build-hardcoded-path-in-tests),yes)
00c0d4
 tests += tst-dlopen-aout
00c0d4
 tst-dlopen-aout-no-pie = yes
00c0d4
 endif
00c0d4
-test-srcs = tst-pathopt
00c0d4
+test-srcs = \
00c0d4
+  tst-pathopt
00c0d4
+  # tests-srcs
00c0d4
+
00c0d4
 selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)
00c0d4
+
00c0d4
 ifneq ($(selinux-enabled),1)
00c0d4
-tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
00c0d4
+tests-execstack-yes = \
00c0d4
+  tst-execstack \
00c0d4
+  tst-execstack-needed \
00c0d4
+  tst-execstack-prog \
00c0d4
+  # tests-execstack-yes
00c0d4
 endif
00c0d4
 endif
00c0d4
 tests += $(tests-execstack-$(have-z-execstack))
00c0d4
 ifeq ($(run-built-tests),yes)
00c0d4
-tests-special += $(objpfx)tst-leaks1-mem.out \
00c0d4
-		 $(objpfx)tst-leaks1-static-mem.out $(objpfx)noload-mem.out \
00c0d4
-		 $(objpfx)tst-ldconfig-X.out $(objpfx)tst-rtld-help.out
00c0d4
+tests-special += \
00c0d4
+  $(objpfx)noload-mem.out \
00c0d4
+  $(objpfx)tst-ldconfig-X.out \
00c0d4
+  $(objpfx)tst-leaks1-mem.out \
00c0d4
+  $(objpfx)tst-leaks1-static-mem.out \
00c0d4
+  $(objpfx)tst-rtld-help.out \
00c0d4
+  # tests-special
00c0d4
 endif
00c0d4
 tlsmod17a-suffixes = 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
00c0d4
 tlsmod18a-suffixes = 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
00c0d4
@@ -349,9 +492,16 @@ tst-tls-many-dynamic-modules-dep = \
00c0d4
 tst-tls-many-dynamic-modules-dep-bad-suffixes = 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14
00c0d4
 tst-tls-many-dynamic-modules-dep-bad = \
00c0d4
   $(foreach n,$(tst-tls-many-dynamic-modules-dep-bad-suffixes),tst-tls-manydynamic$(n)mod-dep-bad)
00c0d4
-extra-test-objs += $(tlsmod17a-modules:=.os) $(tlsmod18a-modules:=.os) \
00c0d4
-		   tst-tlsalign-vars.o
00c0d4
-test-extras += tst-tlsmod17a tst-tlsmod18a tst-tlsalign-vars
00c0d4
+extra-test-objs += \
00c0d4
+  $(tlsmod17a-modules:=.os) \
00c0d4
+  $(tlsmod18a-modules:=.os) \
00c0d4
+  tst-tlsalign-vars.o \
00c0d4
+  # extra-test-objs
00c0d4
+test-extras += \
00c0d4
+  tst-tlsalign-vars \
00c0d4
+  tst-tlsmod17a \
00c0d4
+  tst-tlsmod18a \
00c0d4
+  # test-extras
00c0d4
 modules-names = \
00c0d4
   circlemod1 \
00c0d4
   circlemod1a \
00c0d4
@@ -607,17 +757,17 @@ modules-names-cxx = \
00c0d4
   tst-unique3lib \
00c0d4
   tst-unique3lib2 \
00c0d4
   tst-unique4lib \
00c0d4
-# modules-names-cxx
00c0d4
+  # modules-names-cxx
00c0d4
 
00c0d4
 modules-names += \
00c0d4
   $(if $(CXX),$(modules-names-cxx)) \
00c0d4
   $(modules-execstack-$(have-z-execstack)) \
00c0d4
+  $(tlsmod17a-modules) \
00c0d4
+  $(tlsmod18a-modules) \
00c0d4
   $(tst-tls-many-dynamic-modules) \
00c0d4
   $(tst-tls-many-dynamic-modules-dep) \
00c0d4
   $(tst-tls-many-dynamic-modules-dep-bad) \
00c0d4
-  $(tlsmod17a-modules) \
00c0d4
-  $(tlsmod18a-modules) \
00c0d4
-# modules-names
00c0d4
+  # modules-names
00c0d4
 
00c0d4
 # Most modules build with _ISOMAC defined, but those filtered out
00c0d4
 # depend on internal headers.
00c0d4
@@ -680,54 +830,103 @@ modules-names-nobuild := filtmod1
00c0d4
 tests += $(tests-static)
00c0d4
 
00c0d4
 ifneq (no,$(multi-arch))
00c0d4
-tests-ifuncstatic := ifuncmain1static ifuncmain1picstatic \
00c0d4
-		ifuncmain2static ifuncmain2picstatic \
00c0d4
-		ifuncmain4static ifuncmain4picstatic \
00c0d4
-		ifuncmain5static ifuncmain5picstatic \
00c0d4
-		ifuncmain7static ifuncmain7picstatic
00c0d4
+tests-ifuncstatic := \
00c0d4
+  ifuncmain1static \
00c0d4
+  ifuncmain1picstatic \
00c0d4
+  ifuncmain2static \
00c0d4
+  ifuncmain2picstatic \
00c0d4
+  ifuncmain4static \
00c0d4
+  ifuncmain4picstatic \
00c0d4
+  ifuncmain5static \
00c0d4
+  ifuncmain5picstatic \
00c0d4
+  ifuncmain7static \
00c0d4
+  ifuncmain7picstatic \
00c0d4
+  # tests-ifuncstatic
00c0d4
 tests-static += $(tests-ifuncstatic)
00c0d4
 tests-internal += $(tests-ifuncstatic)
00c0d4
 ifeq (yes,$(build-shared))
00c0d4
 tests-internal += \
00c0d4
-	 ifuncmain1 ifuncmain1pic ifuncmain1vis ifuncmain1vispic \
00c0d4
-	 ifuncmain1staticpic \
00c0d4
-	 ifuncmain2 ifuncmain2pic ifuncmain3 ifuncmain4 \
00c0d4
-	 ifuncmain5 ifuncmain5pic ifuncmain5staticpic \
00c0d4
-	 ifuncmain7 ifuncmain7pic
00c0d4
-ifunc-test-modules = ifuncdep1 ifuncdep1pic ifuncdep2 ifuncdep2pic \
00c0d4
-		     ifuncdep5 ifuncdep5pic
00c0d4
+  ifuncmain1 \
00c0d4
+  ifuncmain1pic \
00c0d4
+  ifuncmain1staticpic \
00c0d4
+  ifuncmain1vis \
00c0d4
+  ifuncmain1vispic \
00c0d4
+  ifuncmain2 \
00c0d4
+  ifuncmain2pic \
00c0d4
+  ifuncmain3 \
00c0d4
+  ifuncmain4 \
00c0d4
+  ifuncmain5 \
00c0d4
+  ifuncmain5pic \
00c0d4
+  ifuncmain5staticpic \
00c0d4
+  ifuncmain7 \
00c0d4
+  ifuncmain7pic \
00c0d4
+  # tests-internal
00c0d4
+ifunc-test-modules = \
00c0d4
+  ifuncdep1 \
00c0d4
+  ifuncdep1pic \
00c0d4
+  ifuncdep2 \
00c0d4
+  ifuncdep2pic \
00c0d4
+  ifuncdep5 \
00c0d4
+  ifuncdep5pic \
00c0d4
+  # ifunc-test-modules
00c0d4
 extra-test-objs += $(ifunc-test-modules:=.o)
00c0d4
 test-internal-extras += $(ifunc-test-modules)
00c0d4
 ifeq (yes,$(have-fpie))
00c0d4
-ifunc-pie-tests = ifuncmain1pie ifuncmain1vispie ifuncmain1staticpie \
00c0d4
-		  ifuncmain5pie ifuncmain6pie ifuncmain7pie
00c0d4
+ifunc-pie-tests = \
00c0d4
+  ifuncmain1pie \
00c0d4
+  ifuncmain1staticpie \
00c0d4
+  ifuncmain1vispie \
00c0d4
+  ifuncmain5pie \
00c0d4
+  ifuncmain6pie \
00c0d4
+  ifuncmain7pie \
00c0d4
+  # ifunc-pie-tests
00c0d4
 tests-internal += $(ifunc-pie-tests)
00c0d4
 tests-pie += $(ifunc-pie-tests)
00c0d4
 endif
00c0d4
-modules-names += ifuncmod1 ifuncmod3 ifuncmod5 ifuncmod6
00c0d4
+modules-names += \
00c0d4
+  ifuncmod1 \
00c0d4
+  ifuncmod3 \
00c0d4
+  ifuncmod5 \
00c0d4
+  ifuncmod6 \
00c0d4
+  # modules-names
00c0d4
 endif
00c0d4
 endif
00c0d4
 
00c0d4
 ifeq (yes,$(build-shared))
00c0d4
 ifeq ($(run-built-tests),yes)
00c0d4
-tests-special += $(objpfx)tst-pathopt.out $(objpfx)tst-rtld-load-self.out \
00c0d4
-		 $(objpfx)tst-rtld-preload.out $(objpfx)argv0test.out \
00c0d4
-		 $(objpfx)tst-rtld-help.out
00c0d4
+tests-special += \
00c0d4
+  $(objpfx)argv0test.out \
00c0d4
+  $(objpfx)tst-pathopt.out \
00c0d4
+  $(objpfx)tst-rtld-help.out \
00c0d4
+  $(objpfx)tst-rtld-load-self.out \
00c0d4
+  $(objpfx)tst-rtld-preload.out \
00c0d4
+  # tests-special
00c0d4
 endif
00c0d4
-tests-special += $(objpfx)check-textrel.out $(objpfx)check-execstack.out \
00c0d4
-		 $(objpfx)check-wx-segment.out \
00c0d4
-		 $(objpfx)check-localplt.out $(objpfx)check-initfini.out
00c0d4
+tests-special += \
00c0d4
+  $(objpfx)check-execstack.out \
00c0d4
+  $(objpfx)check-initfini.out \
00c0d4
+  $(objpfx)check-localplt.out \
00c0d4
+  $(objpfx)check-textrel.out \
00c0d4
+  $(objpfx)check-wx-segment.out \
00c0d4
+  # tests-special
00c0d4
 endif
00c0d4
 
00c0d4
 ifeq ($(run-built-tests),yes)
00c0d4
-tests-special += $(objpfx)order-cmp.out $(objpfx)tst-array1-cmp.out \
00c0d4
-		 $(objpfx)tst-array1-static-cmp.out \
00c0d4
-		 $(objpfx)tst-array2-cmp.out $(objpfx)tst-array3-cmp.out \
00c0d4
-		 $(objpfx)tst-array4-cmp.out $(objpfx)tst-array5-cmp.out \
00c0d4
-		 $(objpfx)tst-array5-static-cmp.out $(objpfx)order2-cmp.out \
00c0d4
-		 $(objpfx)tst-initorder-cmp.out \
00c0d4
-		 $(objpfx)tst-initorder2-cmp.out $(objpfx)tst-unused-dep.out \
00c0d4
-		 $(objpfx)tst-unused-dep-cmp.out
00c0d4
+tests-special += \
00c0d4
+  $(objpfx)order-cmp.out \
00c0d4
+  $(objpfx)order2-cmp.out \
00c0d4
+  $(objpfx)tst-array1-cmp.out \
00c0d4
+  $(objpfx)tst-array1-static-cmp.out \
00c0d4
+  $(objpfx)tst-array2-cmp.out \
00c0d4
+  $(objpfx)tst-array3-cmp.out \
00c0d4
+  $(objpfx)tst-array4-cmp.out \
00c0d4
+  $(objpfx)tst-array5-cmp.out \
00c0d4
+  $(objpfx)tst-array5-static-cmp.out \
00c0d4
+  $(objpfx)tst-initorder-cmp.out \
00c0d4
+  $(objpfx)tst-initorder2-cmp.out \
00c0d4
+  $(objpfx)tst-unused-dep-cmp.out \
00c0d4
+  $(objpfx)tst-unused-dep.out \
00c0d4
+  # tests-special
00c0d4
 endif
00c0d4
 
00c0d4
 check-abi: $(objpfx)check-abi-ld.out
00c0d4
@@ -807,6 +1006,7 @@ rtld-stubbed-symbols = \
00c0d4
   free \
00c0d4
   malloc \
00c0d4
   realloc \
00c0d4
+  # rtld-stubbed-symbols
00c0d4
 
00c0d4
 # The GCC arguments that implement $(rtld-stubbed-symbols).
00c0d4
 rtld-stubbed-symbols-args = \