|
 |
4c1956 |
commit 0b98a8748759e88b58927882a8714109abe0a2d6
|
|
|
4c1956 |
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
|
|
|
4c1956 |
Date: Thu Jul 22 17:10:57 2021 -0300
|
|
|
4c1956 |
|
|
|
4c1956 |
elf: Add _dl_audit_preinit
|
|
|
4c1956 |
|
|
|
4c1956 |
It consolidates the code required to call la_preinit audit
|
|
|
4c1956 |
callback.
|
|
|
4c1956 |
|
|
|
4c1956 |
Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu.
|
|
|
4c1956 |
|
|
|
4c1956 |
Reviewed-by: Florian Weimer <fweimer@redhat.com>
|
|
|
4c1956 |
|
|
|
4c1956 |
Conflicts:
|
|
|
4c1956 |
csu/libc-start.c
|
|
|
4c1956 |
Rework to existing init call code.
|
|
|
4c1956 |
|
|
|
4c1956 |
diff --git a/csu/libc-start.c b/csu/libc-start.c
|
|
|
4c1956 |
index fd0f8640eaeae34c..ae703cfa620163fd 100644
|
|
|
4c1956 |
--- a/csu/libc-start.c
|
|
|
4c1956 |
+++ b/csu/libc-start.c
|
|
|
4c1956 |
@@ -265,32 +265,20 @@ LIBC_START_MAIN (int (*main) (int, char **, char ** MAIN_AUXVEC_DECL),
|
|
|
4c1956 |
#ifdef SHARED
|
|
|
4c1956 |
if (__builtin_expect (GLRO(dl_debug_mask) & DL_DEBUG_IMPCALLS, 0))
|
|
|
4c1956 |
GLRO(dl_debug_printf) ("\ninitialize program: %s\n\n", argv[0]);
|
|
|
4c1956 |
-#endif
|
|
|
4c1956 |
+
|
|
|
4c1956 |
if (init)
|
|
|
4c1956 |
(*init) (argc, argv, __environ MAIN_AUXVEC_PARAM);
|
|
|
4c1956 |
|
|
|
4c1956 |
-#ifdef SHARED
|
|
|
4c1956 |
/* Auditing checkpoint: we have a new object. */
|
|
|
4c1956 |
- if (__glibc_unlikely (GLRO(dl_naudit) > 0))
|
|
|
4c1956 |
- {
|
|
|
4c1956 |
- struct audit_ifaces *afct = GLRO(dl_audit);
|
|
|
4c1956 |
- struct link_map *head = GL(dl_ns)[LM_ID_BASE]._ns_loaded;
|
|
|
4c1956 |
- for (unsigned int cnt = 0; cnt < GLRO(dl_naudit); ++cnt)
|
|
|
4c1956 |
- {
|
|
|
4c1956 |
- if (afct->preinit != NULL)
|
|
|
4c1956 |
- afct->preinit (&link_map_audit_state (head, cnt)->cookie);
|
|
|
4c1956 |
-
|
|
|
4c1956 |
- afct = afct->next;
|
|
|
4c1956 |
- }
|
|
|
4c1956 |
- }
|
|
|
4c1956 |
-#endif
|
|
|
4c1956 |
+ _dl_audit_preinit (GL(dl_ns)[LM_ID_BASE]._ns_loaded);
|
|
|
4c1956 |
|
|
|
4c1956 |
-#ifdef SHARED
|
|
|
4c1956 |
if (__glibc_unlikely (GLRO(dl_debug_mask) & DL_DEBUG_IMPCALLS))
|
|
|
4c1956 |
GLRO(dl_debug_printf) ("\ntransferring control: %s\n\n", argv[0]);
|
|
|
4c1956 |
-#endif
|
|
|
4c1956 |
|
|
|
4c1956 |
-#ifndef SHARED
|
|
|
4c1956 |
+#else /* !SHARED */
|
|
|
4c1956 |
+ if (init)
|
|
|
4c1956 |
+ (*init) (argc, argv, __environ MAIN_AUXVEC_PARAM);
|
|
|
4c1956 |
+
|
|
|
4c1956 |
_dl_debug_initialize (0, LM_ID_BASE);
|
|
|
4c1956 |
#endif
|
|
|
4c1956 |
#ifdef HAVE_CLEANUP_JMP_BUF
|
|
|
4c1956 |
diff --git a/elf/Versions b/elf/Versions
|
|
|
4c1956 |
index c5d4342cf1f5124c..35ac181bdb099af8 100644
|
|
|
4c1956 |
--- a/elf/Versions
|
|
|
4c1956 |
+++ b/elf/Versions
|
|
|
4c1956 |
@@ -59,7 +59,7 @@ ld {
|
|
|
4c1956 |
_dl_argv; _dl_find_dso_for_object; _dl_get_tls_static_info;
|
|
|
4c1956 |
_dl_deallocate_tls; _dl_make_stack_executable;
|
|
|
4c1956 |
_dl_rtld_di_serinfo; _dl_starting_up; _dl_fatal_printf;
|
|
|
4c1956 |
- _dl_audit_symbind_alt;
|
|
|
4c1956 |
+ _dl_audit_symbind_alt; _dl_audit_preinit;
|
|
|
4c1956 |
_rtld_global; _rtld_global_ro;
|
|
|
4c1956 |
|
|
|
4c1956 |
# Only here for gdb while a better method is developed.
|
|
|
4c1956 |
diff --git a/elf/dl-audit.c b/elf/dl-audit.c
|
|
|
4c1956 |
index a21530f30bc5524b..0b6fac8e48877c93 100644
|
|
|
4c1956 |
--- a/elf/dl-audit.c
|
|
|
4c1956 |
+++ b/elf/dl-audit.c
|
|
|
4c1956 |
@@ -108,6 +108,21 @@ _dl_audit_objclose (struct link_map *l)
|
|
|
4c1956 |
}
|
|
|
4c1956 |
}
|
|
|
4c1956 |
|
|
|
4c1956 |
+void
|
|
|
4c1956 |
+_dl_audit_preinit (struct link_map *l)
|
|
|
4c1956 |
+{
|
|
|
4c1956 |
+ if (__glibc_likely (GLRO(dl_naudit) == 0))
|
|
|
4c1956 |
+ return;
|
|
|
4c1956 |
+
|
|
|
4c1956 |
+ struct audit_ifaces *afct = GLRO(dl_audit);
|
|
|
4c1956 |
+ for (unsigned int cnt = 0; cnt < GLRO(dl_naudit); ++cnt)
|
|
|
4c1956 |
+ {
|
|
|
4c1956 |
+ if (afct->preinit != NULL)
|
|
|
4c1956 |
+ afct->preinit (&link_map_audit_state (l, cnt)->cookie);
|
|
|
4c1956 |
+ afct = afct->next;
|
|
|
4c1956 |
+ }
|
|
|
4c1956 |
+}
|
|
|
4c1956 |
+
|
|
|
4c1956 |
void
|
|
|
4c1956 |
_dl_audit_symbind_alt (struct link_map *l, const ElfW(Sym) *ref, void **value,
|
|
|
4c1956 |
lookup_t result)
|
|
|
4c1956 |
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
|
|
|
4c1956 |
index fa55c3bde10de52e..03676b474c3d37a3 100644
|
|
|
4c1956 |
--- a/sysdeps/generic/ldsodefs.h
|
|
|
4c1956 |
+++ b/sysdeps/generic/ldsodefs.h
|
|
|
4c1956 |
@@ -1295,6 +1295,9 @@ void _dl_audit_objopen (struct link_map *l, Lmid_t nsid)
|
|
|
4c1956 |
void _dl_audit_objclose (struct link_map *l)
|
|
|
4c1956 |
attribute_hidden;
|
|
|
4c1956 |
|
|
|
4c1956 |
+/* Call the la_preinit from the audit modules for the link_map L. */
|
|
|
4c1956 |
+void _dl_audit_preinit (struct link_map *l);
|
|
|
4c1956 |
+
|
|
|
4c1956 |
/* Call the la_symbind{32,64} from the audit modules for the link_map L. */
|
|
|
4c1956 |
void _dl_audit_symbind (struct link_map *l, struct reloc_result *reloc_result,
|
|
|
4c1956 |
const ElfW(Sym) *defsym, DL_FIXUP_VALUE_TYPE *value,
|