|
 |
9bb5d6 |
commit dca565886b5e8bd7966e15f0ca42ee5cff686673
|
|
|
9bb5d6 |
Author: DJ Delorie <dj@redhat.com>
|
|
|
9bb5d6 |
Date: Thu Feb 25 16:08:21 2021 -0500
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
nscd: Fix double free in netgroupcache [BZ #27462]
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
In commit 745664bd798ec8fd50438605948eea594179fba1 a use-after-free
|
|
|
9bb5d6 |
was fixed, but this led to an occasional double-free. This patch
|
|
|
9bb5d6 |
tracks the "live" allocation better.
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
Tested manually by a third party.
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
Related: RHBZ 1927877
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
|
|
|
9bb5d6 |
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c
|
|
|
9bb5d6 |
index f521df824102bbca..5ee4413ef9384ec9 100644
|
|
|
9bb5d6 |
--- a/nscd/netgroupcache.c
|
|
|
9bb5d6 |
+++ b/nscd/netgroupcache.c
|
|
|
9bb5d6 |
@@ -248,7 +248,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req,
|
|
|
9bb5d6 |
: NULL);
|
|
|
9bb5d6 |
ndomain = (ndomain ? newbuf + ndomaindiff
|
|
|
9bb5d6 |
: NULL);
|
|
|
9bb5d6 |
- buffer = newbuf;
|
|
|
9bb5d6 |
+ *tofreep = buffer = newbuf;
|
|
|
9bb5d6 |
}
|
|
|
9bb5d6 |
|
|
|
9bb5d6 |
nhost = memcpy (buffer + bufused,
|
|
|
9bb5d6 |
@@ -319,7 +319,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req,
|
|
|
9bb5d6 |
else if (status == NSS_STATUS_TRYAGAIN && e == ERANGE)
|
|
|
9bb5d6 |
{
|
|
|
9bb5d6 |
buflen *= 2;
|
|
|
9bb5d6 |
- buffer = xrealloc (buffer, buflen);
|
|
|
9bb5d6 |
+ *tofreep = buffer = xrealloc (buffer, buflen);
|
|
|
9bb5d6 |
}
|
|
|
9bb5d6 |
else if (status == NSS_STATUS_RETURN
|
|
|
9bb5d6 |
|| status == NSS_STATUS_NOTFOUND
|